From owner-svn-src-head@FreeBSD.ORG Mon Dec 23 11:14:56 2013 Return-Path: Delivered-To: svn-src-head@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 2F674FD; Mon, 23 Dec 2013 11:14:56 +0000 (UTC) Received: from kib.kiev.ua (kib.kiev.ua [IPv6:2001:470:d5e7:1::1]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id 8EDDA13D6; Mon, 23 Dec 2013 11:14:55 +0000 (UTC) Received: from tom.home (kostik@localhost [127.0.0.1]) by kib.kiev.ua (8.14.7/8.14.7) with ESMTP id rBNBEo4V084118; Mon, 23 Dec 2013 13:14:50 +0200 (EET) (envelope-from kostikbel@gmail.com) DKIM-Filter: OpenDKIM Filter v2.8.3 kib.kiev.ua rBNBEo4V084118 Received: (from kostik@localhost) by tom.home (8.14.7/8.14.7/Submit) id rBNBEoO4084117; Mon, 23 Dec 2013 13:14:50 +0200 (EET) (envelope-from kostikbel@gmail.com) X-Authentication-Warning: tom.home: kostik set sender to kostikbel@gmail.com using -f Date: Mon, 23 Dec 2013 13:14:50 +0200 From: Konstantin Belousov To: Alexander Motin Subject: Re: svn commit: r259765 - in head/sys: fs/nfsserver nfs nfsserver Message-ID: <20131223111450.GB59496@kib.kiev.ua> References: <201312230843.rBN8hHTx077901@svn.freebsd.org> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="tI9MNtoWUQpHAhYF" Content-Disposition: inline In-Reply-To: <201312230843.rBN8hHTx077901@svn.freebsd.org> User-Agent: Mutt/1.5.22 (2013-10-16) X-Spam-Status: No, score=-2.0 required=5.0 tests=ALL_TRUSTED,BAYES_00, DKIM_ADSP_CUSTOM_MED,FREEMAIL_FROM,NML_ADSP_CUSTOM_MED autolearn=no version=3.3.2 X-Spam-Checker-Version: SpamAssassin 3.3.2 (2011-06-06) on tom.home Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 23 Dec 2013 11:14:56 -0000 --tI9MNtoWUQpHAhYF Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Mon, Dec 23, 2013 at 08:43:17AM +0000, Alexander Motin wrote: > Author: mav > Date: Mon Dec 23 08:43:16 2013 > New Revision: 259765 > URL: http://svnweb.freebsd.org/changeset/base/259765 >=20 > Log: > Fix RPC server threads file handle affinity to work better with ZFS. > =20 > Instead of taking 8 specific bytes of file handle to identify file du= ring > RPC thread affitinity handling, use trivial hash of the full file handl= e. > ZFS's struct zfid_short does not have padding field after the length fi= eld, > as result, originally picked 8 bytes are loosing lower 16 bits of objec= t ID, > causing many false matches and unneeded requests affinity to same threa= d. > This fix substantially improves NFS server latency and scalability in= SPEC > NFS benchmark by more flexible use of multiple NFS threads. > =20 > Sponsored by: iXsystems, Inc. Did you audited all other filesystems to ensure that struct fid. fid_data0 is filled (zeroed) consistently ? Also, this constitues subtle VFS KBI change. --tI9MNtoWUQpHAhYF Content-Type: application/pgp-signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.22 (FreeBSD) iQIcBAEBAgAGBQJSuBspAAoJEJDCuSvBvK1BwMEP+wamI6B68N8YfFdv6dNGtfQC rKefbACswFJqM4XPFtQ/i0GbWXlcyAldlsSnAzw9goqkIq19uumr7q514SCHckQ5 TGdDoIC1GOXsSisbUU6Qjl1wJgDy7YqNn+CFCWI8DYsD65Dq2W+jZMWgNsJoWWA7 j5PLQcyBVuBNeXy+oQnOaBBXtCRDnSct0HVibAUFheWOwR+gerxvGpo2QJAMs7d+ LziMnnZAgbnDdFidYU+DaL4M1QzfYNVT2plcKE0ZObhxdjWT+0qCU+MjzwK7Th3d 5WOGDJsDbHkta1iOzA1bE0n3DuGN102pr2agIHPru9l23p8AuQNAhHyQAb7YZ5Mc p234zWzJksfI/lZ4mV3QH9LutPmKSdsWOC5VpEJ6glK9K3iyiwor5z7twmRr9+7F lxbUtiJF7G7WTxCrFI9vuQiAfPecf7L1Fk5qw1fOpUyEjiCI0wzCzeC0dhwXNoEU XJfamXWgLWnAlskNY6oFcfnL/u47TpVwCzuMOx/54p25XB+/3zSoo2WWF/l4LtvL +wNOwunAYVB3zci5gOM9ZEvo11kJ/LR19mSIQEEWlN6MSqH7Y8AFdhdQM9Lk328F N6T5A+502OKWiMlG9oQZg1zeJ41TKQoUVHcDcj1th6MK0gTwaMhlEeQ+r6VP4uID NNIUreOqK2Y2qpE69Vbe =z3J2 -----END PGP SIGNATURE----- --tI9MNtoWUQpHAhYF--