Date: Thu, 24 Aug 2017 15:14:36 +0200 From: Mathieu Arnold <mat@FreeBSD.org> To: =?UTF-8?Q?Romain_Tarti=c3=a8re?= <romain@FreeBSD.org>, Baptiste Daroussin <bapt@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, sobomax@FreeBSD.org Subject: Re: svn commit: r448610 - in head/devel/leatherman: . files Message-ID: <88f018e2-52f8-b8e9-248c-edbb9ccc3693@FreeBSD.org> In-Reply-To: <20170824123404.GA15557@blogreen.org> References: <201708231317.v7NDHEGS099253@repo.freebsd.org> <20170823132505.s7kakyqgyb5tdy42@ivaldir.net> <20170823134551.GA13824@blogreen.org> <20170823134934.rjje72qwomm7sd6c@ivaldir.net> <20170823140836.GB13824@blogreen.org> <20170824121232.GA31945@graf.pompo.net> <20170824123404.GA15557@blogreen.org>
next in thread | previous in thread | raw e-mail | index | archive | help
This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --XPGAGvJgcG5Sp1K0IEOr2gkQrEr6e3eSM Content-Type: multipart/mixed; boundary="bMcI1PS3MMaOxK8AnMUe0cUK4HtFXutjP"; protected-headers="v1" From: Mathieu Arnold <mat@FreeBSD.org> To: =?UTF-8?Q?Romain_Tarti=c3=a8re?= <romain@FreeBSD.org>, Baptiste Daroussin <bapt@FreeBSD.org>, ports-committers@freebsd.org, svn-ports-all@freebsd.org, svn-ports-head@freebsd.org, sobomax@FreeBSD.org Message-ID: <88f018e2-52f8-b8e9-248c-edbb9ccc3693@FreeBSD.org> Subject: Re: svn commit: r448610 - in head/devel/leatherman: . files References: <201708231317.v7NDHEGS099253@repo.freebsd.org> <20170823132505.s7kakyqgyb5tdy42@ivaldir.net> <20170823134551.GA13824@blogreen.org> <20170823134934.rjje72qwomm7sd6c@ivaldir.net> <20170823140836.GB13824@blogreen.org> <20170824121232.GA31945@graf.pompo.net> <20170824123404.GA15557@blogreen.org> In-Reply-To: <20170824123404.GA15557@blogreen.org> --bMcI1PS3MMaOxK8AnMUe0cUK4HtFXutjP Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Content-Language: fr Le 24/08/2017 =C3=A0 14:34, Romain Tarti=C3=A8re a =C3=A9crit=C2=A0: > On Thu, Aug 24, 2017 at 02:12:32PM +0200, Thierry Thomas wrote: >> Le mer. 23 ao=C3=BBt 17 =C3=A0 16:08:36 +0200, Romain Tarti=C3=A8re <r= omain@FreeBSD.org> >> =C3=A9crivait=C2=A0: >> >>> Another point with `make makepatch`: in the post-patch target, I alte= r >>> the patched source code. `make makepatch` wants the combined patches= to >>> be combined: >>> >>> ---------------------------------- 8< -------------------------------= --- >>> -+ return "%%PREFIX%%/etc/facter/facter.conf"; >>> ++ return "/usr/local/etc/facter/facter.conf"; >>> ---------------------------------- 8< -------------------------------= --- >> This is why this kind of substitutions are better in pre-configure. >> Logically, post-patch is for static replacements, not for variables >> depending on the configuration options. > Makes sense. I found a warkaround (make extract do-patch makepatch), > but this solution seems definitively better. But pre-configure must not be used for patching. All patching must happen in the patch phase.=C2=A0 It is supposed to be used to set things = up before the configure script runs. --=20 Mathieu Arnold --bMcI1PS3MMaOxK8AnMUe0cUK4HtFXutjP-- --XPGAGvJgcG5Sp1K0IEOr2gkQrEr6e3eSM Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQJ8BAEBCgBmBQJZntFBXxSAAAAAAC4AKGlzc3Vlci1mcHJAbm90YXRpb25zLm9w ZW5wZ3AuZmlmdGhob3JzZW1hbi5uZXQzQUI2OTc4OUQyRUQxMjEwNjQ0MEJBNUIz QTQ1MTZGMzUxODNDRTQ4AAoJEDpFFvNRg85IryAP/jFrODNEcQ0cny2Oclo2Gwia I+/voSjCd3AF1Eos3nF4cBx57cIP7MoU3jp2z25hqh0Cw3z8IfjE1TWyFxpm5M3S w4Y8g1VdV2uPoZgWvSnZkHAvuX8bFGH6SEx+M1QrdDd25Ja/Bqdc8tNWEpm3EPkg /JGusu9vOVOr24y11uQ5wQNxO0Jd7R4M9YOSMHk3dXNCOOtgMm/BtlxXln4s34bw 7tJTPaaGhJevWdU9gPfAfwfTgsOGQud8ujG2Q2rDTsQr1//cYcyIXqFyXzTYFsJh gpj+a+2QS6m2GPvYq/HNyPGZIKORSdjiwsqmBX8rPo9q466vS/96NmKZ7UdtY1rC qozEn/cXlbh7wEetbbvnoO8E3/FjlbyCT+/zYU5va8MgjbG5YJO6hVYDiE5wcwz2 wmeqenNZSyK0WAJIWtdIGLnRZtqqqSXyUvD+dGr+wD4vPfetBAsLTdUCM+Ki1BNs oTVuLnFMYMJUsq7PFC6iWNEnGd/J6qsIgwaafp/vqm3iSG7I9DC1mf4khlMCtTdH kX3osZ29LEclzmaB/A34yPRcCqjQp8FvHXCkCKi9GlLP/PnQED5YokEIbeo14+Bp 8o6enDqbpvrl2/SSKiapNnm6ynavwfpFyp+hKjXAnDG3ZBYC3iJfs6In6Dw1CgLc C4AFo53EMRtNJqtHju8h =HEK3 -----END PGP SIGNATURE----- --XPGAGvJgcG5Sp1K0IEOr2gkQrEr6e3eSM--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?88f018e2-52f8-b8e9-248c-edbb9ccc3693>