From owner-freebsd-arch Sun Mar 25 11:15:15 2001 Delivered-To: freebsd-arch@freebsd.org Received: from harmony.village.org (rover.bsdimp.com [204.144.255.66]) by hub.freebsd.org (Postfix) with ESMTP id 5C7E137B71B for ; Sun, 25 Mar 2001 11:15:10 -0800 (PST) (envelope-from imp@harmony.village.org) Received: from harmony.village.org (localhost.village.org [127.0.0.1]) by harmony.village.org (8.11.1/8.11.1) with ESMTP id f2PJF0980349; Sun, 25 Mar 2001 12:15:00 -0700 (MST) (envelope-from imp@harmony.village.org) Message-Id: <200103251915.f2PJF0980349@harmony.village.org> To: Peter Pentchev Subject: Re: Building only a specified list of kernel modules Cc: arch@FreeBSD.ORG In-reply-to: Your message of "Sun, 25 Mar 2001 21:46:58 +0300." <20010325214658.F3241@ringworld.oblivion.bg> References: <20010325214658.F3241@ringworld.oblivion.bg> <20010324211140.C4304@ringworld.oblivion.bg> <200103251840.f2PIeE973790@harmony.village.org> Date: Sun, 25 Mar 2001 12:15:00 -0700 From: Warner Losh Sender: owner-freebsd-arch@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In message <20010325214658.F3241@ringworld.oblivion.bg> Peter Pentchev writes: : On Sun, Mar 25, 2001 at 11:40:14AM -0700, Warner Losh wrote: : > I object to this patch. It is needlessly complicated. It adds too : > many icky knobs to the tree, created duplicate places where you'd need : > lists, etc. : : With your patch, if I want any kind of sound support in my kernel, : I still have to compile all the sound drivers. Same for syscons, : same for netgraph, same for any upcoming 'second-level domain' directory. : Me no like :) You are mistaken. I've succuessfully just built one sound driver + the pcm base with using makeoptions MODULES_OVERRIDE="sound/pcm sound/driver/es137x" So your objection is more one of ignorance of what can be done with the patches rather than a failing in the patches. Note, I had to patch the Makefile.${MACHINE_ARCH} as well, so the complete patch looks more like: Index: modules/Makefile =================================================================== RCS file: /home/imp/FreeBSD/CVS/src/sys/modules/Makefile,v retrieving revision 1.171 diff -u -r1.171 Makefile --- modules/Makefile 2001/03/09 20:10:30 1.171 +++ modules/Makefile 2001/03/19 19:17:28 @@ -30,4 +30,8 @@ SUBDIR+=osf1 .endif +.if defined(MODULES_OVERRIDE) +SUBDIR=${MODULES_OVERRIDE} +.endif + .include Index: conf/Makefile.alpha =================================================================== RCS file: /home/imp/FreeBSD/CVS/src/sys/conf/Makefile.alpha,v retrieving revision 1.94 diff -u -r1.94 Makefile.alpha --- conf/Makefile.alpha 2001/03/12 07:47:09 1.94 +++ conf/Makefile.alpha 2001/03/25 19:12:35 @@ -324,6 +324,9 @@ .endif MKMODULESENV= MAKEOBJDIRPREFIX=${.OBJDIR}/modules KMODDIR=${KODIR} +.if defined(MODULES_OVERRIDE) +MKMODULESENV+= MODULES_OVERRIDE="${MODULES_OVERRIDE}" +.endif modules: @mkdir -p ${.OBJDIR}/modules Index: conf/Makefile.i386 =================================================================== RCS file: /home/imp/FreeBSD/CVS/src/sys/conf/Makefile.i386,v retrieving revision 1.227 diff -u -r1.227 Makefile.i386 --- conf/Makefile.i386 2001/03/12 07:47:09 1.227 +++ conf/Makefile.i386 2001/03/25 19:11:53 @@ -284,6 +284,9 @@ .endif MKMODULESENV= MAKEOBJDIRPREFIX=${.OBJDIR}/modules KMODDIR=${KODIR} +.if defined(MODULES_OVERRIDE) +MKMODULESENV+= MODULES_OVERRIDE="${MODULES_OVERRIDE}" +.endif modules: @mkdir -p ${.OBJDIR}/modules Index: conf/Makefile.ia64 =================================================================== RCS file: /home/imp/FreeBSD/CVS/src/sys/conf/Makefile.ia64,v retrieving revision 1.16 diff -u -r1.16 Makefile.ia64 --- conf/Makefile.ia64 2001/03/12 07:47:09 1.16 +++ conf/Makefile.ia64 2001/03/25 19:12:12 @@ -288,6 +288,9 @@ .endif MKMODULESENV= MAKEOBJDIRPREFIX=${.OBJDIR}/modules KMODDIR=${KODIR} +.if defined(MODULES_OVERRIDE) +MKMODULESENV+= MODULES_OVERRIDE="${MODULES_OVERRIDE}" +.endif modules: @mkdir -p ${.OBJDIR}/modules Index: conf/Makefile.pc98 =================================================================== RCS file: /home/imp/FreeBSD/CVS/src/sys/conf/Makefile.pc98,v retrieving revision 1.126 diff -u -r1.126 Makefile.pc98 --- conf/Makefile.pc98 2001/03/12 07:47:09 1.126 +++ conf/Makefile.pc98 2001/03/25 19:12:02 @@ -287,6 +287,9 @@ .endif MKMODULESENV= MAKEOBJDIRPREFIX=${.OBJDIR}/modules KMODDIR=${KODIR} +.if defined(MODULES_OVERRIDE) +MKMODULESENV+= MODULES_OVERRIDE="${MODULES_OVERRIDE}" +.endif MKMODULESENV+= MACHINE=pc98 modules: Warner To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-arch" in the body of the message