From nobody Wed Oct 1 07:49:08 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4cc6WX0VQwz6952F; Wed, 01 Oct 2025 07:49:12 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: from smtp.freebsd.org (smtp.freebsd.org [IPv6:2610:1c1:1:606c::24b:4]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "smtp.freebsd.org", Issuer "R13" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4cc6WX00LVz3wv1; Wed, 01 Oct 2025 07:49:12 +0000 (UTC) (envelope-from kp@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759304952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tTEs356THfIVZwnuiWjkfVEcWUHRlm4hA5v3UOsGmYQ=; b=F/8ftIFvva95/M2kgik1Jj60kuxvmLG0uRYd0L8+duWnpVfnvILqh5gdCJw9siNng9Njh8 u4RnY14op/jW39CEO7f8aQXO/FhqtknRXrEe65IJ0y+666y0daVE1HKAwcR1t9jqkWdxEP bF9n2A4r/PiBkdh6U0S32vJ/jC4+Keh3TynUGHt9pbbfnEG5sRGNdSoOdRuA2H9YKOB9P0 kUSqIzKopTAdO/CNWeUPep2TQHGPNc7Ye1ttF7X03ZclmhsMKDuWWCtPqlzz0JsbSg5PHg NbRYYbYyOnmFxc7V1EP9D7XBWchB+oi7L0vtSMA8f6kMxeWZfMhdyEJ0OhL2xA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1759304952; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=tTEs356THfIVZwnuiWjkfVEcWUHRlm4hA5v3UOsGmYQ=; b=JnVSzK/hEc8CU02QMfaRJ/8LTLqrHxoYj6wNYETSKHniRBrPWc4xTP04GNwRd9uKiKc7UY lUGk0OvHmxhwrCGPqAf/nFDNnYekrSrtwKCotnUtBg0t4rQ+hlGRRdh75jTj16YKIohR1r +q3LtMzMimxOJm/rRDIA9qAzICNStFlAnXZh7dbwPrtpChrLc6n3RpQB2mwCnaI5jvZRBb WhD/RgVV6/LKn7E+uGiWgQCvg86KKD7a77wrua+/qyqNv7/XuUSjVfOa9hf6cmL3YETDtj YxhOBC529/LQz9E0lkVoXE+yb5X+H/3rytruaRHLNyMF/8FjgRTvyfTR8d6pAQ== ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1759304952; a=rsa-sha256; cv=none; b=ugHLmOXRMsw26laQIcJp5uHsXBZQ8/Rx7WhwQHHsDJAVGNuXbXBn/n3OxOqW+LgmxBcaAi DLM5YtYjYVglkbSa5VcVnncR3j6ZSbMWkQfNp9p5iTkBGt3VYkb7RXVEffvTl2HQ8jv8Iv bEXdA47U/51GbdPSXJlYzGKrOF0WkBzfE+QU3ic0k4m6K1nF6r3Pq+IYs/qaftptlRs9uu bxJNJH2ZXwLbJ/hYXald/+KnlA5d8S8DDGWraWYIWdK+Wui+wJDKDiTJ8kBiBXc/dMYdrh V07+DpSmO+XdyVtoRvXqxlgDBf5NsYqBoQKQx3DU/snRA83iysnU4TeXrHcFug== ARC-Authentication-Results: i=1; mx1.freebsd.org; none Received: from venus.codepro.be (venus.codepro.be [5.9.86.228]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "mx1.codepro.be", Issuer "R11" (verified OK)) (Authenticated sender: kp) by smtp.freebsd.org (Postfix) with ESMTPSA id 4cc6WW5dQ4z41R; Wed, 01 Oct 2025 07:49:11 +0000 (UTC) (envelope-from kp@FreeBSD.org) Received: by venus.codepro.be (Postfix, authenticated sender kp) id 98A0210052; Wed, 01 Oct 2025 09:49:09 +0200 (CEST) From: Kristof Provost To: Gleb Smirnoff Cc: ItzBlinkzy , Kevin Irabor , src-committers@freebsd.org, dev-commits-src-all@freebsd.org, dev-commits-src-main@freebsd.org Subject: Re: git: 4e7a375804e5 - main - IfAPI: Added missing accessor for if_home_vnet Date: Wed, 01 Oct 2025 09:49:08 +0200 X-Mailer: MailMate (2.0r6272) Message-ID: In-Reply-To: References: <202509292116.58TLGxWx078766@gitrepo.freebsd.org> <9E63C594-08DD-43CD-BD76-3E9B9E80AA60@FreeBSD.org> List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=UTF-8; markup=markdown Content-Transfer-Encoding: quoted-printable On 30 Sep 2025, at 20:11, Gleb Smirnoff wrote: > On Tue, Sep 30, 2025 at 07:51:05PM +0200, Kristof Provost wrote: > K> > The actual question is whether there is a driver that really needs= to access > K> > this field or was this added by the logic that if a field exists i= n struct > K> > ifnet, a function to access it shall exist? > K> > > K> It=E2=80=99s hard to predict what fields will be relevant for out-of= -tree consumers, but it seems reasonable to allow access to this one give= n we already allow the current vnet to be accessed too. > > As we discussed earlier through the last decade, the ifnet is poorly de= signed > and we need a new API. But as that was a heavy weight to lift, that wa= s never > finished. Juniper came with a plan to provide accessors. They would n= ot make > API any better or prettier, but would basically provide binary compatib= ility > for a case when struct ifnet grows or is rearranged but all existing fi= elds > remain! We agreed that this is an interim step towards a better API in = a > future. The Juniper's API shall provide access to minimal set of ifnet= fields > that current drivers use. It should not encourage use of fields that be= long to > the stack, not to the drivers. So, the question is what is the driver t= hat > needs if_home_vnet? Who is maintaining it and what are they going to do= if I > remove if_home_vnet together with if_vmove? > Good questions. I hope Kevin can tell us what his use case for this is, b= ecause it=E2=80=99s always easier to think about these things with specif= ic problems in mind. =E2=80=94 Kristof