From owner-cvs-src@FreeBSD.ORG Mon Jun 11 07:45:21 2007 Return-Path: X-Original-To: cvs-src@freebsd.org Delivered-To: cvs-src@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [69.147.83.52]) by hub.freebsd.org (Postfix) with ESMTP id 21E3116A46E for ; Mon, 11 Jun 2007 07:45:21 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: from nz-out-0506.google.com (nz-out-0506.google.com [64.233.162.226]) by mx1.freebsd.org (Postfix) with ESMTP id CD77C13C455 for ; Mon, 11 Jun 2007 07:45:20 +0000 (UTC) (envelope-from pyunyh@gmail.com) Received: by nz-out-0506.google.com with SMTP id 14so1004599nzn for ; Mon, 11 Jun 2007 00:45:20 -0700 (PDT) DKIM-Signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:received:received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=oi1UWmggu6mjQgA86YpVWDtajs6Fs1Gg6s5OAopGII0z2MpbzxjaZY6vwTDqsMAXZ9HLEo95bKiHplXLPoFjcD07l04IYaWL49NGlr3gxX1Q1tXHhPK1KU/d0wWi+i2HIm2dbCCTZHmht9zyVaAFL7VjIPrnBgLm8VTGdhsDDNY= DomainKey-Signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:date:from:to:cc:subject:message-id:reply-to:references:mime-version:content-type:content-disposition:in-reply-to:user-agent; b=ebzPE4VQ1uALX/Rq6OnMLaRXhGCVlBABztAxTUCfchHY0zyTQ5mBNWwwqrMW7sBPqlNJrH/fq1URJ6QfkKQv5Rv8rjJeiWnOjI4OTDeyRlRLNXULOLavPYCCV2pI0GQcb21t1cGMKY82eQk/gYJzV7mwp3aoRPwYFPntGmjV2Mg= Received: by 10.115.91.2 with SMTP id t2mr5212488wal.1181547920038; Mon, 11 Jun 2007 00:45:20 -0700 (PDT) Received: from michelle.cdnetworks.co.kr ( [211.53.35.84]) by mx.google.com with ESMTP id j29sm7672062waf.2007.06.11.00.45.08 (version=TLSv1/SSLv3 cipher=OTHER); Mon, 11 Jun 2007 00:45:17 -0700 (PDT) Received: from michelle.cdnetworks.co.kr (localhost.cdnetworks.co.kr [127.0.0.1]) by michelle.cdnetworks.co.kr (8.13.5/8.13.5) with ESMTP id l5B7ivwk042233 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=NO); Mon, 11 Jun 2007 16:44:57 +0900 (KST) (envelope-from pyunyh@gmail.com) Received: (from yongari@localhost) by michelle.cdnetworks.co.kr (8.13.5/8.13.5/Submit) id l5B7iuEi042232; Mon, 11 Jun 2007 16:44:56 +0900 (KST) (envelope-from pyunyh@gmail.com) Date: Mon, 11 Jun 2007 16:44:56 +0900 From: Pyun YongHyeon To: Andre Oppermann Message-ID: <20070611074456.GE39661@cdnetworks.co.kr> References: <200706110155.l5B1t9d9043150@repoman.freebsd.org> <466CFBE2.1090907@freebsd.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <466CFBE2.1090907@freebsd.org> User-Agent: Mutt/1.4.2.1i Cc: cvs-src@freebsd.org, src-committers@freebsd.org, cvs-all@freebsd.org, Pyun YongHyeon Subject: Re: cvs commit: src/sys/dev/msk if_msk.c X-BeenThere: cvs-src@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list Reply-To: pyunyh@gmail.com List-Id: CVS commit messages for the src tree List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 11 Jun 2007 07:45:21 -0000 On Mon, Jun 11, 2007 at 09:38:10AM +0200, Andre Oppermann wrote: > Pyun YongHyeon wrote: > >yongari 2007-06-11 01:55:09 UTC > > > > FreeBSD src repository > > > > Modified files: > > sys/dev/msk if_msk.c > > Log: > > Disable automatic IP ID increment. Due to a hardware bug the automatic > > IP ID increment in TSO case generated corrupted IP packets. > > This change brings back TSO capability. > > > > Revision Changes Path > > 1.16 +0 -15 src/sys/dev/msk/if_msk.c > > Please add check for the DF (Don't fragment) bit in the IP header. > Otherwise we may run into trouble when fragmentation happens along > the path. We almost always set DF on TCP connections. If it is not > set please return EMSGSIZE which will cause TSO to be turned off. > Is there any way to return EMSGSIZE to upper layer? if_start has return type void. Or just dropping the packet if DF bit was not set is enough? -- Regards, Pyun YongHyeon