From owner-svn-src-head@FreeBSD.ORG  Mon Apr 29 16:19:12 2013
Return-Path: <owner-svn-src-head@FreeBSD.ORG>
Delivered-To: svn-src-head@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org
 [IPv6:2001:1900:2254:206a::19:1])
 by hub.freebsd.org (Postfix) with ESMTP id E4E26D66;
 Mon, 29 Apr 2013 16:19:12 +0000 (UTC)
 (envelope-from adrian.chadd@gmail.com)
Received: from mail-wi0-x22c.google.com (mail-wi0-x22c.google.com
 [IPv6:2a00:1450:400c:c05::22c])
 by mx1.freebsd.org (Postfix) with ESMTP id AFA6B1E7B;
 Mon, 29 Apr 2013 16:19:11 +0000 (UTC)
Received: by mail-wi0-f172.google.com with SMTP id hm14so2956995wib.5
 for <multiple recipients>; Mon, 29 Apr 2013 09:19:10 -0700 (PDT)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113;
 h=mime-version:x-received:sender:in-reply-to:references:date
 :x-google-sender-auth:message-id:subject:from:to:cc:content-type;
 bh=I8Ds3v/llIXlNhzM6734dyXukMNv3G4VlLPiagD+Sqs=;
 b=tkijf8cN+jnW+O9cK54VwNdLMANkQNpsCZ70e8mI72bQ2bObSWhJU+U9XB7GdMbNP9
 Wd57d6VFcllFW9iFdoOst0/smQV0ed9s/Ui4IC7bz0VPeaHSBcO2n8BHDuRQ9FBQC7HT
 OJTQ4kxxPTG8x6044XMWDBRc7xhB36a2cVB7wueV9hu1OCdtCK9SZXuf5kBNjWhEbDxo
 bdXNZuTE6H51sG9Qs/3QTN0dNXesGcC0fQ/PcrwwNDZRnRMtvMRtHIb20X29yxb+q+lr
 sm3LgSdrCw6dK432xvUQfZ0zRRDGH4jGoDvkaMVn6xsfoTCKuGpKKKaZE5z34A05m5+K
 1ddw==
MIME-Version: 1.0
X-Received: by 10.180.89.140 with SMTP id bo12mr1699154wib.22.1367252350884;
 Mon, 29 Apr 2013 09:19:10 -0700 (PDT)
Sender: adrian.chadd@gmail.com
Received: by 10.217.58.138 with HTTP; Mon, 29 Apr 2013 09:19:10 -0700 (PDT)
In-Reply-To: <201304291123.41402.jhb@freebsd.org>
References: <201304231302.r3ND2w5V024981@svn.freebsd.org>
 <CALCpEUExXu+CsM4ORr=Z=tMXvLJSqQn-sEOwY0aQ6GHCHeA50w@mail.gmail.com>
 <CALCpEUH2NZHpx6e7SCJRFkHZo2TOzXiZRFt_9UpgVO9+b13kFA@mail.gmail.com>
 <201304291123.41402.jhb@freebsd.org>
Date: Mon, 29 Apr 2013 09:19:10 -0700
X-Google-Sender-Auth: UyFBBmv_Ooyqj-ru8AVAj2pZiZk
Message-ID: <CAJ-Vmon_C2+OZNxH74A0mY=qf3E+m16aHwA8wri0xzJsfJ-LuA@mail.gmail.com>
Subject: Re: svn commit: r249800 - head/sys/dev/bwn
From: Adrian Chadd <adrian@freebsd.org>
To: John Baldwin <jhb@freebsd.org>
Content-Type: text/plain; charset=ISO-8859-1
Cc: svn-src-head <svn-src-head@freebsd.org>, Eitan Adler <eadler@freebsd.org>,
 svn-src-all <svn-src-all@freebsd.org>,
 src-committers <src-committers@freebsd.org>,
 hiren panchasara <hiren@freebsd.org>
X-BeenThere: svn-src-head@freebsd.org
X-Mailman-Version: 2.1.14
Precedence: list
List-Id: SVN commit messages for the src tree for head/-current
 <svn-src-head.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/svn-src-head>
List-Post: <mailto:svn-src-head@freebsd.org>
List-Help: <mailto:svn-src-head-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/svn-src-head>,
 <mailto:svn-src-head-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Mon, 29 Apr 2013 16:19:13 -0000

On 29 April 2013 08:23, John Baldwin <jhb@freebsd.org> wrote:
>> -       dr->setdesc(dr, desc, paddr, meta->mt_m->m_len -
>> +       dr->setdesc(dr, desc, meta->mt_paddr, meta->mt_m->m_len -
>>             sizeof(*hdr), 0, 0, 0);
>>         return (error);
>>  }
>
> I would leave the comment alone.  In the common case you do allocate a new
> mbuf so you aren't restoring the descriptor but setting it up with a new
> address.  The code change looks correct.

Does anyone here have bwn hardware that works?



Adrian