From owner-cvs-ports@FreeBSD.ORG Sun Jul 13 04:47:47 2008
Return-Path: <owner-cvs-ports@FreeBSD.ORG>
Delivered-To: cvs-ports@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
by hub.freebsd.org (Postfix) with ESMTP id B27E11065675
for <cvs-ports@FreeBSD.org>; Sun, 13 Jul 2008 04:47:47 +0000 (UTC)
(envelope-from dougb@FreeBSD.org)
Received: from mail2.fluidhosting.com (mx23.fluidhosting.com [204.14.89.6])
by mx1.freebsd.org (Postfix) with ESMTP id 2AF5C8FC1E
for <cvs-ports@FreeBSD.org>; Sun, 13 Jul 2008 04:47:47 +0000 (UTC)
(envelope-from dougb@FreeBSD.org)
Received: (qmail 10078 invoked by uid 399); 13 Jul 2008 04:47:46 -0000
Received: from localhost (HELO lap.dougb.net) (dougb@dougbarton.us@127.0.0.1)
by localhost with ESMTPAM; 13 Jul 2008 04:47:46 -0000
X-Originating-IP: 127.0.0.1
X-Sender: dougb@dougbarton.us
Message-ID: <487988F0.9080306@FreeBSD.org>
Date: Sat, 12 Jul 2008 21:47:44 -0700
From: Doug Barton <dougb@FreeBSD.org>
Organization: http://www.FreeBSD.org/
User-Agent: Thunderbird 2.0.0.14 (X11/20080606)
MIME-Version: 1.0
To: Ion-Mihai Tetcu <itetcu@FreeBSD.org>
References: <200807130437.m6D4bf1u097284@repoman.freebsd.org>
In-Reply-To: <200807130437.m6D4bf1u097284@repoman.freebsd.org>
X-Enigmail-Version: 0.95.6
OpenPGP: id=D5B2F0FB
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
Cc: cvs-ports@FreeBSD.org, cvs-all@FreeBSD.org, ports-committers@FreeBSD.org
Subject: Re: cvs commit: ports/www/apache13-ssl Makefile pkg-plist
ports/www/apache13-ssl/files apache.in apache.sh extra-patch-noportdocs
X-BeenThere: cvs-ports@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: CVS commit messages for the ports tree <cvs-ports.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
<mailto:cvs-ports-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/cvs-ports>
List-Post: <mailto:cvs-ports@freebsd.org>
List-Help: <mailto:cvs-ports-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/cvs-ports>,
<mailto:cvs-ports-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Sun, 13 Jul 2008 04:47:47 -0000
Ion-Mihai Tetcu wrote:
> itetcu 2008-07-13 04:37:41 UTC
>
> FreeBSD ports repository
>
> Modified files:
> www/apache13-ssl Makefile pkg-plist
> Added files:
> www/apache13-ssl/files apache.in extra-patch-noportdocs
> Removed files:
> www/apache13-ssl/files apache.sh
> Log:
> - Honor NO* vars (noticed by ionbot)
> - Silence some portlint warnings
> - USE_RC_SUBR from the rc.d script
> - Bump PORTREVISION
>
> PR: 125131 http://www.FreeBSD.org/cgi/query-pr.cgi?pr=125131
> Submitted by: Philip M. Gollucci
>
> Revision Changes Path
> 1.123 +8 -11 ports/www/apache13-ssl/Makefile
> 1.1 +63 -0 ports/www/apache13-ssl/files/apache.in (new)
> 1.3 +0 -62 ports/www/apache13-ssl/files/apache.sh (dead)
> 1.1 +22 -0 ports/www/apache13-ssl/files/extra-patch-noportdocs (new)
> 1.29 +8 -9 ports/www/apache13-ssl/pkg-plist
>
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-ssl/Makefile.diff?&r1=1.122&r2=1.123&f=h
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-ssl/files/apache.in
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-ssl/files/apache.sh
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-ssl/files/extra-patch-noportdocs
> http://www.FreeBSD.org/cgi/cvsweb.cgi/ports/www/apache13-ssl/pkg-plist.diff?&r1=1.28&r2=1.29&f=h
Overall the rc.d changes look good. The only (non-crucial) change I'd
make is to put load_rc_config before the tests for empty variables.
hth,
Doug
--
This .signature sanitized for your protection