From owner-freebsd-current Sun Apr 19 10:08:58 1998 Return-Path: Received: (from majordom@localhost) by hub.freebsd.org (8.8.8/8.8.8) id KAA18299 for freebsd-current-outgoing; Sun, 19 Apr 1998 10:08:58 -0700 (PDT) (envelope-from owner-freebsd-current@FreeBSD.ORG) Received: from cons.org (knight.cons.org [194.233.237.86]) by hub.freebsd.org (8.8.8/8.8.8) with ESMTP id RAA18281 for ; Sun, 19 Apr 1998 17:08:51 GMT (envelope-from cracauer@cons.org) Received: (from cracauer@localhost) by cons.org (8.8.8/8.7.3) id TAA16934; Sun, 19 Apr 1998 19:08:36 +0200 (CEST) Message-ID: <19980419190835.27394@cons.org> Date: Sun, 19 Apr 1998 19:08:35 +0200 From: Martin Cracauer To: Bruce Evans , cracauer@cons.org Cc: freebsd-current@FreeBSD.ORG Subject: Re: make/SIGINT (Re: cvs commit: src/bin/sh jobs.c) Mail-Followup-To: Bruce Evans , cracauer@cons.org, freebsd-current@FreeBSD.ORG References: <199804191143.VAA00099@godzilla.zeta.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii X-Mailer: Mutt 0.89i In-Reply-To: <199804191143.VAA00099@godzilla.zeta.org.au>; from Bruce Evans on Sun, Apr 19, 1998 at 09:43:30PM +1000 Sender: owner-freebsd-current@FreeBSD.ORG Precedence: bulk X-Loop: FreeBSD.ORG In <199804191143.VAA00099@godzilla.zeta.org.au>, Bruce Evans wrote: > >In <199803131513.CAA27634@godzilla.zeta.org.au>, Bruce Evans wrote: > >> SIGQUIT handling is still buggy. For the simple Makefile: > >> --- > >> foo: > >> sleep 1000 > >> --- > >> killing make with SIGQUIT gives the following behaviours: > >> > >> 1. make: exits with status 3 (SIGQUIT) (per the above change). > >> 2. make -j4: hangs (broken). > >> 3: gmake: exits with status 1. > >> 3: gmake -j4: exits with status 1. > >> > >> POSIX.2 only requires a nonzero exit status for SIGQUIT. We've just > >> fixed the handling of SIGINT, SIGTERM and SIGHUP. > > > >The appended diff fixes the hangs for `make -j4`->SIGQUIT by exiting > >with SIGINT exit status. > > > >I don't consider it that ugly to report exit on SIGINT to the calling > >process when the actual signal was SIGQUIT. Alternativly, we could > >limit coredumpsize = 0 and then exit with SIGQUIT. > > I think I prefer to limit the coredump size. The problem with that is that it makes it harder to maintain source compatiblity with other systems (i.e. SunOS4, if I remeber right). > I thought that this bunch of changes (at least to shell and make) was > ready to commit until a few minutes ago when I tried to kill a `make > depend' in src/lib. It didn't work - some sub-make[s] kept running. I also have a script that isn't interruptable in our new sh, but in bash. I am looking into it. Martin -- %%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%%% Martin Cracauer http://www.cons.org/cracauer cracauer@wavehh.hanse.de (batched, preferred for large mails) Tel.: (daytime) +4940 41478712 Fax.: (daytime) +4940 41478715 Tel.: (private) +4940 5221829 Fax.: (private) +4940 5228536 Paper: (private) Waldstrasse 200, 22846 Norderstedt, Germany To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-current" in the body of the message