Date: Wed, 31 Aug 2005 16:03:01 +0200 From: Pawel Jakub Dawidek <pjd@FreeBSD.org> To: Gleb Smirnoff <glebius@FreeBSD.org> Cc: cvs-src@FreeBSD.org, src-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: Re: cvs commit: src/sys/netinet tcp_syncache.c Message-ID: <20050831140301.GB791@garage.freebsd.pl> In-Reply-To: <200508311356.j7VDuG2v098047@repoman.freebsd.org> References: <200508311356.j7VDuG2v098047@repoman.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
[-- Attachment #1 --]
On Wed, Aug 31, 2005 at 01:56:15PM +0000, Gleb Smirnoff wrote:
+> glebius 2005-08-31 13:56:15 UTC
+>
+> FreeBSD src repository
+>
+> Modified files: (Branch: RELENG_6)
+> sys/netinet tcp_syncache.c
+> Log:
+> MFC 1.76:
+> - Refuse hashsize of 0, since it is invalid.
[...]
+> - if (!powerof2(tcp_syncache.hashsize)) {
+> + if (!powerof2(tcp_syncache.hashsize) || tcp_syncache.hashsize == 0) {
I ran into this as well. The problem here is powerof2() macro and the macro
should be fixed: 0 is not a power of 2.
--
Pawel Jakub Dawidek http://www.wheel.pl
pjd@FreeBSD.org http://www.FreeBSD.org
FreeBSD committer Am I Evil? Yes, I Am!
[-- Attachment #2 --]
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v1.4.1 (FreeBSD)
iD8DBQFDFbiVForvXbEpPzQRAu7wAKDOsH0o7OlHmpUwdQwVg+eiDIdcLwCg0rqw
u86A1ThbGW38r2mu2Qio/fw=
=eKwV
-----END PGP SIGNATURE-----
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?20050831140301.GB791>