From owner-svn-src-all@freebsd.org Wed May 11 23:01:18 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 84B1DB38A31; Wed, 11 May 2016 23:01:18 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: from mail-oi0-f66.google.com (mail-oi0-f66.google.com [209.85.218.66]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4EB931D3D; Wed, 11 May 2016 23:01:17 +0000 (UTC) (envelope-from cse.cem@gmail.com) Received: by mail-oi0-f66.google.com with SMTP id i2so9626889oib.3; Wed, 11 May 2016 16:01:17 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:reply-to:in-reply-to:references :date:message-id:subject:from:to:cc:content-transfer-encoding; bh=OYEGFrk0wcaq6/tK5OBUlrh0YSSAOwezOihSu7LmbtY=; b=cH/rf+lOssicOe2xqi+ErjPAt+lPIWe2mA+dB2YLgRyQSvf3EbJpKaKFN9iO4X1uxY 8CyOKuKFomFVg/kQ4A64DJ7HlI/oxcCPYNCUEBGLrQBcY5gViCOwFx4qF170c4SuqlUW 5+WZ1i1dVNF2Hy37YbqSTRXRfh87uWOvk2pYIA+GpY4GJW0nD0CeVLop7BklVVc0/33R zOZ84152AZwKYXhoxd/wT3izuckOmNGr0mdJP2H76HR6I21g/ebZFWyHuoGvtTsCPUER 7tQPJuPWfnhTilaUqtMDrm5JGcaDlgyLIMa2SBeNHItiEse9P7izntDDEe3UZ1zU0EX6 gTvw== X-Gm-Message-State: AOPr4FV5nPj4Mp3QuVRpyEj+hFaWnSOtVJk3rTk44wLKpdgbWZBcNfyXjWHR+ijGzB3YdA== X-Received: by 10.157.12.210 with SMTP id o18mr3731421otd.192.1463007676785; Wed, 11 May 2016 16:01:16 -0700 (PDT) Received: from mail-oi0-f48.google.com (mail-oi0-f48.google.com. [209.85.218.48]) by smtp.gmail.com with ESMTPSA id 78sm2904956otd.12.2016.05.11.16.01.16 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 11 May 2016 16:01:16 -0700 (PDT) Received: by mail-oi0-f48.google.com with SMTP id x19so92803235oix.2; Wed, 11 May 2016 16:01:16 -0700 (PDT) MIME-Version: 1.0 X-Received: by 10.157.36.135 with SMTP id z7mr3441984ota.69.1463007676259; Wed, 11 May 2016 16:01:16 -0700 (PDT) Reply-To: cem@FreeBSD.org Received: by 10.157.19.20 with HTTP; Wed, 11 May 2016 16:01:16 -0700 (PDT) In-Reply-To: References: <201605111707.u4BH7UXs040026@repo.freebsd.org> Date: Wed, 11 May 2016 16:01:16 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: svn commit: r299467 - in head: share/man/man9 sys/dev/pci From: Conrad Meyer To: Jung-uk Kim , Andrew Turner Cc: "Bjoern A. Zeeb" , src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.22 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 11 May 2016 23:01:18 -0000 Backed out in r299493. Please re-commit after it compiles. Best, Conrad On Wed, May 11, 2016 at 2:50 PM, Jung-uk Kim wrote: > On 05/11/16 05:38 PM, Bjoern A. Zeeb wrote: >> >>> On 11 May 2016, at 17:07 , Andrew Turner wrote: >>> >>> Author: andrew >>> Date: Wed May 11 17:07:29 2016 >>> New Revision: 299467 >>> URL: https://svnweb.freebsd.org/changeset/base/299467 >>> >>> Log: >>> Add a new get_id interface to pci and pcib. This will allow us to both >>> detect failures, and get different PCI IDs. >>> >>> For the former the interface returns an int to signal an error. The ID= is >>> returned at a uintptr_t * argument. >>> >>> For the latter there is a type argument that allows selecting the ID t= ype. >>> This only specifies a single type, however a MSI type will be added >>> to handle the need to find the ID the hardware passes to the ARM GICv3 >>> interrupt controller. >>> >>> A follow up commit will be made to remove pci_get_rid. >>> >>> Reviewed by: jhb, rstone >>> Obtained from: ABT Systems Ltd >>> Sponsored by: The FreeBSD Foundation >>> Differential Revision: https://reviews.freebsd.org/D6239 >> >> Hi, seems gcc, I guess it is, doesn=E2=80=99t like your change: >> >> In file included from /scratch/tmp/bz/head.svn/sys/sparc64/isa/ofw_isa.c= :78: >> ./pcib_if.h:166: warning: 'enum pci_id_type' declared inside parameter l= ist >> ./pcib_if.h:166: warning: its scope is only this definition or declarati= on, which is probably not what you want >> ./pcib_if.h:169: warning: 'enum pci_id_type' declared inside parameter l= ist >> ./pcib_if.h:169: error: parameter 3 ('type') has incomplete type >> ./pcib_if.h: In function 'PCIB_GET_ID': >> ./pcib_if.h:173: error: type of formal parameter 3 is incomplete > > Clang also fails: > > In file included from /usr/src/sys/dev/acpica/acpi_hpet.c:58: > ./pcib_if.h:165:61: error: declaration of 'enum pci_id_type' will not be > visible outside of this function [-Werror,-Wvisibility] > typedef int pcib_get_id_t(device_t pcib, device_t dev, enum pci_id_type > type, > ^ > ./pcib_if.h:169:38: error: declaration of 'enum pci_id_type' will not be > visible outside of this function [-Werror,-Wvisibility] > enum pci_id_type type, uintptr_t *id) > ^ > ./pcib_if.h:169:50: error: variable has incomplete type 'enum pci_id_type= ' > enum pci_id_type type, uintptr_t *id) > ^ > ./pcib_if.h:169:38: note: forward declaration of 'enum pci_id_type' > enum pci_id_type type, uintptr_t *id) > ^ > 3 errors generated. > > Jung-uk Kim >