From owner-svn-src-all@freebsd.org Thu Dec 8 13:01:20 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 17238C6DDDA; Thu, 8 Dec 2016 13:01:20 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from zxy.spb.ru (zxy.spb.ru [195.70.199.98]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id C7F201028; Thu, 8 Dec 2016 13:01:19 +0000 (UTC) (envelope-from slw@zxy.spb.ru) Received: from slw by zxy.spb.ru with local (Exim 4.86 (FreeBSD)) (envelope-from ) id 1cEyJz-000KLg-2n; Thu, 08 Dec 2016 16:01:11 +0300 Date: Thu, 8 Dec 2016 16:01:11 +0300 From: Slawa Olhovchenkov To: Alan Cox Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r309703 - in head/sys: amd64/amd64 arm64/arm64 i386/i386 vm Message-ID: <20161208130110.GQ57876@zxy.spb.ru> References: <201612080429.uB84TToV048828@repo.freebsd.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <201612080429.uB84TToV048828@repo.freebsd.org> User-Agent: Mutt/1.5.24 (2015-08-30) X-SA-Exim-Connect-IP: X-SA-Exim-Mail-From: slw@zxy.spb.ru X-SA-Exim-Scanned: No (on zxy.spb.ru); SAEximRunCond expanded to false X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 08 Dec 2016 13:01:20 -0000 On Thu, Dec 08, 2016 at 04:29:29AM +0000, Alan Cox wrote: > Author: alc > Date: Thu Dec 8 04:29:29 2016 > New Revision: 309703 > URL: https://svnweb.freebsd.org/changeset/base/309703 > > Log: > Previously, vm_radix_remove() would panic if the radix trie didn't > contain a vm_page_t at the specified index. However, with this > change, vm_radix_remove() no longer panics. Instead, it returns NULL > if there is no vm_page_t at the specified index. Otherwise, it > returns the vm_page_t. The motivation for this change is that it > simplifies the use of radix tries in the amd64, arm64, and i386 pmap > implementations. Instead of performing a lookup before every remove, > the pmap can simply perform the remove. Is this performance improvement?