From owner-cvs-all Fri Mar 22 6:58:32 2002 Delivered-To: cvs-all@freebsd.org Received: from freefall.freebsd.org (freefall.FreeBSD.org [216.136.204.21]) by hub.freebsd.org (Postfix) with ESMTP id A676D37B400; Fri, 22 Mar 2002 06:58:27 -0800 (PST) Received: (from rwatson@localhost) by freefall.freebsd.org (8.11.6/8.11.6) id g2MEwRL89719; Fri, 22 Mar 2002 06:58:27 -0800 (PST) (envelope-from rwatson) Message-Id: <200203221458.g2MEwRL89719@freefall.freebsd.org> From: Robert Watson Date: Fri, 22 Mar 2002 06:58:27 -0800 (PST) To: cvs-committers@FreeBSD.org, cvs-all@FreeBSD.org Subject: cvs commit: src/sys/kern kern_sysctl.c X-FreeBSD-CVS-Branch: HEAD Sender: owner-cvs-all@FreeBSD.ORG Precedence: bulk List-ID: List-Archive: (Web Archive) List-Help: (List Instructions) List-Subscribe: List-Unsubscribe: X-Loop: FreeBSD.ORG rwatson 2002/03/22 06:58:27 PST Modified files: sys/kern kern_sysctl.c Log: In sysctl, req->td is believed always to be non-NULL, so there's no need to test req->td for NULL values and then do somewhat more bizarre things relating to securelevel special-casing and suser checks. Remove the testing and conditional security checks based on req->td!=NULL, and insert a KASSERT that td != NULL. Callers to sysctl must always specify the thread (be it kernel or otherwise) requesting the operation, or a number of current sysctls will fail due to assumptions that the thread exists. Obtained from: TrustedBSD Project Sponsored by: DARPA, NAI Labs Discussed with: bde Revision Changes Path 1.122 +13 -19 src/sys/kern/kern_sysctl.c To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe cvs-all" in the body of the message