Date: Sun, 18 Oct 1998 14:15:07 -0700 From: Don Lewis <Don.Lewis@tsc.tdk.com> To: Nate Williams <nate@mt.sri.com>, Terry Lambert <tlambert@primenet.com> Cc: imp@village.org (Warner Losh), hackers@FreeBSD.ORG Subject: Re: softupdates and/or fsck bugs or features? Message-ID: <199810182115.OAA29673@salsa.gv.tsc.tdk.com> In-Reply-To: Nate Williams <nate@mt.sri.com> "Re: softupdates and/or fsck bugs or features?" (Oct 18, 2:42pm)
next in thread | previous in thread | raw e-mail | index | archive | help
On Oct 18, 2:42pm, Nate Williams wrote: } Subject: Re: softupdates and/or fsck bugs or features? } > > I had a couple of nasty crashes on my machine that has soft updates } > > enabled. It would appear that I've also managed to get some } > > interesting corruption on one of my volumes. } .. } > Update your fsck. } > } > There was a bug in fsck that had it not counting the link in / and } > the links in the /lost+found directory. } > } > I submitted a patch a while back that fixed this bug. } } This patch was committed by me after Don Lewis reviewed the patch, and I } concurred with the analysis made by both of you. } } > Alternately, you have commit priviledges, and this was discussed in } > depth on the -current list a number of weeks ago (and if you are } > running the most recent -current and are still seeing this, then } > no one with commit priviledges acted upon the discussion, though } > I know of at least two people, one of them a core member, who } > participated in the discussion). } } I'm not a core member, but the patch is in the tree: } } revision 1.12 } date: 1998/09/23 05:37:35; author: nate; state: Exp; lines: +1 -3 } - Back out softupdate change that already existed in FreeBSD from V1.6, } which caused the reference count of a directory to get doubly } decremented. I don't think this is the bug since the reference counts are too big. Question for Warner, do you see any complaints from fsck about extraneous hard links to directories? After fsck has run, I've seen another fsck run complain that /lost+found/#whatever is an extraneous hard link to a directory. I've found some other bugs in fsck, though I'm not convinced that they were behind similar problems I was seeing. I've attempted to fix them in the patch I included in bin/8055. Kirk McKusick incorporated this patch with some changes into his version of fsck, which he intends to integrate into the FreeBSD version at some point. In the meantime, I'd recommend running fsck until it stops reconnecting stuff under lost+found. Then run it again without the -p option (so that it ignores the clean flag), which will allow it to fix the reference counts. --- Truck To Unsubscribe: send mail to majordomo@FreeBSD.org with "unsubscribe freebsd-hackers" in the body of the message
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?199810182115.OAA29673>