From owner-svn-src-all@FreeBSD.ORG Sat Jan 21 00:05:28 2012 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id A13D7106567A; Sat, 21 Jan 2012 00:05:28 +0000 (UTC) (envelope-from lists@eitanadler.com) Received: from mail-lpp01m010-f54.google.com (mail-lpp01m010-f54.google.com [209.85.215.54]) by mx1.freebsd.org (Postfix) with ESMTP id 7FE448FC12; Sat, 21 Jan 2012 00:05:27 +0000 (UTC) Received: by lahe6 with SMTP id e6so853216lah.13 for ; Fri, 20 Jan 2012 16:05:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=eitanadler.com; s=0xdeadbeef; h=mime-version:sender:in-reply-to:references:from:date :x-google-sender-auth:message-id:subject:to:cc:content-type :content-transfer-encoding; bh=2KW1KBts5o+cB2pjjgEJBBu+02s3yY/7V9dCEdKrNKg=; b=LcdbjxzQaJwe4YGk9AkCYCvQsuQK/z8gnQIqKdgZIa+tu8nDow3CqgJfMXR7+LU3Tf Wmxx3MqzvXoG+ACZPVMHrObRNZlqEES1iayz0c8W13FhkjUzs8jSLTZKCgjf+B/exqOH nBt44cGowTxXPB1E6maMmG5sGRa1gqqGSOnqg= Received: by 10.112.87.169 with SMTP id az9mr8092554lbb.63.1327104326133; Fri, 20 Jan 2012 16:05:26 -0800 (PST) MIME-Version: 1.0 Sender: lists@eitanadler.com Received: by 10.112.25.196 with HTTP; Fri, 20 Jan 2012 16:04:55 -0800 (PST) In-Reply-To: <20120120.123256.1432718473132856309.hrs@allbsd.org> References: <201201200138.q0K1cSou016739@svn.freebsd.org> <20120120.123256.1432718473132856309.hrs@allbsd.org> From: Eitan Adler Date: Fri, 20 Jan 2012 19:04:55 -0500 X-Google-Sender-Auth: LN8E5x0-kZ3hJiwwmCzyfLMKJZE Message-ID: To: Hiroki Sato Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r230354 - head/usr.sbin/makefs X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 21 Jan 2012 00:05:28 -0000 On Thu, Jan 19, 2012 at 10:32 PM, Hiroki Sato wrote: > Eitan Adler wrote > =C2=A0in <201201200138.q0K1cSou016739@svn.freebsd.org>: > > ea> Author: eadler > ea> Date: Fri Jan 20 01:38:28 2012 > ea> New Revision: 230354 > ea> URL: http://svn.freebsd.org/changeset/base/230354 > ea> > ea> Log: > ea> =C2=A0 Fix a variety of warnings when compiling with gcc46 > ea> > ea> =C2=A0 Approved by: =C2=A0 =C2=A0 =C2=A0dim, cperciva (mentor, blanke= t for pre-mentorship already-approved commits) > ea> =C2=A0 MFC after: =C2=A0 =C2=A0 =C2=A0 =C2=A03 days > ea> > ea> Modified: > ea> =C2=A0 head/usr.sbin/makefs/cd9660.c > > =C2=A0Removing the dot handling part and leaving a comment in lines > =C2=A01106-1117 make people confused. I missed that - sorry. > =C2=A0In addition to that, I personally don't think this should be remove= d > =C2=A0because our cd9660.c is still based on NetBSD's one in any > =C2=A0way---bugfixes on our side have been reported to the upstream and w= e > =C2=A0will import useful changes from there if any. =C2=A0Although the cu= rrent > =C2=A0dot handling is useless, keeping the difference between the two sma= ll > =C2=A0still has a meaning. I was was unaware this code was contributed. I just looked at the NetBSD version and I don't think it suffers from the same problem - the loop appears to be used later. If that is because of some other bug fix which could be upstreamed that would be great. On the other hand I would like to continue with my goal of making the non-contrib world compilable with CC=3Dgcc46. Should I revert this commit? --=20 Eitan Adler Ports committer X11, Bugbusting teams