From owner-freebsd-net@FreeBSD.ORG Sun Nov 15 05:37:07 2009 Return-Path: Delivered-To: freebsd-net@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 5D55C106566B; Sun, 15 Nov 2009 05:37:07 +0000 (UTC) (envelope-from CQG00620@nifty.ne.jp) Received: from mail1.asahi-net.or.jp (mail1.asahi-net.or.jp [202.224.39.197]) by mx1.freebsd.org (Postfix) with ESMTP id 324FC8FC14; Sun, 15 Nov 2009 05:37:07 +0000 (UTC) Received: from asahi-net.jp (b151149.dynamic.ppp.asahi-net.or.jp [202.213.151.149]) by mail1.asahi-net.or.jp (Postfix) with ESMTP id 8D4C892950; Sun, 15 Nov 2009 14:17:58 +0900 (JST) Date: Sun, 15 Nov 2009 14:17:57 +0900 From: WATANABE Kazuhiro To: John Baldwin In-Reply-To: <200911061508.22482.jhb@freebsd.org> References: <200911061508.22482.jhb@freebsd.org> User-Agent: Wanderlust/2.14.0 (Africa) SEMI/1.14.6 (Maruoka) FLIM/1.14.8 (=?ISO-8859-4?Q?Shij=F2?=) APEL/10.7 Emacs/21.3 (i386--freebsd) MULE/5.0 (SAKAKI) MIME-Version: 1.0 (generated by SEMI 1.14.6 - "Maruoka") Content-Type: text/plain; charset=US-ASCII Message-Id: <20091115051758.8D4C892950@mail1.asahi-net.or.jp> Cc: freebsd-net@freebsd.org, freebsd-current Subject: Re: [PATCH] Remove if_watchdog use X-BeenThere: freebsd-net@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Networking and TCP/IP with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sun, 15 Nov 2009 05:37:07 -0000 Hi, I've tested the following NICs with your patch on CURRENT, and they works fine. Thanks! * Corega FastEther PCI-TX (DEC 21140-AF) de0: port 0xe000-0xe07f mem 0xd9001000-0xd900107f irq 12 at device 15.0 on pci0 de0: 21140A [10-100Mb/s] pass 2.2 de0: Ethernet address: 00:00:f4:xx:xx:xx de0: [ITHREAD] * Acer ALN-201C (Realtek RTL8029AS) ed0: port 0xe000-0xe01f irq 12 at device 15.0 on pci0 ed0: Ethernet address: 00:60:67:xx:xx:xx ed0: [ITHREAD] At Fri, 6 Nov 2009 15:08:22 -0500, John Baldwin wrote: > I have a patchset that converts all the remaining users of if_watchdog to > using a private callout instead. In some cases the the driver already used a > private timer to drive a stats timer and I merely hooked into that timer. In > other cases a new callout needed to be added to the driver. Some drivers > even abused the if_watchdog interface to provide a stats timer that fired > every second. :) For a few drivers I also fixed other things such as busted > locking, order-of-operations issues in detach, or just completely busted > drivers (fea(4) and fpa(4) which share the pdq backend). Please test. > Barring any major screaming and shouting I plan to commit this in a week or > so and after that to work on removing the if_watchdog/if_timer stuff from the > network stack. > > The patch is at http://www.FreeBSD.org/~jhb/patches/cleanup.patch (snip) --- WATANABE Kazuhiro (CQG00620@nifty.ne.jp)