Date: Tue, 14 Feb 2023 05:03:18 GMT From: Alexey Dokuchaev <danfe@FreeBSD.org> To: ports-committers@FreeBSD.org, dev-commits-ports-all@FreeBSD.org, dev-commits-ports-main@FreeBSD.org Subject: git: 802bc74a375f - main - games/quake2max: specify return type of Mod_GetTris() function correctly Message-ID: <202302140503.31E53IoO043860@gitrepo.freebsd.org>
next in thread | raw e-mail | index | archive | help
The branch main has been updated by danfe: URL: https://cgit.FreeBSD.org/ports/commit/?id=802bc74a375fa5ce814626d572af7467fc914bc8 commit 802bc74a375fa5ce814626d572af7467fc914bc8 Author: Alexey Dokuchaev <danfe@FreeBSD.org> AuthorDate: 2023-02-14 04:58:06 +0000 Commit: Alexey Dokuchaev <danfe@FreeBSD.org> CommitDate: 2023-02-14 04:58:06 +0000 games/quake2max: specify return type of Mod_GetTris() function correctly It iterates over a counter (local variable) and returns its value, not the address. While here, staticize it as it is not called elsewhere. Reported by: pkg-fallout (clang 15) --- games/quake2max/files/patch-ref_gl__gl_model.c | 9 +++++++++ 1 file changed, 9 insertions(+) diff --git a/games/quake2max/files/patch-ref_gl__gl_model.c b/games/quake2max/files/patch-ref_gl__gl_model.c index e5c270853f20..9d2fd4530009 100644 --- a/games/quake2max/files/patch-ref_gl__gl_model.c +++ b/games/quake2max/files/patch-ref_gl__gl_model.c @@ -27,3 +27,12 @@ if (mod->script[i]) RS_ReadyScript((rscript_t *)mod->script[i]); } +@@ -1465,7 +1465,7 @@ + } + + +-signed int *Mod_GetTris(short p1, short p2, dtriangle_t *side1, dmdl_t *hdr) ++static signed int Mod_GetTris(short p1, short p2, dtriangle_t *side1, dmdl_t *hdr) + { + dtriangle_t *tris = (dtriangle_t *)((unsigned char*)hdr + hdr->ofs_tris); + int i;
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?202302140503.31E53IoO043860>