From owner-freebsd-ports@freebsd.org Wed Mar 22 16:57:43 2017 Return-Path: Delivered-To: freebsd-ports@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5073CD17F72 for ; Wed, 22 Mar 2017 16:57:43 +0000 (UTC) (envelope-from jev@ecadlabs.com) Received: from mail-qk0-x235.google.com (mail-qk0-x235.google.com [IPv6:2607:f8b0:400d:c09::235]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 12CC215C8 for ; Wed, 22 Mar 2017 16:57:43 +0000 (UTC) (envelope-from jev@ecadlabs.com) Received: by mail-qk0-x235.google.com with SMTP id y76so161373913qkb.0 for ; Wed, 22 Mar 2017 09:57:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ecadlabs.com; s=google; h=mime-version:from:date:message-id:subject:to; bh=laJT/Q3CgRAOu+I++ArpB86OjEhKLvzMORSDbzFkonA=; b=kKPewtQRiUjRioNW3KiNV3/0Mu2CHuyInW5/UZuzXzhLyLZJBi2AHALMOHWdpcNhk3 yRc6CwewJFH+HM/oeAKCcfjsQkn1VFKag2MSKAhDetDt/zq1I5VXp6ohha0wwbOOhLVg RSEP/9tbZ3+Nd1jGbbA2LU8lcbf9SIxDq7YXT7VeqJrYgOKAA3p/jjg3wiqUug6BQJ1C QOMT5ydAoi/VxZQoxJ5E2VEB0fFYEhFCYclKsZ/RrZE5/D/uVdgQ1Hq6Wc+Xn5TzSTnr yLMvaVOkAlYtwLzb+ozmWpRWsf+iEt2DB8yQCkh2clhbz9rBXFJNcbI81aDMoZZjqPLf XYjw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:from:date:message-id:subject:to; bh=laJT/Q3CgRAOu+I++ArpB86OjEhKLvzMORSDbzFkonA=; b=NT+eEy+Eik0VjJrZs3UYe33ir3o2LfhEK3/Jk7+yop8lMvv7LItFH5zwqZ0Ifq8wfF 9CMKy9EYiQkeN8whjy6LmsE7/VdKp1+fxjYP8tCgw6rKOefFXRD4c4bUzKHIc5Wfd9Sv 70409Jjc1ynm6rYraE6O8ggt3zFCX7ab/Wij7vd1G7199s74JCIg8BAW61br1Z1QecFE 20gSrpH8Jg6B+5RR9ZaVuDGuLLjMLHxsL/sQRi7l1+i+btRX/7UgoA6s+TM2vANSG21K J70GyDgmhybbT+xvOQKwFue0cKtN7sotdvGxrT8Gcx3TelbTxTBXlm2yDgHqBbSCRxqD PhhA== X-Gm-Message-State: AFeK/H0U/Y0qKg7ig+X3pxebHMDXnlB31mCDeOxoDkZpN9IrP27zsoE7ZqytSMRu8oRhJRKeO2McI72FZvSPQNZX X-Received: by 10.55.43.23 with SMTP id r23mr8982965qkh.147.1490201861824; Wed, 22 Mar 2017 09:57:41 -0700 (PDT) MIME-Version: 1.0 From: =?UTF-8?Q?Jev_Bj=C3=B6rsell?= Date: Wed, 22 Mar 2017 16:57:31 +0000 Message-ID: Subject: question about use of != assignments To: "freebsd-ports@freebsd.org" Content-Type: multipart/mixed; boundary=001a11493f9a9e569f054b54a861 X-Content-Filtered-By: Mailman/MimeDel 2.1.23 X-BeenThere: freebsd-ports@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: Porting software to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 22 Mar 2017 16:57:43 -0000 --001a11493f9a9e569f054b54a861 Content-Type: text/plain; charset=UTF-8 Hello, I'm updating net-mgmt/prometheus for which I am the maintainer. During build, I have added some ldflags for the `go build` step, so that build time, version, etc. is recorded in the binary. Before this change running `prometheus -version` gives a bunch of blank values, my attached patch fixes that. I'm using != assignments in my Makefile to get date, user, and host. portlint warns me[0] not to use != assignments, and the linked post suggests to use echo $$(${VARIABLE_CMDS}) instead. If I inline $$(${VARIABLE_CMDS}) into by build targets, without echo, they do not get evaluated. The question; is my use of != in this context acceptable use, or is there a better way? Much thanks, -Jev [0]: portlint warning WARN: Makefile: [25]: use of != in assignments is almost never a good thing to do. Try to avoid using them. See http://lists.freebsd.org/pipermail/freebsd-ports/2008-July/049777.html for some helpful hints on what to do instead. --001a11493f9a9e569f054b54a861 Content-Type: text/x-patch; charset=US-ASCII; name="prometheus-1.5.2.diff" Content-Disposition: attachment; filename="prometheus-1.5.2.diff" Content-Transfer-Encoding: base64 Content-ID: <15af6f2b08a92ff29fa1> X-Attachment-Id: 15af6f2b08a92ff29fa1 SW5kZXg6IE1ha2VmaWxlCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIE1ha2VmaWxlCShyZXZpc2lvbiA0MzM2NTcp CisrKyBNYWtlZmlsZQkod29ya2luZyBjb3B5KQpAQCAtMiw3ICsyLDcgQEAKICMgJEZyZWVCU0Qk CiAKIFBPUlROQU1FPQlwcm9tZXRoZXVzCi1QT1JUVkVSU0lPTj0JMS41LjAKK1BPUlRWRVJTSU9O PQkxLjUuMgogRElTVFZFUlNJT05QUkVGSVg9CXYKIENBVEVHT1JJRVM9CW5ldC1tZ210CiAKSW5k ZXg6IGRpc3RpbmZvCj09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PT09PT0KLS0tIGRpc3RpbmZvCShyZXZpc2lvbiA0MzM2NTcpCisr KyBkaXN0aW5mbwkod29ya2luZyBjb3B5KQpAQCAtMSwzICsxLDMgQEAKLVRJTUVTVEFNUCA9IDE0 ODUxNjAzNTcKLVNIQTI1NiAocHJvbWV0aGV1cy1wcm9tZXRoZXVzLXYxLjUuMF9HSDAudGFyLmd6 KSA9IGY4ZWFlNWY0YzUxZmRkNzNjZWVjMDhmYzQ4OTVlNjk1YjZiMDJiNTgxYWE5NWU3NDJlMGY0 OGY1YWVmYzU1MzcKLVNJWkUgKHByb21ldGhldXMtcHJvbWV0aGV1cy12MS41LjBfR0gwLnRhci5n eikgPSA1MTgyODMwCitUSU1FU1RBTVAgPSAxNDg2NzE5MjEwCitTSEEyNTYgKHByb21ldGhldXMt cHJvbWV0aGV1cy12MS41LjJfR0gwLnRhci5neikgPSBjNDg4MWNjMzA1MjYzY2M4ZGE0MzRiZTY5 YTIwYWEwMzkzODZkNGZlYWI1ZTU4ZjhiODlhNjBiZmU4YjU1NmFjCitTSVpFIChwcm9tZXRoZXVz LXByb21ldGhldXMtdjEuNS4yX0dIMC50YXIuZ3opID0gNTE4MzUzNwo= --001a11493f9a9e569f054b54a861--