From owner-svn-src-head@freebsd.org Thu Apr 21 17:19:03 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7EA30B175A0; Thu, 21 Apr 2016 17:19:03 +0000 (UTC) (envelope-from hps@selasky.org) Received: from mail.turbocat.net (heidi.turbocat.net [88.198.202.214]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id 4618A103D; Thu, 21 Apr 2016 17:19:02 +0000 (UTC) (envelope-from hps@selasky.org) Received: from laptop015.home.selasky.org (unknown [62.141.129.119]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.turbocat.net (Postfix) with ESMTPSA id 84A981FE024; Thu, 21 Apr 2016 19:18:59 +0200 (CEST) Subject: Re: svn commit: r298412 - head/sys/ofed/drivers/infiniband/core To: Ngie Cooper References: <201604211604.u3LG4wmT035874@repo.freebsd.org> Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" From: Hans Petter Selasky Message-ID: <57190C47.8070106@selasky.org> Date: Thu, 21 Apr 2016 19:22:15 +0200 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.5.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2016 17:19:03 -0000 On 04/21/16 19:12, Ngie Cooper wrote: > Please put the "deadcode" back. It will crash now if it's given an > invalid address family (or none are configured in the kernel) when it > tries to do the memcpy below. If you look a few lines up in the file, not the patch, you'll see that there already is a switch case which catches this. OK? --HPS