From owner-freebsd-mobile@FreeBSD.ORG Thu Jan 20 22:13:40 2005 Return-Path: Delivered-To: freebsd-mobile@freebsd.org Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125]) by hub.freebsd.org (Postfix) with ESMTP id 500B616A4CE for ; Thu, 20 Jan 2005 22:13:40 +0000 (GMT) Received: from relay02.pair.com (relay02.pair.com [209.68.5.16]) by mx1.FreeBSD.org (Postfix) with SMTP id 646D443D5E for ; Thu, 20 Jan 2005 22:13:37 +0000 (GMT) (envelope-from dwalton@acm.org) Received: (qmail 89644 invoked from network); 20 Jan 2005 22:13:36 -0000 Received: from unknown (HELO ?172.16.1.34?) (unknown) by unknown with SMTP; 20 Jan 2005 22:13:36 -0000 X-pair-Authenticated: 68.127.18.161 Message-ID: <41F02CE1.5090207@acm.org> Date: Thu, 20 Jan 2005 14:12:49 -0800 From: Dave Walton User-Agent: Mozilla Thunderbird 1.0 (X11/20041208) X-Accept-Language: en-us, en MIME-Version: 1.0 To: Andrew Belashov References: <41EF6101.7010008@acm.org> <41EF6C84.5050608@orel.ru> In-Reply-To: <41EF6C84.5050608@orel.ru> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit cc: freebsd-mobile@freebsd.org Subject: Re: Trouble with APM suspend in 5.3-R X-BeenThere: freebsd-mobile@freebsd.org X-Mailman-Version: 2.1.1 Precedence: list Reply-To: dwalton@acm.org List-Id: Mobile computing with FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 20 Jan 2005 22:13:40 -0000 Andrew Belashov wrote: > Dave Walton wrote: > >> I've been unable to get APM suspend/resume to work with 5.3-R on my >> Thinkpad 770Z. As released, 'apm -z' causes a lockup (it worked fine >> in 4.x). Revision 1.233 of ata-all.c fixes that, and 'apm -z' now >> causes the system to properly suspend to disk, as it had before. >> However, when the system resumes, it spits out three errors regarding >> pir0, then panics. This happens with or without your patch applied to >> ata-all.c. >> > > Try attached patch as workaround. A good effort! That is precisely the error I saw. Hopefully, that removed call to pci_pir_biosroute() doesn't do anything important. Unfortunately, this had no effect at all on the panic. Please see my next reply to Gleb Smirnoff for details on the panic. Perhaps it will mean something to you. Thanks, Dave > ------------------------------------------------------------------------ > > --- sys/i386/pci/pci_pir.c.orig Fri Jul 30 19:51:30 2004 > +++ sys/i386/pci/pci_pir.c Sun Nov 14 21:47:33 2004 > @@ -717,8 +717,12 @@ pir_resume(device_t dev) > "Using %d.%d.INT%c to route link %#x to IRQ %d\n", > pd.bus, pd.device, pd.pin + 'A', > pci_link->pl_id, pci_link->pl_irq); > +#if 0 > error = pci_pir_biosroute(pd.bus, pd.device, 0, pd.pin, > pci_link->pl_irq); > +#else > + error = 0; > +#endif > if (error) > device_printf(dev, > "ROUTE_INTERRUPT on resume for link %#x failed.\n",