From owner-cvs-usrsbin  Sat Apr 15 18:05:33 1995
Return-Path: cvs-usrsbin-owner
Received: (from majordom@localhost)
          by freefall.cdrom.com (8.6.10/8.6.6) id SAA10723
          for cvs-usrsbin-outgoing; Sat, 15 Apr 1995 18:05:33 -0700
Received: from precipice.shockwave.com (precipice.shockwave.com [171.69.108.33])
          by freefall.cdrom.com (8.6.10/8.6.6) with ESMTP id SAA10695
          ; Sat, 15 Apr 1995 18:05:10 -0700
Received: from localhost (localhost [127.0.0.1]) by precipice.shockwave.com (8.6.11/8.6.9) with SMTP id RAA02447; Sat, 15 Apr 1995 17:57:05 -0700
Message-Id: <199504160057.RAA02447@precipice.shockwave.com>
To: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
cc: bde@zeta.org.au (Bruce Evans), CVS-commiters@freefall.cdrom.com,
        bde@freefall.cdrom.com, cvs-usrsbin@freefall.cdrom.com
Subject: Re: cvs commit: src/usr.sbin/bad144 bad144.c 
In-reply-to: Your message of "Sat, 15 Apr 1995 16:35:54 PDT."
             <199504152335.QAA05684@gndrsh.aac.dev.com> 
Date: Sat, 15 Apr 1995 17:57:05 -0700
From: Paul Traina <pst@shockwave.com>
Sender: cvs-usrsbin-owner@freebsd.org
Precedence: bulk

We originally put it in because twits had the habbit of doing:

CSCdi12398438: this is a bug fix for
	       killing ants

instead of:

CSCdi12394848: this is a bug fix for
killing ants

which made our log files look ugly.

  From: "Rodney W. Grimes" <rgrimes@gndrsh.aac.dev.com>
  Subject: Re: cvs commit: src/usr.sbin/bad144 bad144.c
  > 
  > >  - Avoid overflow in calculation of lseek() offsets.
  > >  - Fix format args in strings some more.  %ld and %lu were often reversed
>> and
  > >  #ifdefed out strings weren't fixed.
  > >  - Don't hard code the raw partition letter or DKBAD*.
  > 
  > Why does cvs strip leading whitspace in log messages?  The `#ifdefed' line
  > is supposed to be indented.
  
  Becuase who ever wrote log_accum.pl thought that is what it should do:
  #   
  # Iterate over the body of the message collecting information.
  #   
  while (<STDIN>) {
      chop;                       # Drop the newline
      if (/^Modified Files/) { $state = $STATE_CHANGED; next; }
      if (/^Added Files/)    { $state = $STATE_ADDED;   next; }
      if (/^Removed Files/)  { $state = $STATE_REMOVED; next; }
      if (/^Log Message/)    { $state = $STATE_LOG;     next; }
      s/^[ \t\n]+//;              # delete leading space
      s/[ \t\n]+$//;              # delete trailing space
  
      push (@changed_files, split) if ($state == $STATE_CHANGED);
      push (@added_files,   split) if ($state == $STATE_ADDED);
      push (@removed_files, split) if ($state == $STATE_REMOVED);
      push (@log_lines,     $_)    if ($state == $STATE_LOG);
  }
  
  I need a concenses on this, but I am willing to delete the line
  that removes the leading space, it has annoyed me on several occasions.
  
  
  -- 
  Rod Grimes                                      rgrimes@gndrsh.aac.dev.com
  Accurate Automation Company                   Custom computers for FreeBSD