From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu Aug 21 18:13:36 2014
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
Delivered-To: freebsd-ports-bugs@FreeBSD.org
Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115])
 (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits))
 (No client certificate requested)
 by hub.freebsd.org (Postfix) with ESMTPS id 7DCBB672
 for <freebsd-ports-bugs@FreeBSD.org>; Thu, 21 Aug 2014 18:13:36 +0000 (UTC)
Received: from kenobi.freebsd.org (kenobi.freebsd.org
 [IPv6:2001:1900:2254:206a::16:76])
 (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits))
 (Client did not present a certificate)
 by mx1.freebsd.org (Postfix) with ESMTPS id 64EF73580
 for <freebsd-ports-bugs@FreeBSD.org>; Thu, 21 Aug 2014 18:13:36 +0000 (UTC)
Received: from bugs.freebsd.org ([127.0.1.118])
 by kenobi.freebsd.org (8.14.9/8.14.9) with ESMTP id s7LIDaaR007723
 for <freebsd-ports-bugs@FreeBSD.org>; Thu, 21 Aug 2014 18:13:36 GMT
 (envelope-from bugzilla-noreply@freebsd.org)
From: bugzilla-noreply@freebsd.org
To: freebsd-ports-bugs@FreeBSD.org
Subject: [Bug 192878] comms/pr [maintainer] new source location
Date: Thu, 21 Aug 2014 18:13:36 +0000
X-Bugzilla-Reason: AssignedTo
X-Bugzilla-Type: changed
X-Bugzilla-Watch-Reason: None
X-Bugzilla-Product: Ports Tree
X-Bugzilla-Component: Individual Port(s)
X-Bugzilla-Version: Latest
X-Bugzilla-Keywords: 
X-Bugzilla-Severity: Affects Many People
X-Bugzilla-Who: marino@FreeBSD.org
X-Bugzilla-Status: Open
X-Bugzilla-Priority: ---
X-Bugzilla-Assigned-To: freebsd-ports-bugs@FreeBSD.org
X-Bugzilla-Target-Milestone: ---
X-Bugzilla-Flags: 
X-Bugzilla-Changed-Fields: 
Message-ID: <bug-192878-13-nvwzCP5Erj@https.bugs.freebsd.org/bugzilla/>
In-Reply-To: <bug-192878-13@https.bugs.freebsd.org/bugzilla/>
References: <bug-192878-13@https.bugs.freebsd.org/bugzilla/>
Content-Type: text/plain; charset="UTF-8"
Content-Transfer-Encoding: 7bit
X-Bugzilla-URL: https://bugs.freebsd.org/bugzilla/
Auto-Submitted: auto-generated
MIME-Version: 1.0
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.18-1
Precedence: list
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/options/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs/>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
 <mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 21 Aug 2014 18:13:36 -0000

https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=192878

--- Comment #4 from John Marino <marino@FreeBSD.org> ---
In my 10-second review, I only spotted one set of things I'd change (besides
the USES= not be 2-tabbed)

+do-install:
+.for P in ${PROGRAMS}
+    ${CP} ${WRKSRC}/sbin/$P ${STAGEDIR}${PREFIX}/sbin
+.endfor
+.for C in ${ETCFILES} 
+    ${CP} ${WRKSRC}/etc/$C ${STAGEDIR}${PREFIX}/etc
+.endfor
+.for R in ${RCDFILES}
+    ${CP} ${WRKSRC}/etc/rc.d/$R ${STAGEDIR}${PREFIX}/etc/rc.d
+.endfor
+
+.for D in ${DOCFILES}
+    @${MKDIR} ${STAGEDIR}${DOCSDIR}
+    ${INSTALL_DATA} ${WRKSRC}/share/doc/pr/$D ${STAGEDIR}${DOCSDIR}
+.endfor


problem 1) You use $CP instead of $INSTALL_ macros

problen 2) See the top 3 loops?  
The don't need to exist at all.  For example, the first one should be:
(cd ${WRKSRC}/sbin && ${INSTALL_PROGRAM} ${PROGRAMS} ${STAGEDIR}${PREFIX}

problem 3)
you create the DOCSDIR directory once per file.  It's inside the loop!!
and you don't need a loop either (see problem 2)
You need to check ${PORT_OPTIONS:MDOC}


also, portlint did not complain about ${CP}?  or you didn't run portlint?

-- 
You are receiving this mail because:
You are the assignee for the bug.