From owner-svn-src-all@freebsd.org Fri Mar 4 22:11:50 2016 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 2CCCFA09B2E for ; Fri, 4 Mar 2016 22:11:50 +0000 (UTC) (envelope-from pfg@FreeBSD.org) Received: from nm4.bullet.mail.bf1.yahoo.com (nm4.bullet.mail.bf1.yahoo.com [98.139.212.163]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client did not present a certificate) by mx1.freebsd.org (Postfix) with ESMTPS id DB84CE0E for ; Fri, 4 Mar 2016 22:11:49 +0000 (UTC) (envelope-from pfg@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=yahoo.com; s=s2048; t=1457129508; bh=D8CehB0DyT5QaiVYkgmBTfievU5lCzUCINpPxTd68NY=; h=Subject:To:References:From:Date:In-Reply-To:From:Subject; b=KbNmWoILssdHfaCVMz/NRLIXG5WD8CtmXWFeiOTzBjnMuT5Y4bH2sEUYViLW0i4icBwHQbiv0v7SMg0WInAR6XAhELPlnvA75XKjbWfq42n9/zAtVCvRo8hT51cVrPYcaRz+3ZqDEhHsqhDiQEm88UzCOybOsMBIzDrLT7rvbRZ32Bohn7zOseGcfYk4XkLEe6xBayBdjYk5rrEbCtH+5LW99OUDfNJ0AsMlRPwnCm7ODnghZq2N3e/qQOqdDsrltqj/jBdaBcv7haSVy0eKizsq17323QFWAwN/M5FFPK7cSXDsiLBQaMECQIRbJDm18WRIpG220Kw55kU7gPaWKg== Received: from [98.139.215.143] by nm4.bullet.mail.bf1.yahoo.com with NNFMP; 04 Mar 2016 22:11:48 -0000 Received: from [98.139.211.199] by tm14.bullet.mail.bf1.yahoo.com with NNFMP; 04 Mar 2016 22:11:48 -0000 Received: from [127.0.0.1] by smtp208.mail.bf1.yahoo.com with NNFMP; 04 Mar 2016 22:11:48 -0000 X-Yahoo-Newman-Id: 10926.97935.bm@smtp208.mail.bf1.yahoo.com X-Yahoo-Newman-Property: ymail-3 X-YMail-OSG: UWyaD9kVM1lHx0MvgELcwjAUS3fIMF4d.l51BLyBBeG41iM Y3YgBkcG_.M0ZGFy81b.Xzb.nfDpNtfxUABufkhcnNlGz7eXRcG7t.npDe3L XpyQ1KE8nFnD2eoqGtWYHmR0wqDyyEYAjYJYev9IlQvIN4M9yYQ8zX00oEYc XJcMCuZ0EKplcRXgfZITHP8AtbVhDtEWYsFi5ou8AN1ttWFddvf31ZpZcYXV 2JdnRFAET4hh8yo8N.0CcAYMQQbmBlZKb4kv2CF9sZft0GObSoIXjXxBgo3j fIXCozNvCIQyLnwx37h1rNrOSUU6YnxRr6ujvIckjwf.61psxyX4z2EaSoLj si5JL4o3Dxfu0BQ5igor4hugY2D1Rqn9v2kXoeZ8XPOm.ggsagtui96qkG8. OOqh7FgXWkCICmzSyziws1ygEKdPN0mRSy2XkrrvjzEpAyjCPXRaRNEhlQMS Qi_TZgb2sSJBcO9mD5WQHf76.RUqEgN4agcmsXb4EELHhHi0Rpm2jdBnLETP OYt0ollaWmghmYAbkAklUnW5yWA4IsfX1 X-Yahoo-SMTP: xcjD0guswBAZaPPIbxpWwLcp9Unf Subject: Re: svn commit: r296394 - head/include/rpc To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org References: <201603042203.u24M3c7t043681@repo.freebsd.org> From: Pedro Giffuni Message-ID: <56DA0854.3020708@FreeBSD.org> Date: Fri, 4 Mar 2016 17:12:36 -0500 User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:38.0) Gecko/20100101 Thunderbird/38.6.0 MIME-Version: 1.0 In-Reply-To: <201603042203.u24M3c7t043681@repo.freebsd.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 04 Mar 2016 22:11:50 -0000 On 03/04/16 17:03, Pedro F. Giffuni wrote: > Author: pfg > Date: Fri Mar 4 22:03:38 2016 > New Revision: 296394 > URL: https://svnweb.freebsd.org/changeset/base/296394 > > Log: > xdr: Fix xdr_rpc* defines. > > The defines for xdr_rpc* in xdr.h are wrong. It could be > very well that Solaris did strip the '_t' from xdr_u_int32_t, > but Solaris has a xdr_u_int32 function, we don't have this. > So all of this defines will lead to an unresolved symbol. > > This explains why we do not use these functions in FreeBSD > while they are used in Illumos/Solaris. > > Obtained from: linux libtirpc (git 7864122e61ffe4db1aa8ace89117358a1e3a391b) > MFC after: 3 weeks > > Modified: > head/include/rpc/xdr.h > > Modified: head/include/rpc/xdr.h > ============================================================================== > --- head/include/rpc/xdr.h Fri Mar 4 21:22:11 2016 (r296393) > +++ head/include/rpc/xdr.h Fri Mar 4 22:03:38 2016 (r296394) > @@ -219,15 +219,11 @@ xdr_putint32(XDR *xdrs, int32_t *ip) > (*(xdrs)->x_ops->x_control)(xdrs, req, op) > #define xdr_control(xdrs, req, op) XDR_CONTROL(xdrs, req, op) > > -/* > - * Solaris strips the '_t' from these types -- not sure why. > - * But, let's be compatible. > - */ > -#define xdr_rpcvers(xdrs, versp) xdr_u_int32(xdrs, versp) > -#define xdr_rpcprog(xdrs, progp) xdr_u_int32(xdrs, progp) > -#define xdr_rpcproc(xdrs, procp) xdr_u_int32(xdrs, procp) > -#define xdr_rpcprot(xdrs, protp) xdr_u_int32(xdrs, protp) > -#define xdr_rpcport(xdrs, portp) xdr_u_int32(xdrs, portp) > +#define xdr_rpcvers(xdrs, versp) xdr_u_int32_t(xdrs, versp) > +#define xdr_rpcprog(xdrs, progp) xdr_u_int32_t(xdrs, progp) > +#define xdr_rpcproc(xdrs, procp) xdr_u_int32_t(xdrs, procp) > +#define xdr_rpcprot(xdrs, protp) xdr_u_int32_t(xdrs, protp) > +#define xdr_rpcport(xdrs, portp) xdr_u_int32_t(xdrs, portp) > > /* > * Support struct for discriminated unions. > For the record, it's still wrong for 64 bit platforms: we should probably add an ifdef there. Pedro. Pedro.