Date: Sat, 02 Feb 2019 18:36:42 +0000 From: bugzilla-noreply@freebsd.org To: ports-bugs@FreeBSD.org Subject: [Bug 232789] new port: net-p2p/aeon: a private, secure, untraceable, decentralised digital currency Message-ID: <bug-232789-7788-NHmhoZEsrr@https.bugs.freebsd.org/bugzilla/> In-Reply-To: <bug-232789-7788@https.bugs.freebsd.org/bugzilla/> References: <bug-232789-7788@https.bugs.freebsd.org/bugzilla/>
next in thread | previous in thread | raw e-mail | index | archive | help
https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=3D232789 Tobias Kortkamp <tobik@freebsd.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |needs-patch, needs-qa Status|New |Open --- Comment #3 from Tobias Kortkamp <tobik@freebsd.org> --- Hi, a couple of comments below that would need to be addressed if this is to go into the tree. - Can you please format *_DEPENDS properly? Look at any other port for what this should look like. - Directly depending on security/openssl is wrong. Please use USES=3Dssl. - Directly depending on devel/pkgconf is wrong. It's already added via USES=3Dpkgconfig anyway. - Having doxygen in BUILD_DEPENDS is problematic as it pulls in large dependencies. It would be better if this could be optional via a DOXYGEN option. What is doxygen used for here? Any way to disable it? - USES=3Dninja can be dropped. It's the default for USES=3Dcmake now. - Drop GH_PROJECT. It's set to ${PORTNAME} by default. - Instead of GH_TAGNAME=3Dv0.12.2.1, just set DISTVERSIONPREFIX=3Dv - What does portlint -AC say? - What QA did you do? Any build tests in Poudriere or with another tool? Or a build with DEVELOPER=3Dyes in /etc/make.conf? --=20 You are receiving this mail because: You are the assignee for the bug.=
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?bug-232789-7788-NHmhoZEsrr>