From owner-svn-src-all@FreeBSD.ORG Fri Feb 6 01:58:27 2015 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 873D34C5; Fri, 6 Feb 2015 01:58:27 +0000 (UTC) Received: from mail-pd0-f176.google.com (mail-pd0-f176.google.com [209.85.192.176]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 5914AE1A; Fri, 6 Feb 2015 01:58:26 +0000 (UTC) Received: by pdbfl12 with SMTP id fl12so11414481pdb.6; Thu, 05 Feb 2015 17:58:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=sender:message-id:date:from:user-agent:mime-version:to:cc:subject :references:in-reply-to:content-type:content-transfer-encoding; bh=BWchRWKD0T9Wok6IdlRYBeofq2c7Ju+fGEoEBSEpZis=; b=nVNlfI7GwqZ5rL9Waw0qO3YSgM5y8Snli9jq14+atWJZtojCYInJwj3QTWHSsZT4V1 Mlc+mV5b23I8JsQZKzAJ5WHNSF7MrGeQjFgjrGq57rePym/5zEn7EqV5cH08khiVd1oJ P1a9bAn3/1yFX3lfCSonq4gyCHb9V/vORNLeWdpbRJxJxm7ojya90MM810Da5fyexEhw 3E9p2GpjqPBEuqNIdJi49V1A1ZkhB/NBRjYlrPGsQsJugNbiidB5Qu5k9OuUU1d1IRJ9 eCZPnhG+IEe6fByN7kavQ5KVOyaL8ATGDMJm6Qxdr38e/b9Q04F7eDE6IsISGowNFEO9 SMSg== X-Received: by 10.68.221.165 with SMTP id qf5mr1746248pbc.101.1423187906214; Thu, 05 Feb 2015 17:58:26 -0800 (PST) Received: from [10.192.166.0] (stargate.chelsio.com. [67.207.112.58]) by mx.google.com with ESMTPSA id t10sm6275534pdr.75.2015.02.05.17.58.24 (version=TLSv1.2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Thu, 05 Feb 2015 17:58:24 -0800 (PST) Sender: Navdeep Parhar Message-ID: <54D41FBE.60204@FreeBSD.org> Date: Thu, 05 Feb 2015 17:58:22 -0800 From: Navdeep Parhar User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:31.0) Gecko/20100101 Thunderbird/31.4.0 MIME-Version: 1.0 To: NGie Cooper Subject: Re: svn commit: r278303 - in head/sys: dev/cxgbe modules/cxgbe modules/cxgbe/if_cxl References: <201502060110.t161A58m067355@svn.freebsd.org> In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: "svn-src-head@freebsd.org" , "svn-src-all@freebsd.org" , "src-committers@freebsd.org" X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.18-1 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 06 Feb 2015 01:58:27 -0000 On 02/05/15 17:33, NGie Cooper wrote: > On Thu, Feb 5, 2015 at 5:10 PM, Navdeep Parhar wrote: >> Author: np >> Date: Fri Feb 6 01:10:04 2015 >> New Revision: 278303 >> URL: https://svnweb.freebsd.org/changeset/base/278303 >> >> Log: >> cxgbe(4): Add a minimal if_cxl module that pulls in the real driver as >> a dependency. This ensures "ifconfig cxl ..." does the right thing >> even when it's run with no driver loaded. >> >> if_cxl.ko is the tiniest module in /boot/kernel. > > A couple things: > > 1. cxl(4) doesn't have a manpage: cxgbe(4) is the man page, cxl(4) should probably link to that. > > $ man 4 cxl > No manual entry for cxl > $ man 4 if_cxl > No manual entry for if_cxl > > 2. This could have been done with hardlinks to avoid creating an > additional driver (and on the plus side it saves disk space): What is the collective wisdom on hard links vs. dummy module? I'm open to either of them. In this particular case the end is more important than the means. About 4KB worth of disk space is involved. > ... > > This is basically what I'm going to set out and do to fix this PR: > https://bugs.freebsd.org/bugzilla/show_bug.cgi?id=186449 (it's another > item that irritates me with misnamed drivers, like ixgbe.ko used to > be...). It was the bugzilla email to freebsd-net with your grab of 186449 that reminded me that I needed to fix "ifconfig cxl" for cxgbe. :-) > Using hardlinks instead of renaming the driver is preferred because it > makes MFCing possible without breaking loader.conf for sysadmins. In > general, major version steps (CURRENT) should use if_ > consistently. My change doesn't break any loader.conf. if_cxgbe_load in loader.conf will continue to work exactly as before. if_cxl_load will never be required, but won't do any harm either. Regards, Navdeep