From owner-freebsd-hackers@FreeBSD.ORG  Thu Dec 20 19:55:14 2007
Return-Path: <owner-freebsd-hackers@FreeBSD.ORG>
Delivered-To: hackers@freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34])
	by hub.freebsd.org (Postfix) with ESMTP id 84BCB16A468
	for <hackers@freebsd.org>; Thu, 20 Dec 2007 19:55:14 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from speedfactory.net (mail6.speedfactory.net [66.23.216.219])
	by mx1.freebsd.org (Postfix) with ESMTP id 29C7913C4E8
	for <hackers@freebsd.org>; Thu, 20 Dec 2007 19:55:13 +0000 (UTC)
	(envelope-from jhb@freebsd.org)
Received: from server.baldwin.cx (unverified [66.23.211.162]) 
	by speedfactory.net (SurgeMail 3.8q) with ESMTP id 225317978-1834499 
	for multiple; Thu, 20 Dec 2007 14:37:03 -0500
Received: from localhost.corp.yahoo.com (john@localhost [127.0.0.1])
	(authenticated bits=0)
	by server.baldwin.cx (8.13.8/8.13.8) with ESMTP id lBKJcsl7077483;
	Thu, 20 Dec 2007 14:38:54 -0500 (EST) (envelope-from jhb@freebsd.org)
From: John Baldwin <jhb@freebsd.org>
To: freebsd-hackers@freebsd.org
Date: Thu, 20 Dec 2007 13:46:55 -0500
User-Agent: KMail/1.9.6
References: <20071219.232511.-1548301831.imp@bsdimp.com>
In-Reply-To: <20071219.232511.-1548301831.imp@bsdimp.com>
MIME-Version: 1.0
Content-Type: text/plain;
  charset="iso-8859-1"
Content-Transfer-Encoding: 7bit
Content-Disposition: inline
Message-Id: <200712201346.55717.jhb@freebsd.org>
X-Greylist: Sender succeeded SMTP AUTH authentication, not delayed by
	milter-greylist-2.0.2 (server.baldwin.cx [127.0.0.1]);
	Thu, 20 Dec 2007 14:38:54 -0500 (EST)
X-Virus-Scanned: ClamAV 0.91.2/5192/Thu Dec 20 12:24:15 2007 on
	server.baldwin.cx
X-Virus-Status: Clean
X-Spam-Status: No, score=-4.4 required=4.2 tests=ALL_TRUSTED,AWL,BAYES_00 
	autolearn=ham version=3.1.3
X-Spam-Checker-Version: SpamAssassin 3.1.3 (2006-06-01) on server.baldwin.cx
Cc: hackers@freebsd.org
Subject: Re: Some diffs
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
	<freebsd-hackers.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
	<mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-hackers>,
	<mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 20 Dec 2007 19:55:14 -0000

On Thursday 20 December 2007 01:25:11 am M. Warner Losh wrote:
> Consider the following diffs.  The first one does a tiny cleanup of
> strfile's include style (no real reason other than it bugged me when I
> added stdint.h).
> 
> The second one cleans up a minor problem where ${CFLAGS} isn't used
> where it should be.
> 
> The next three cleanup the compilation by not assuming sys/types.h is
> included or by also including <stdint.h>

These all seem fine to me.

> And the last, rather long, patch converts the .y in config to a form
> that more versions of yacc would grok.

I have no yacc-clue.

> Comments?

Was the bsd.prog.mk change accidentally included?

> ==== //depot/projects/arm/src/share/mk/bsd.prog.mk#4 - /Users/imp/p4/arm/src/share/mk/bsd.prog.mk ====
> @@ -110,17 +110,18 @@
>  
>  .if defined(PROG)
>  _EXTRADEPEND:
> -.if defined(LDFLAGS) && !empty(LDFLAGS:M-nostdlib)
> +.if !defined(FOREIGN_BUILD)
>  .if defined(DPADD) && !empty(DPADD)
>  	echo ${PROG}: ${DPADD} >> ${DEPENDFILE}
>  .endif
> -.else
> +.if defined(LDFLAGS) && !empty(LDFLAGS:M-nostdlib)
>  	echo ${PROG}: ${LIBC} ${DPADD} >> ${DEPENDFILE}
>  .if defined(PROG_CXX)
>  	echo ${PROG}: ${LIBSTDCPLUSPLUS} >> ${DEPENDFILE}
>  .endif
>  .endif
>  .endif
> +.endif
>  
>  .if !target(install)

-- 
John Baldwin