From nobody Sun Feb 15 14:27:42 2026 X-Original-To: dev-commits-src-main@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fDSt91Vjwz6RZXK for ; Sun, 15 Feb 2026 14:27:45 +0000 (UTC) (envelope-from ahmadkhalifa570@gmail.com) Received: from mail-yx1-xb133.google.com (mail-yx1-xb133.google.com [IPv6:2607:f8b0:4864:20::b133]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fDSt86fNQz3Xvv for ; Sun, 15 Feb 2026 14:27:44 +0000 (UTC) (envelope-from ahmadkhalifa570@gmail.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-yx1-xb133.google.com with SMTP id 956f58d0204a3-64aea64bf15so2154230d50.2 for ; Sun, 15 Feb 2026 06:27:44 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1771165663; cv=none; d=google.com; s=arc-20240605; b=Du56KWFEgm7a1rGGXfAkXKM3XISfhvnHdg3WeIkJhcffQ8LIgJ/5C+FyGGUtAANgnX qngbl5nvSb3AA2ThhE59gtxNVqpUhM7IsLPPkZsF0j78M8DZrRMsdvKCcOGM/ZD4CQY+ yMWguxHJtAhg7wKdJ+YIgW+DBkPyPexa30UgQ8ZRpkFRlQ1utzd7vQjcrV4+wqsHkKe6 YNp1ILMiNwP44DO3+R97Kr+QzKNiVI6IewUV/3uOuk5wuQRXctf6wR2jQ6IajIoYBjjW r7wM25sLYAaZXT93C8d+NoDpOTdkgdpA/jRcW16xEE8UD67m8ZPWmMpijHgOummOaOz0 nPIA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=cc:to:subject:message-id:date:in-reply-to:references:from :mime-version:dkim-signature; bh=g+gPeCSRYBAzeJPeyzMHrrbnF29LoImHvjGODHflglo=; fh=Y+2AfcGHWnlTUP/TXNsfSJ4liRnTVfwEUi2A1LNt9QE=; b=Us03bE6cNzFS8Jm8S8K7dOcwU015QxApkMHUHMwq/+hBcTVTkfIm1KJuuPqv7zJCli ehXfclQi1YldMomgbICVBQAouuaxXveTyXg4wDxnqx8KHMQZd4rH+IfRin5+sRmrkjjm W0F/ABEz6E8wyWEw1y97mASyRp0836jWbsSDpY2GJsDoCJcGV0C+HZGjMBst95N8sTXs GI/vsbCArvnKIpNJQsYfmFA+51HmpIFJ+FQsLKL4K+VMd8MTpixx/CxjIJ8F3OF9G/bb lRub0yjHAK33mXW+2oJtWlt3i9649Sj4r3BxD41GYlpfwc42Ps0TMbpwc+g2jxvrMHnd J9Vg==; darn=freebsd.org ARC-Authentication-Results: i=1; mx.google.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1771165663; x=1771770463; darn=freebsd.org; h=cc:to:subject:message-id:date:in-reply-to:references:from :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=g+gPeCSRYBAzeJPeyzMHrrbnF29LoImHvjGODHflglo=; b=ZX1v29BHSvTUbtYJCwK9gBuBTIw12w6xSgiuz3qVtT8lpdEzvpKJnv3L5w4Aq1sqEu pQqCcMyZQMaY/vsF7zwkYZWfVvffmeovlbznSBVD9l/xofeUjg7oOZGyp8HbeJgdfIET H8Kc41FMlyY5qvLkooF3G5e1xiCBR2p1+xgTbkA9RtIHzYTRzyB4sLvT5xAZU777LVau 78F4fCFk/iMC7ElVpOklx0zNNN1Htg99HA+D40b9CZ77JrZyABew/EKSbjkRVLq+It3n pwWY19DatMTS7Ps3VJGvx60vRhfaFut3UcxGUUDFEflFjE/H7NFb0HaAvem4nOtyUupV WSUg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1771165663; x=1771770463; h=cc:to:subject:message-id:date:in-reply-to:references:from :mime-version:x-gm-gg:x-gm-message-state:from:to:cc:subject:date :message-id:reply-to; bh=g+gPeCSRYBAzeJPeyzMHrrbnF29LoImHvjGODHflglo=; b=w1ou4JvUD0HHrjbXtS663b5syEvGIfMdR41epbBqCEgOXz8TcXuJk/sJHmqz/pnpdr w1ewEkV7SUU4kQUiHMhIdz7GCJlhp9YDdu+iC7wHrzyZRGBG+98wGMgmNb4F/IapSv9Q CIaCYzsVBQzCcsmVC9nk/apmIbtdeJ0FkL3Eh6gJ97BsDA98DbS4+6riAz9igsVqCN8u FjhSoMPs+tWMjKA2dWRwtwMG3wDGQlsGJCN4mAGQNJ/fYkpTytu9sbJLh3XstaoLKsRY ffcbUcHqq7/3/Fc+ZJHyzB0Sylq8fXMRsmdRcr7RCpmIN0VIJiOLxoayC3by7AE6Vo83 fppw== X-Forwarded-Encrypted: i=1; AJvYcCXs+OTWKMcv7JIdV2XYOwj1Fssc640j7R7fKAFf3MnwMdo7Ua/z1qE9HfR1Dd2HpTYnEtt9nQZ0Qo7sB8qK2mwkwEfuzg==@freebsd.org X-Gm-Message-State: AOJu0YxlWv6PhjHVCS2vHmQ3gUEC69UndzjvR6a8asalayAFdwxnXz3r YvYZx8wYN/GJAZXOTHcYlZFGDNW5zYZ0hiIWV609/9M4ghHmaejyLF0+sc8QH195nvk3obkQVpt 1a17pwPDjrJnd0YVfJ292sJxbftuNNUk= X-Gm-Gg: AZuq6aJYQtcpjkqElwsf6mEjYcLC19EsBzBP19EJ4eZo7wHBvKBCvtnXNBCzurqdQ6F uSnabTsp0saWODvSq46WxItKsjcU6PkAWoagUP3o1hXIh6xR8/j+m+ADEoXXc+DBfPE9X3NxeY4 /uuV+MKwdKsWq1VYdSKXPG6WVa6doQrl8+d7Z9YOwASOLeJ4NBJtVKNnKkh73xc7xaYelKxk2j0 pQlofitzRsYLNGxvp06A+iYWfug3ulaBuWiDsslvWWs0+yENujXwVtzsAGf5C4cCozBS2Yc4Um4 K/T2UOCL X-Received: by 2002:a05:690c:9d:b0:796:4ab9:f29b with SMTP id 00721157ae682-797a0cacb4bmr129923987b3.39.1771165662816; Sun, 15 Feb 2026 06:27:42 -0800 (PST) Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sun, 15 Feb 2026 06:27:42 -0800 Received: from 490177373942 named unknown by gmailapi.google.com with HTTPREST; Sun, 15 Feb 2026 06:27:42 -0800 List-Id: Commit messages for the main branch of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-main List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-main@freebsd.org Sender: owner-dev-commits-src-main@FreeBSD.org Mime-Version: 1.0 From: Ahmad Khalifa X-Mailer: aerc 0.21.0 References: <6991d07b.43f21.696cde4f@gitrepo.freebsd.org> <0B6A645E-D9E4-4337-B280-7E3CBA1FDC1B@freebsd.org> In-Reply-To: <0B6A645E-D9E4-4337-B280-7E3CBA1FDC1B@freebsd.org> Date: Sun, 15 Feb 2026 06:27:42 -0800 X-Gm-Features: AaiRm50A6Evfo-lFB3jAxw2q0xfEaHUttqrmUp6zoCVxp-8IkPWQTRqXh6pdDAE Message-ID: Subject: Re: git: a60e7e6ff0ec - main - stand: compile ia32 EFI loader with -malign-double To: Jessica Clarke Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" Content-Type: text/plain; charset="UTF-8" X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:2607:f8b0::/32, country:US] X-Rspamd-Queue-Id: 4fDSt86fNQz3Xvv X-Spamd-Bar: ---- On Sun Feb 15, 2026 at 4:02 PM +0200, Jessica Clarke wrote: > On 15 Feb 2026, at 13:56, Ahmad Khalifa wrote: >> >> The branch main has been updated by vexeduxr: >> >> URL: https://cgit.FreeBSD.org/src/commit/?id=a60e7e6ff0ec1fdd66c2568ac6c03b843dbb3c9d >> >> commit a60e7e6ff0ec1fdd66c2568ac6c03b843dbb3c9d >> Author: Ahmad Khalifa >> AuthorDate: 2026-02-15 12:23:26 +0000 >> Commit: Ahmad Khalifa >> CommitDate: 2026-02-15 13:30:06 +0000 >> >> stand: compile ia32 EFI loader with -malign-double >> >> The UEFI spec says: >>> Structures are aligned on boundaries equal to the largest internal >>> datum of the structure and internal data are implicitly padded to >>> achieve natural alignment. >> >> By default, structs containing members of type "long long" have 4 byte >> alignment on i386. This caused some EFI structures to be subtly wrong. >> >> Fix this by compiling the ia32 EFI loader with -malign-double, which >> bumps the alignment up to 8 if such members are present. > > This seems like a dangerously big hammer. Are there any types shared > with libsa or the kernel itself that would change layout? (I suppose > for the latter they already need to be aligned as the kernel is 64-bit?) For the kernel, any shared types would have already needed to be aligned, yes. I didn't consider shared types with either libsa or libefi though, I'll look into it now. Nice catch. > > Annotating just the EFI types would seem more appropriate, like how we > annotate function pointers to use the Microsoft calling convention. They're all under contrib unfortunately. Not sure if we want to introduce that big of a diff with upstream. > > Jessica