From owner-svn-src-all@freebsd.org Sat Nov 14 20:51:49 2020 Return-Path: Delivered-To: svn-src-all@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id CC02346555A; Sat, 14 Nov 2020 20:51:49 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: from mail-wm1-x32b.google.com (mail-wm1-x32b.google.com [IPv6:2a00:1450:4864:20::32b]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4CYSF13xpzz3wTf; Sat, 14 Nov 2020 20:51:49 +0000 (UTC) (envelope-from mjguzik@gmail.com) Received: by mail-wm1-x32b.google.com with SMTP id c9so19886430wml.5; Sat, 14 Nov 2020 12:51:49 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:in-reply-to:references:from:date:message-id:subject:to :cc; bh=aGS5h+muelvCzVcowv/2gUEgz4sdzZAKtEBYcdHxDxc=; b=XKbF0t8OLHfsjTwvo/fJ6eVDdarAYJvbIOxVnT2U0oHBEgS5f2hi3ChKqhR/vExoMm iSpYAmEopGlDcsA6PC1GhmU6heM4uFrmTgRgBj3z10K4IVljUUDtHoUACM7EIl0LDocJ 6YD/MT9IeKqrlrZ9O9D4knxdyZEjee3R/ODGkzghRwt0lC0vf5QMYRHVZ6mCvnHYFlQG kcCvdke+Na8CzX41JezVxqGxIdpj3UoGZegxa9ySwJfdgiVkkoeF0tKdmJ14lADItAga 4F6oOfsuQRAFXxOpPn9voB6AT3u+UICvNTfnPlfIgN+2kqF7tLreLqfXDfBjlLm8Hugd yGqQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:in-reply-to:references:from:date :message-id:subject:to:cc; bh=aGS5h+muelvCzVcowv/2gUEgz4sdzZAKtEBYcdHxDxc=; b=HCvPONQmLgj4VSRlrvQ9YDGRu/i1gGhWbEXbCMCQnxLroU725XoC375yErm8yM8NCE hVScgDv7xbbkr1udka/BG5K11yu0a+Jnb5VtZYAErzkhu2eVJa2TQHaKFtPSlx+RxKxg TKdZVFQ21D6JQJAcjr+9C0rILuyyKfBgqCeM9ftmiIvS0vVaOqcYLAoLniP4W8Hsu5+n P6/Hv9Ob5XNuEyCytkeXfcr1IDCed3XhgHsJUZYfteydbVZ8O0os2adc4Raux8ol6n9d PGjsEnIWfQw63zfgduAXYDDLFHWUz8p/EeiGGW9EYWEx+IvmWiCD7TXF4jcYGebBR0Qy +N+A== X-Gm-Message-State: AOAM533h8sU0mEeFXYSblHIn26y6Cg2VoKUOV3m9TWOtuOm9JRbwbzLQ HeSufp9VH6eRjhk0LQpxeSIjVE2ycgxkbqZzEZb6TCMxC08= X-Google-Smtp-Source: ABdhPJwDpOhnmmd6YTKhSDzh7G9YHSFzqROdfKJ6zpN/yiEVn4EXmOIhyJ7olGoyCuxoSmVmMayATtgScCw/oMthZZ0= X-Received: by 2002:a05:600c:290a:: with SMTP id i10mr8274302wmd.187.1605387107840; Sat, 14 Nov 2020 12:51:47 -0800 (PST) MIME-Version: 1.0 Received: by 2002:adf:dec7:0:0:0:0:0 with HTTP; Sat, 14 Nov 2020 12:51:47 -0800 (PST) In-Reply-To: <20201114205036.tnxvwarsddmu4shz@mutt-hbsd> References: <202011141920.0AEJKbpO050396@repo.freebsd.org> <20201114205036.tnxvwarsddmu4shz@mutt-hbsd> From: Mateusz Guzik Date: Sat, 14 Nov 2020 21:51:47 +0100 Message-ID: Subject: Re: svn commit: r367692 - head/sys/sys To: Shawn Webb Cc: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Content-Type: text/plain; charset="UTF-8" X-Rspamd-Queue-Id: 4CYSF13xpzz3wTf X-Spamd-Bar: ---- Authentication-Results: mx1.freebsd.org; none X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Nov 2020 20:51:49 -0000 I don't think so, it does not change any APIs On 11/14/20, Shawn Webb wrote: > On Sat, Nov 14, 2020 at 07:20:37PM +0000, Mateusz Guzik wrote: >> Author: mjg >> Date: Sat Nov 14 19:20:37 2020 >> New Revision: 367692 >> URL: https://svnweb.freebsd.org/changeset/base/367692 >> >> Log: >> cred: reorder cr_audit to be closer to the lock >> >> This makes cr_uid avoid sharing. >> >> Modified: >> head/sys/sys/ucred.h >> >> Modified: head/sys/sys/ucred.h >> ============================================================================== >> --- head/sys/sys/ucred.h Sat Nov 14 19:19:27 2020 (r367691) >> +++ head/sys/sys/ucred.h Sat Nov 14 19:20:37 2020 (r367692) >> @@ -63,6 +63,7 @@ struct ucred { >> struct mtx cr_mtx; >> u_int cr_ref; /* (c) reference count */ >> u_int cr_users; /* (c) proc + thread using this cred */ >> + struct auditinfo_addr cr_audit; /* Audit properties. */ >> #define cr_startcopy cr_uid >> uid_t cr_uid; /* effective user id */ >> uid_t cr_ruid; /* real user id */ >> @@ -78,7 +79,6 @@ struct ucred { >> void *cr_pspare2[2]; /* general use 2 */ >> #define cr_endcopy cr_label >> struct label *cr_label; /* MAC label */ >> - struct auditinfo_addr cr_audit; /* Audit properties. */ >> gid_t *cr_groups; /* groups */ >> int cr_agroups; /* Available groups */ >> gid_t cr_smallgroups[XU_NGROUPS]; /* storage for small groups */ > > Hey Mateusz, > > Since this changes KBI, does __FreeBSD_version need bumping? > > Thanks, > > -- > Shawn Webb > Cofounder / Security Engineer > HardenedBSD > > GPG Key ID: 0xFF2E67A277F8E1FA > GPG Key Fingerprint: D206 BB45 15E0 9C49 0CF9 3633 C85B 0AF8 AB23 0FB2 > https://git-01.md.hardenedbsd.org/HardenedBSD/pubkeys/src/branch/master/Shawn_Webb/03A4CBEBB82EA5A67D9F3853FF2E67A277F8E1FA.pub.asc > -- Mateusz Guzik