From owner-svn-src-all@FreeBSD.ORG Mon Jul 15 18:16:14 2013 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [8.8.178.115]) by hub.freebsd.org (Postfix) with ESMTP id 7AE734A4; Mon, 15 Jul 2013 18:16:14 +0000 (UTC) (envelope-from adrian.chadd@gmail.com) Received: from mail-we0-x235.google.com (mail-we0-x235.google.com [IPv6:2a00:1450:400c:c03::235]) by mx1.freebsd.org (Postfix) with ESMTP id 7772FE82; Mon, 15 Jul 2013 18:16:13 +0000 (UTC) Received: by mail-we0-f181.google.com with SMTP id p58so10561858wes.12 for ; Mon, 15 Jul 2013 11:16:12 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date :x-google-sender-auth:message-id:subject:from:to:cc:content-type; bh=60DdkV3G83ezFC77Q6X8ONDIBvT726n9rgAD86U1I50=; b=HrhLvfBnw0+NZnOI6pJdmCxZhM5335yuidpI9rsakhxWrxLvuzyRvmVu2bLSRyYlzd nLZeBux59R97LfqWbFxqwsMUeeCsPOEA/8uQdXH05c7Oyg5D+znYb3R8A0Aff9Q8aRrh AP4GYb33X+DD+xscDdDFbe47IFKepb8qcx1jGL1HJqiOCMn6gGtVYvzaY9wBj0T+X7ot /IxWGI5uEfvR3RujIjISMS1nXzFWmpx44wV4Y5/aU3rbiRAfzALJ9uY7zuW4OLyw89hZ BZnlNUrhm0kWFKP2B7g3XOyFsYX6KddFe7+Rw0/D8RFRoL/fCWADdepAI041LJ7L79o7 Accg== MIME-Version: 1.0 X-Received: by 10.180.82.196 with SMTP id k4mr9940185wiy.0.1373912172480; Mon, 15 Jul 2013 11:16:12 -0700 (PDT) Sender: adrian.chadd@gmail.com Received: by 10.217.94.132 with HTTP; Mon, 15 Jul 2013 11:16:12 -0700 (PDT) In-Reply-To: <20130715094701.GO8839@FreeBSD.org> References: <201307130425.r6D4P31J078644@svn.freebsd.org> <20130715094701.GO8839@FreeBSD.org> Date: Mon, 15 Jul 2013 11:16:12 -0700 X-Google-Sender-Auth: X-MbJTOkRemHCbHENFzzgkoBt8w Message-ID: Subject: Re: svn commit: r253314 - head/sys/net From: Adrian Chadd To: Gleb Smirnoff Content-Type: text/plain; charset=ISO-8859-1 Cc: svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.14 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 15 Jul 2013 18:16:14 -0000 Yup and they will be turned into per-interface ioctls before I merge it into -9. Thanks! -adrian On 15 July 2013 02:47, Gleb Smirnoff wrote: > On Sat, Jul 13, 2013 at 04:25:03AM +0000, Adrian Chadd wrote: > A> Author: adrian > A> Date: Sat Jul 13 04:25:03 2013 > A> New Revision: 253314 > A> URL: http://svnweb.freebsd.org/changeset/base/253314 > A> > A> Log: > A> Bring over some link aggregation / LACP protocol improvements and debugging > A> additions. > A> > A> * Add some new tracing events to aid in debugging. > A> * Add in a debugging mode to drop transmit and received frames, specifically > A> to test whether seeing or hearing heartbeats correctly cause LACP to > A> drop the port. > A> * Add in (and make default) a strict LACP mode, which requires the > A> heartbeat on a port to be heard before it's used. Sometimes vendor ports > A> will hang but the link layer stays up, resulting in hung traffic. > A> * Add logging the number of link status flaps, again to aid in debugging > A> badly behaving switch ports. > A> * Calculate the lagg interface port speed as the multiple of the > A> configured ports, rather than the largest. > > Having the txtest, rxtest and lacp_strict a global sysctls makes them > useless on a box that has more than one aggregate interface. Turning > test on will down all laggs on a box. > > IMO, these should be ioctls that can be configured per-interface via > ifconfig, and in perfect case documented in ifconfig.8. > > -- > Totus tuus, Glebius.