From owner-freebsd-hackers@freebsd.org Fri Jun 1 15:21:43 2018 Return-Path: Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 7819DEFF412 for ; Fri, 1 Jun 2018 15:21:43 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: from mail-wr0-x234.google.com (mail-wr0-x234.google.com [IPv6:2a00:1450:400c:c0c::234]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id E021B81876 for ; Fri, 1 Jun 2018 15:21:42 +0000 (UTC) (envelope-from gljennjohn@gmail.com) Received: by mail-wr0-x234.google.com with SMTP id k16-v6so9471557wro.0 for ; Fri, 01 Jun 2018 08:21:42 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:in-reply-to:references:reply-to :mime-version:content-transfer-encoding; bh=y56NAvS8z1cWkxzYVm1s73aW5QJtIuTrR5R4hpkkD7Q=; b=Q5kwLVntf2eMH4tg/EpXhFJUI4nUAMViU+wJznmEcnamOcpEDrwjEv2vEHrpF/k+Fp PS6MaI/EFMqT8OmMnhzqqkZfN61ZaB040TRr0jb5b/jkMggEwPqlP7KFDrlEF7hZ0RDG es1+v7EwIw190Wg69o8VWTO+UOchyi1Xvte58fvdOmzol4iQAtpkX6fWteKwX642Ef2Y 1lqcy7pbUzR2R41MwKRVJ3p8hTEGdeUGedS9MDD22BQ9r82SCO8tk38ZgiahxIbRqHjY 8oxTw28nSO8JE8PopQ3zolecH17KE5QUds/fydZSJlRM97eNdNb7heyo7CoJyjJ2j/ES ooww== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:in-reply-to :references:reply-to:mime-version:content-transfer-encoding; bh=y56NAvS8z1cWkxzYVm1s73aW5QJtIuTrR5R4hpkkD7Q=; b=THhWefCLiosGbX78rAdn/pJXD3R7r1QcTRUyOfz3k7iff9rXt560Axwhgplf2F5X6D csgmIjkQ6ktIhZZ9JpRQEvMs7zZ3ZfcGvJa3FWSchTJv6OoMLpUav4BBr4pmvmpseaRq QfD1Hz0H5vaknZ7ycQVEV/gI4saL90k2VrF5aE6gSrs4mzwFQReMPbMyOWZBcTbTqHdL oIR9JBOb2H7ixyXnPRRsq8bMYx/6jvrRVfayvm4/+qMF3KYgeMirIfDmEFYnc0lwoFy3 D0Ux3dhBZqxQxW9vOOr+3ofbqE43zg7fi9utNP8W6dZxZC0HlGiFVJ8bZFgGXmO/yh7D A/+Q== X-Gm-Message-State: ALKqPwc0Ol5iFqbaaRbJXnO/fgW6vxEn7/1ZnYTTa8kbTFaUZEX0ykHM Vml6ekbdFenJUdAI6646wd8= X-Google-Smtp-Source: ADUXVKLsIrvHve6jGTMcYY45/n+9QKFHCbInCMdd38ypkgoSPy34EcW6XFLz8fyIvLjg6+Ow6TZBzQ== X-Received: by 2002:adf:9b11:: with SMTP id b17-v6mr9120224wrc.206.1527866501196; Fri, 01 Jun 2018 08:21:41 -0700 (PDT) Received: from ernst.home (p5B02337A.dip0.t-ipconnect.de. [91.2.51.122]) by smtp.gmail.com with ESMTPSA id 69-v6sm2419184wmi.29.2018.06.01.08.21.40 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Fri, 01 Jun 2018 08:21:40 -0700 (PDT) Date: Fri, 1 Jun 2018 17:21:39 +0200 From: Gary Jennejohn To: Warner Losh Cc: Bob Bishop , "freebsd-hackers@freebsd.org" , Poul-Henning Kamp , Dieter BSD Subject: Re: PRs are being closed for bogus reasons :-( Message-ID: <20180601172139.244f739e@ernst.home> In-Reply-To: References: <1407.1527801278@critter.freebsd.dk> Reply-To: gljennjohn@gmail.com X-Mailer: Claws Mail 3.16.0 (GTK+ 2.24.32; amd64-portbld-freebsd12.0) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-BeenThere: freebsd-hackers@freebsd.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: Technical Discussions relating to FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Jun 2018 15:21:43 -0000 On Fri, 1 Jun 2018 09:09:47 -0600 Warner Losh wrote: > On Fri, Jun 1, 2018 at 8:53 AM, wrote: > > > > > > On 1 Jun 2018, at 15:41, Warner Losh wrote: > > > > > >> On Fri, Jun 1, 2018 at 8:10 AM, Bob Bishop wrote: > > >> Hi, > > >> > > >> > On 31 May 2018, at 22:14, Poul-Henning Kamp > > wrote: > > >> > > > >> > -------- > > >> > In message > mail.gmail.com> > > >> > , Warner Losh writes: > > >> > > > >> >> There's a problem with the PR database: there's too many bugs. > > >> > > > >> > And despite the valiant efforts of a number of people over the > > >> > lifetime of the project, it has always had so many bugs that > > >> > everybody just threw their hands in the air and walked away. > > >> > > > >> > The way to improve the situation is to fix PR's, not to complain > > >> > about PRs. > > >> > > >> Indeed. But look at the number of PRs with patches that are stuck in > > that state. Not pretty. > > > > > > Over the years I've committed dozens of PRs that had patches in them. > > The sad truth is that only about 10-15% of them have comitable patches in > > them when submitted. And that number decays over time as things age in > > bugzilla. [etc] > > > > Sure. But the best a non-comitter can do is to supply a patch tested > > against HEAD. If the patch rots because it hasn't been committed six months > > down the line it's not my fault. > > > > Well, not quite true. I've had several people send me pointers to bugs over > the years and engage me when I tell them that the patch isn't quite right. > That conversation is easier, to my mind, in Phabricator, though. There's no > substitute for making good connections and motivating volunteers to want to > help you. That gives much better results than filing and forgetting and > hoping for the best. As a committer, I find it a low return on investment > to go looking at random PRs. I find it a much higher return on investment > when I have a history with someone (even a short one). > > Fixing this broken state of affairs is not going to be easy... > As a former committer (gj@) I find it easier to send patches to the maintainer. But, I've only done that with Hans Petter Selasky so far, for some XHCI stuff. -- Gary Jennejohn