From owner-freebsd-stable@FreeBSD.ORG Wed Dec 26 17:35:05 2007 Return-Path: Delivered-To: stable@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id C9EE916A41A; Wed, 26 Dec 2007 17:35:05 +0000 (UTC) (envelope-from henrik@gulbra.net) Received: from av12-1-sn2.hy.skanova.net (av12-1-sn2.hy.skanova.net [81.228.8.185]) by mx1.freebsd.org (Postfix) with ESMTP id 1934A13C442; Wed, 26 Dec 2007 17:35:05 +0000 (UTC) (envelope-from henrik@gulbra.net) Received: by av12-1-sn2.hy.skanova.net (Postfix, from userid 502) id 2808838D02; Wed, 26 Dec 2007 18:16:51 +0100 (CET) Received: from smtp4-1-sn2.hy.skanova.net (smtp4-1-sn2.hy.skanova.net [81.228.8.92]) by av12-1-sn2.hy.skanova.net (Postfix) with ESMTP id 11BB438C90; Wed, 26 Dec 2007 18:16:51 +0100 (CET) Received: from [192.168.0.2] (81-235-156-87-no29.tbcn.telia.com [81.235.156.87]) by smtp4-1-sn2.hy.skanova.net (Postfix) with ESMTP id 7DDFB37E44; Wed, 26 Dec 2007 18:16:48 +0100 (CET) From: Henrik Gulbrandsen To: "M. Warner Losh" , Mikhail Teterin In-Reply-To: <20071226.003547.-932932005.imp@bsdimp.com> References: <200712212341.44308@aldan> <200712221313.lBMDDx5M036478@lava.sentex.ca> <200712260038.11546@aldan> <20071226.003547.-932932005.imp@bsdimp.com> Content-Type: text/plain Date: Wed, 26 Dec 2007 18:15:16 +0100 Message-Id: <1198689316.1119.382.camel@Particle> Mime-Version: 1.0 X-Mailer: Evolution 2.12.1 FreeBSD GNOME Team Port Content-Transfer-Encoding: 7bit Cc: stable@freebsd.org, freebsd-usb@freebsd.org Subject: Re: usb/umass, devfs: this sucks X-BeenThere: freebsd-stable@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: Production branch of FreeBSD source code List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 26 Dec 2007 17:35:05 -0000 On Wed, 2007-12-26 at 00:35 -0700, M. Warner Losh wrote: > In message: <200712260038.11546@aldan> > Mikhail Teterin writes: > : If we want people to give FreeBSD a try in good faith, it is both profoundly > : stupid and dishonest on our part to claim, we have a working USB-system... It > : does not matter, how great our buffer-sharing VM is, if a home user can't > : process their photos with a FreeBSD-powered computer. > > In an ideal world, it would be perfect. > > However, all the USB hardware I've recently purchased actually does > work without a hitch on my FreeBSD system. Older card readers are > more problematic. > > Rather than complain about the system, how about merging RELENG_7's > usb stack to RELENG_6? Or fixing a few bugs from the PRs that are > filed? I did my time in a big push for 7.0, maybe some other people > can help out a little too? Fixing and merging are good, but it seems to me (as an occasional patch contributor without commit privileges) that the bottleneck for USB is still in the handling of incoming patches. At the moment, there are 162 USB PRs to close. Out of these, 103 are marked with "[patch]", but only 42 of those are actually in "patched" state. Almost all of the latter were apparently handled as part of Warner's summer push. The USB stack has to deal with many third-party devices, most of which will not be immediately available for testing by FreeBSD developers. This means that we are more or less forced to rely on external patch contributors (such as myself) to provide workarounds for the problems caused by various hardware peculiarities. Usually, it shouldn't take more than a basic code review to accept these patches, so this would be a good place to start if you want to improve USB handling in FreeBSD. Look at it from my perspective: I would be happy to complete my fix for the infamous five-year-old usb/46176, so people can finally detach umass devices without having to manually unmount them first. However, it will undoubtedly take a non-trivial amount of time to reproduce and eliminate the remaining issues. I'm more likely to put in that effort if I believe that my patches may actually end up in CURRENT, but if a one-line fix such as that in usb/78984 has not been applied after more than a year, how long will it take for patches that involve multiple subsystems? /Henrik