From owner-freebsd-hackers@freebsd.org  Wed Feb 14 15:30:16 2018
Return-Path: <owner-freebsd-hackers@freebsd.org>
Delivered-To: freebsd-hackers@mailman.ysv.freebsd.org
Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1])
 by mailman.ysv.freebsd.org (Postfix) with ESMTP id 95C04F07A40
 for <freebsd-hackers@mailman.ysv.freebsd.org>;
 Wed, 14 Feb 2018 15:30:16 +0000 (UTC)
 (envelope-from eric@vangyzen.net)
Received: from smtp.vangyzen.net (hotblack.vangyzen.net [199.48.133.146])
 by mx1.freebsd.org (Postfix) with ESMTP id 3A76C7DF43
 for <freebsd-hackers@freebsd.org>; Wed, 14 Feb 2018 15:30:15 +0000 (UTC)
 (envelope-from eric@vangyzen.net)
Received: from sweettea.beer.town (unknown [76.164.8.130])
 by smtp.vangyzen.net (Postfix) with ESMTPSA id E837B5646B;
 Wed, 14 Feb 2018 09:30:14 -0600 (CST)
Subject: Re: select call in devd
To: Warner Losh <imp@bsdimp.com>, Eitan Adler <lists@eitanadler.com>
Cc: FreeBSD Hackers <freebsd-hackers@freebsd.org>, zrj@dragonflybsd.org
References: <CAF6rxgmrkUS18kVPCK1VkBJAhBQ2vY3_MJgq+XNjqcx8yFi7Lw@mail.gmail.com>
 <CANCZdfpVqqgCmwJqKfdwWEntZgOeo7dpTbs5ab8-W5Lo6pz1zw@mail.gmail.com>
From: Eric van Gyzen <eric@vangyzen.net>
Message-ID: <76665530-c7f1-cbe7-252b-a1d146b0f51d@vangyzen.net>
Date: Wed, 14 Feb 2018 09:30:12 -0600
User-Agent: Mozilla/5.0 (X11; FreeBSD amd64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <CANCZdfpVqqgCmwJqKfdwWEntZgOeo7dpTbs5ab8-W5Lo6pz1zw@mail.gmail.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-BeenThere: freebsd-hackers@freebsd.org
X-Mailman-Version: 2.1.25
Precedence: list
List-Id: Technical Discussions relating to FreeBSD
 <freebsd-hackers.freebsd.org>
List-Unsubscribe: <https://lists.freebsd.org/mailman/options/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-hackers/>
List-Post: <mailto:freebsd-hackers@freebsd.org>
List-Help: <mailto:freebsd-hackers-request@freebsd.org?subject=help>
List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/freebsd-hackers>, 
 <mailto:freebsd-hackers-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Wed, 14 Feb 2018 15:30:16 -0000

On 02/14/2018 09:13, Warner Losh wrote:
> On Wed, Feb 14, 2018 at 12:13 AM, Eitan Adler <lists@eitanadler.com> wrote:
> 
>> Hi all,
>>
>> select(2) is declared with restrict for the pointers for fd. Can y'all
>> confirm this is the correct fix?
>>
> 
> No. It's not. Select is not declared with restrict parameters. pselect is,
> but select is not.

You're right, it's not, but it /should/ be:

http://pubs.opengroup.org/onlinepubs/9699919799/functions/select.html

	Issue 6
	The restrict keyword is added to the select() prototype for
	alignment with the ISO/IEC 9899:1999 standard.

> There's no real call to change it.

...unless he intends to mount a valiant effort to fix our declaration.

Eric