From owner-svn-src-head@freebsd.org Thu Apr 21 17:26:28 2016 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C4EA0B17A41; Thu, 21 Apr 2016 17:26:28 +0000 (UTC) (envelope-from asomers@gmail.com) Received: from mail-oi0-x22d.google.com (mail-oi0-x22d.google.com [IPv6:2607:f8b0:4003:c06::22d]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 89620174F; Thu, 21 Apr 2016 17:26:28 +0000 (UTC) (envelope-from asomers@gmail.com) Received: by mail-oi0-x22d.google.com with SMTP id r78so94193114oie.0; Thu, 21 Apr 2016 10:26:28 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=mime-version:sender:in-reply-to:references:date:message-id:subject :from:to:cc; bh=5EC8JLlAakCw1Cv4g641xdzYUTr6ogN+nqPl0EXJ1XU=; b=S6nBuLSV5JB0x+/NiKykomiZJ7pBu3vGY35eE4jDq/bcGSAwDunHJn2zf7NBs3Nft6 f6FxJCmbRU+0dEaJ4mxdpF5QChad5r0/SUtyIeqxQw//tLNmIPLAvlEZx871jSZsk9mW KXah/fbsJSmoihdQDYfZANJsmh+jkRya3OUBry/2ceOZ5DsWVmKPvh2CimSOs5AUjD3/ 7tW2PHZaIAX8HCMAdvpVClo+CVso8SkgxmpOihXfmRF/AMgQgDrYPVpqVORCFG/s/F2g yrA+nHiDE8wTtH/whm9oSA8zCJonrr0jmybuS0hd1lOq0YZXlaJYcLWnn8B62gcm9DM5 TTnQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc; bh=5EC8JLlAakCw1Cv4g641xdzYUTr6ogN+nqPl0EXJ1XU=; b=APfFJUwS0KR5RLLCCQ5HR3FY8rRnJ5i1/fBYvwosPV6LizEMs3zhp0bNDu+I3wStLw yG+KM9qLlJANqZEhVilfFQDP2eTMApxDkCcDVwGYMGqxIuOZQZOcH5HZxWVvo77BLqxD CavTQjW/KwrM4ghlBVZpK3y+gt1ZqdtGhtW0XNbW6esLTIHO39CZNPecZZpbTG2N1OQa HOpx3nEYzMFSHTb7EiLeXH6R49oW99ZLFPEEvNTNBhkmB4uPu2RGzwHaEkua91d+QxyU dYxX8WRLEckEp7bTV1G95UJwD6oXm6wsKU4qlsXcGC0aP3oV5BwY/d+qo49ZtbveHcJV f3vg== X-Gm-Message-State: AOPr4FUYxQCnG2UEv2rhYS6xrW8SDCaBTnHuLmua+hnVwtoRO/UbZZkU55eto4PzMjOjWKk7i8NPznHNGxmdcw== MIME-Version: 1.0 X-Received: by 10.182.28.168 with SMTP id c8mr7125852obh.49.1461259587906; Thu, 21 Apr 2016 10:26:27 -0700 (PDT) Sender: asomers@gmail.com Received: by 10.202.64.138 with HTTP; Thu, 21 Apr 2016 10:26:27 -0700 (PDT) In-Reply-To: References: <201604211643.u3LGhFpR057982@repo.freebsd.org> Date: Thu, 21 Apr 2016 11:26:27 -0600 X-Google-Sender-Auth: SCqwqFe0rGNmOpp95t_Kc3ke8jY Message-ID: Subject: Re: svn commit: r298420 - head/sys/geom From: Alan Somers To: Ngie Cooper Cc: "src-committers@freebsd.org" , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 X-Content-Filtered-By: Mailman/MimeDel 2.1.21 X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 21 Apr 2016 17:26:28 -0000 On Thu, Apr 21, 2016 at 11:09 AM, Ngie Cooper wrote: > On Thu, Apr 21, 2016 at 10:08 AM, Ngie Cooper > wrote: > > On Thu, Apr 21, 2016 at 9:43 AM, Alan Somers > wrote: > >> Author: asomers > >> Date: Thu Apr 21 16:43:15 2016 > >> New Revision: 298420 > >> URL: https://svnweb.freebsd.org/changeset/base/298420 > >> > >> Log: > >> Notify userspace listeners when geom disk attributes have changed > >> > >> sys/geom/geom_disk.c: > >> disk_attr_changed(): Generate a devctl event of type > GEOM: for > >> every call. > >> > >> MFC after: 4 weeks > >> Sponsored by: Spectra Logic Corp > >> Differential Revision: https://reviews.freebsd.org/D5952 > >> > >> Modified: > >> head/sys/geom/geom_disk.c > >> > >> Modified: head/sys/geom/geom_disk.c > >> > ============================================================================== > >> --- head/sys/geom/geom_disk.c Thu Apr 21 16:33:42 2016 > (r298419) > >> +++ head/sys/geom/geom_disk.c Thu Apr 21 16:43:15 2016 > (r298420) > >> @@ -43,6 +43,7 @@ __FBSDID("$FreeBSD$"); > >> #include > >> #include > >> #include > >> +#include > >> #include > >> #include > >> #include > >> @@ -839,11 +840,14 @@ disk_attr_changed(struct disk *dp, const > >> { > >> struct g_geom *gp; > >> struct g_provider *pp; > >> + char devnamebuf[128]; > > > > Why 128? Also, why not sbuf? > > > >> gp = dp->d_geom; > >> if (gp != NULL) > >> LIST_FOREACH(pp, &gp->provider, provider) > >> (void)g_attr_changed(pp, attr, flag); > >> + snprintf(devnamebuf, 128, "devname=%s%d", dp->d_name, > dp->d_unit); > > > > Why not sizeof(devnamebuf) ? > > Also: this doesn't NUL terminate devnamebuf; it really should > (otherwise, boom... crash in geom)... > snprintf(3) says "The output is always null-terminated." and it looks like the kernel version does the same thing at subr_prf.c:560. Am I missing something?