Date: Mon, 08 Dec 2025 15:24:55 +0100 From: =?utf-8?Q?Dag-Erling_Sm=C3=B8rgrav?= <des@FreeBSD.org> To: Martin Matuska <mm@FreeBSD.org> Cc: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-main@FreeBSD.org Subject: Re: git: 2f6c77cd6f08 - main - zfs: unbreak build after 89f729dcc merge Message-ID: <86ikehf3uw.fsf@ltc.des.dev> In-Reply-To: <6936c495.24e13.745784d0@gitrepo.freebsd.org> (Martin Matuska's message of "Mon, 08 Dec 2025 12:29:09 %2B0000") References: <6936c495.24e13.745784d0@gitrepo.freebsd.org>
next in thread | previous in thread | raw e-mail | index | archive | help
Martin Matuska <mm@FreeBSD.org> writes:
> commit 2f6c77cd6f08b9bb646e038e3211b0ad21a2c012
> Author: Martin Matuska <mm@FreeBSD.org>
> AuthorDate: 2025-12-08 12:21:26 +0000
> Commit: Martin Matuska <mm@FreeBSD.org>
> CommitDate: 2025-12-08 12:21:26 +0000
>
> zfs: unbreak build after 89f729dcc merge
>
> Link zfsd against spl and pthread
Thank you for fixing this. In the future, please include Fixes: lines
with the correct commit hash (not the bogus one you put in the subject
line) when you fix an issue that can be traced to specific commits:
Fixes: 66e85755595a ("zfs: merge openzfs/zfs@89f729dcc")
Fixes: 8b78d412aec7 ("zfs: world changes after 89f729dcc merge")
By the way, there was no reason to split the merge in two commits. It
only makes life more difficult for people trying to bisect a bug.
DES
--
Dag-Erling Smørgrav - des@FreeBSD.org
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?86ikehf3uw.fsf>