From owner-freebsd-testing@FreeBSD.ORG Thu Jan 23 22:01:10 2014 Return-Path: Delivered-To: freebsd-testing@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) (using TLSv1 with cipher ADH-AES256-SHA (256/256 bits)) (No client certificate requested) by hub.freebsd.org (Postfix) with ESMTPS id 00BA9520; Thu, 23 Jan 2014 22:01:09 +0000 (UTC) Received: from mail-pb0-x22b.google.com (mail-pb0-x22b.google.com [IPv6:2607:f8b0:400e:c01::22b]) (using TLSv1 with cipher ECDHE-RSA-RC4-SHA (128/128 bits)) (No client certificate requested) by mx1.freebsd.org (Postfix) with ESMTPS id B73091145; Thu, 23 Jan 2014 22:01:09 +0000 (UTC) Received: by mail-pb0-f43.google.com with SMTP id md12so2387050pbc.16 for ; Thu, 23 Jan 2014 14:01:09 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20120113; h=content-type:mime-version:subject:from:in-reply-to:date:cc :content-transfer-encoding:message-id:references:to; bh=P7IamqrDDN5ibZGCDp2bdV3au/9mfKYoeuFxYmnq45U=; b=bWswiiLpU8vEjElsr+DLdYftl9z8XVNT05FXZ2eSxBGZJb5tx8UgCVhbBHxxgJN7cm snFB5Uop66nLdrQfQVlQNj79oTa5F7b50RMZoq3CFh37GNjbk5tPSFje7Dt1p/bOk57j LvhpDeT4qhxNoubxLBMonzQrEo/SpyfFCtlPL0EG9Qo0/VyO/b2B1/vSNYO7InNfEiFf e/2l+NGT+U2EsPDoGnzbQnRak06prZ5I/shMqKHDGZjWy/VLnZ7baSgWo2xtkSn9l+9b v4RfcyTZkEdiJnA+wZUK6GdsdUzB/PLk0gQ3OK024EgFj8SfNCLwCAdbOvkhrZjolZxZ d3wg== X-Received: by 10.68.189.132 with SMTP id gi4mr10535859pbc.57.1390514469368; Thu, 23 Jan 2014 14:01:09 -0800 (PST) Received: from fuji.zcorp.zonarsystems.com ([64.14.143.130]) by mx.google.com with ESMTPSA id sq7sm41488039pbc.19.2014.01.23.14.01.08 for (version=TLSv1 cipher=ECDHE-RSA-RC4-SHA bits=128/128); Thu, 23 Jan 2014 14:01:08 -0800 (PST) Content-Type: text/plain; charset=windows-1252 Mime-Version: 1.0 (Mac OS X Mail 7.1 \(1827\)) Subject: Re: Makefile.inc1.patch From: Garrett Cooper In-Reply-To: <20140123215430.4B7B15807E@chaos.jnpr.net> Date: Thu, 23 Jan 2014 14:01:07 -0800 Content-Transfer-Encoding: quoted-printable Message-Id: <8D80A156-F649-4CA1-846A-DBAE9CC30627@gmail.com> References: <4A3E3984-73D3-4441-97A7-D58679EFF978@gmail.com> <9775878D-91AB-4BE4-ADFA-32D8DB582AA6@gmail.com> <20140123210308.0E1D65807E@chaos.jnpr.net> <20140123215430.4B7B15807E@chaos.jnpr.net> To: "Simon J. Gerraty" X-Mailer: Apple Mail (2.1827) Cc: "freebsd-testing@freebsd.org" , brooks@freebsd.org X-BeenThere: freebsd-testing@freebsd.org X-Mailman-Version: 2.1.17 Precedence: list List-Id: Testing on FreeBSD List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 23 Jan 2014 22:01:10 -0000 On Jan 23, 2014, at 1:54 PM, Simon J. Gerraty wrote: > On Thu, 23 Jan 2014 13:30:12 -0800, Garrett Cooper writes: >>> Not crazy about frobbing ${MAKE} >>=20 >> Neither am I, but .export is a bmake only feature. I=3D92m still = using =3D >> fmake :(. >=20 > Not necessarily a good excuse ;-) fmake: "http://www.youtube.com/watch?v=3DdGFXGwHsD_A !!!!=94 :D It needs to die sometime, but Makefile.inc1 needs to continue to work = with it (for the time being). >>> The semantics in bsd.own.mk are quite broken and result in a lot of = =3D >> complex >>> dancing to keep things working. >>=20 >> In this case though, this is complex dancing due to how the different = =3D >> stages stack upon one another in the build process and the fact that = =3D >> meta make isn=3D92t here (yet), so things have to be built in the = right =3D >> order. This method is one that I=3D92ve been using for quite some = time =3D >> without any side effects on multiple machines... >=20 > Actually a simple tweak to the bsd.own.mk semantics would alleviate of > lot of the pain. Throwing errors if MK_* is already set, or if both > WITH_* and WITHOUT_* are set makes the usage very messy indeed. Yeah... > For options.mk I allow MK_* to already be set and WITHOUT_* to take > precedence over WITH_*. I also allow makefiles to have their own = lists > of options - separate the policy from the mechanism. Would that fix this case though? > I guess you could even allow a per-knob setting as to which takes > precedence.=20 You mean override the default so WITH_* overrides WITHOUT_*? > By simply allowing WITHOUT_* to overrule WITH_*, the Makefile.inc1 = usage > would be greatly simplified. Maybe=85 the -DNO_* logic is a bit messy=85 Curious to see what you have in mind :).. Thanks for the input :)! -Garrett=