From owner-p4-projects  Wed Oct  2 21:15:47 2002
Delivered-To: p4-projects@freebsd.org
Received: by hub.freebsd.org (Postfix, from userid 32767)
	id 320A737B404; Wed,  2 Oct 2002 21:15:45 -0700 (PDT)
Delivered-To: perforce@freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP
	id BD02C37B401; Wed,  2 Oct 2002 21:15:44 -0700 (PDT)
Received: from fledge.watson.org (fledge.watson.org [204.156.12.50])
	by mx1.FreeBSD.org (Postfix) with ESMTP
	id 38A9643E4A; Wed,  2 Oct 2002 21:15:44 -0700 (PDT)
	(envelope-from robert@fledge.watson.org)
Received: from fledge.watson.org (fledge.pr.watson.org [192.0.2.3])
	by fledge.watson.org (8.12.4/8.12.4) with SMTP id g934EvOo055333;
	Thu, 3 Oct 2002 00:14:57 -0400 (EDT)
	(envelope-from robert@fledge.watson.org)
Date: Thu, 3 Oct 2002 00:14:57 -0400 (EDT)
From: Robert Watson <rwatson@FreeBSD.org>
X-Sender: robert@fledge.watson.org
To: Brian Feldman <green@FreeBSD.org>
Cc: Perforce Change Reviews <perforce@FreeBSD.org>
Subject: Re: PERFORCE change 18560 for review
In-Reply-To: <200210022109.g92L9phK078099@freefall.freebsd.org>
Message-ID: <Pine.NEB.3.96L.1021003001356.54053G-100000@fledge.watson.org>
MIME-Version: 1.0
Content-Type: TEXT/PLAIN; charset=US-ASCII
Sender: owner-p4-projects@FreeBSD.ORG
Precedence: bulk
List-ID: <p4-projects.FreeBSD.ORG>
List-Archive: <http://docs.freebsd.org/mail/> (Web Archive)
List-Help: <mailto:majordomo@FreeBSD.ORG?subject=help> (List Instructions)
List-Subscribe: <mailto:majordomo@FreeBSD.ORG?subject=subscribe%20p4-projects>
List-Unsubscribe: <mailto:majordomo@FreeBSD.ORG?subject=unsubscribe%20p4-projects>
X-Loop: FreeBSD.ORG

This fix appears not to.  The bug I think you're running into has to do
with how UFS2 layers EA services on top of the existing write API, relying
on IO_EXT to address them to the right extent.  Since specfs implements
the VOP_WRITE() implementation for UFS2 device nodes, this breaks.  I've
forwarded some details to phk.

Robert N M Watson             FreeBSD Core Team, TrustedBSD Projects
robert@fledge.watson.org      Network Associates Laboratories

On Wed, 2 Oct 2002, Brian Feldman wrote:

> http://people.freebsd.org/~peter/p4db/chv.cgi?CH=18560
> 
> Change 18560 by green@green_laptop_2 on 2002/10/02 14:09:06
> 
> 	Make certain extattr calls don't occur on specfs files.
> 
> Affected files ...
> 
> .. //depot/projects/trustedbsd/mac/sys/fs/specfs/spec_vnops.c#11 edit
> 
> Differences ...
> 
> ==== //depot/projects/trustedbsd/mac/sys/fs/specfs/spec_vnops.c#11 (text+ko) ====
> 
> @@ -107,6 +107,10 @@
>  	{ &vop_lock_desc,		(vop_t *) vop_nolock },
>  	{ &vop_unlock_desc,		(vop_t *) vop_nounlock },
>  	{ &vop_islocked_desc,		(vop_t *) vop_noislocked },
> +	{ &vop_getextattr_desc,		(vop_t *) vop_eopnotsupp },
> +	{ &vop_setextattr_desc,		(vop_t *) vop_eopnotsupp },
> +	{ &vop_openextattr_desc,	(vop_t *) vop_eopnotsupp },
> +	{ &vop_closeextattr_desc,	(vop_t *) vop_eopnotsupp },
>  	{ NULL, NULL }
>  };
>  static struct vnodeopv_desc spec_vnodeop_opv_desc =
> 


To Unsubscribe: send mail to majordomo@FreeBSD.org
with "unsubscribe p4-projects" in the body of the message