From owner-freebsd-hackers  Tue Nov 12 08:10:49 1996
Return-Path: owner-hackers
Received: (from root@localhost)
          by freefall.freebsd.org (8.7.5/8.7.3) id IAA01845
          for hackers-outgoing; Tue, 12 Nov 1996 08:10:49 -0800 (PST)
Received: from plains.nodak.edu (tinguely@plains.NoDak.edu [134.129.111.64])
          by freefall.freebsd.org (8.7.5/8.7.3) with ESMTP id IAA01827;
          Tue, 12 Nov 1996 08:10:34 -0800 (PST)
Received: (from tinguely@localhost) by plains.nodak.edu (8.8.2/8.8.2) id KAA13353; Tue, 12 Nov 1996 10:10:20 -0600 (CST)
Date: Tue, 12 Nov 1996 10:10:20 -0600 (CST)
From: Mark Tinguely <tinguely@plains.nodak.edu>
Message-Id: <199611121610.KAA13353@plains.nodak.edu>
To: freebsd-hackers@freebsd.org
Subject: -current mbuf reference function
Cc: freebsd-current@freebsd.org
Sender: owner-hackers@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

I don't think the external reference (m_ext.ext_ref) function in the -current
sys/mbuf.h is complete. First, the function m_copypacket in kern/uipc_mbuf.c
only uses the old style reference incrememnt of:

	 mclrefcnt[mtocl(m->m_ext.ext_buf)]++

and even worse the MCLFREE macros in sys/mbuf.h only uses:

	 --mclrefcnt[mtocl(p)] == 0

to decrement the reference count and check to see if it time to release.

I think either a increment/decrement flag is needed to m_ext.ext_ref, or an
additional decrement function is needed, and this function is needed in the
MCLFREE macro.

--mark.