From nobody Tue Mar 17 11:34:58 2026 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4fZqdD0G7hz6W74c for ; Tue, 17 Mar 2026 11:35:12 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Received: from mail-wm1-f53.google.com (mail-wm1-f53.google.com [209.85.128.53]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "WR4" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4fZqdC4g9yz4MPg for ; Tue, 17 Mar 2026 11:35:11 +0000 (UTC) (envelope-from jrtc27@jrtc27.com) Authentication-Results: mx1.freebsd.org; none Received: by mail-wm1-f53.google.com with SMTP id 5b1f17b1804b1-4853aec185aso46305955e9.1 for ; Tue, 17 Mar 2026 04:35:11 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1773747310; x=1774352110; h=to:references:message-id:content-transfer-encoding:cc:date :in-reply-to:from:subject:mime-version:x-gm-gg:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=EmZ/QWeg3fopaLm+s8PLJNv2U3OmeK4KYwFi8zH3s0M=; b=BJKoH7of4SRTCQfHSQFHoJnivudjbhCWJ54h/c904CyyFx44mVmQjlhQCgRNnHqrwv 8NpLU8zcuqmsuxWEIN7biUhvj8Hv+zWsU+V88mUvg+8it5CX7uD/w1bNQiT664aOFakL LEAS1EIuDzdak/SGLOU6jDw8qm0gZPgMHj+pFCb4sxa1qHj5n6+md74xo5ojd4azySDF szl9BrBVWbOjTH6xD2okf3th4cX9CUJYtrXDo0WgDZj4GZK1ZfsO2+85NnTuDHvO+LKV 5ZyADi2dzxMTfBvk1Mr3AKDpsyPWk5M1Smw7B/qWc/i5fqlxohbhwU2Jwla4QVUIidIP k75Q== X-Forwarded-Encrypted: i=1; AJvYcCU2tf1ukWRSjqCRb2FPwMBgl9H4+cQqHH7UkZrQbRm11fLOQKc8JOjGjNSWsi8mWTa7rCHHcBQq5AnUGe8nk+A71VlU@freebsd.org X-Gm-Message-State: AOJu0Yy7dZIKppYCfv2Y+Sl69IFOCuK5njJUCx9IkPkyUB4kZ7vk9qLL 4jQS3PXIhcwT+HwwyAK3gaJzKLBohRrPW3v1toE7jHwxNVnxXC2v5jzPlgCBYAXjDxI= X-Gm-Gg: ATEYQzwZigEyk7DOgtkW/rEsBdQXa5N6DgCq4yqgBoSyNMjcBOvOAcRclUyhFCCPpyL ZFEUgBPveRjKxBLjjkZTjMwxOsCPx2kbeAQuWScpu8kaO26btkiaet6DPSuV7uXWk5qbhX5xp6m thN+zhdGjRR159b+j6I4Hq3eh4nn914Z2UxQbMFWFEtWKqd6Fr/eDuIHx042seAqmbidwpIUvyH qsZQYWDt3tQLDs4QTchGAzlMmpmVtuBedyHLlbLRl5wTPVRY/9WicxrCN4tVcD0yjfaUycXlJRA 7itmJ+uTvrUXUK3o1FsMz4vEU/O96Y1fxTE5kw6hzK1LpgMoWQBJJ2cZGXTL9faILSCTCEwIHlK LOet8vpowYwkwx71zL+n6lH9sccqUsr3mNwxvbBc0npcw4uEMQFWHUdqWEsjoFg+LXaG1N6YEUC MO6Xh/0RT86fl8uCIBq4OrSIA0O79Yn7Dk77GhLwycsAcqR9CNur/gKyVxHcub6FGu X-Received: by 2002:a05:600c:4753:b0:485:3fe6:2209 with SMTP id 5b1f17b1804b1-485566d516dmr269490755e9.11.1773747309740; Tue, 17 Mar 2026 04:35:09 -0700 (PDT) Received: from smtpclient.apple (nat-184-7.net.cam.ac.uk. [131.111.184.7]) by smtp.gmail.com with ESMTPSA id 5b1f17b1804b1-4856eaa4fb0sm65416975e9.12.2026.03.17.04.35.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 17 Mar 2026 04:35:08 -0700 (PDT) Content-Type: text/plain; charset=utf-8 List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org Mime-Version: 1.0 (Mac OS X Mail 16.0 \(3864.400.21\)) Subject: Re: git: 1d13d938fe6c - main - virtio: Ensure power-of-two alignment for indirect queue From: Jessica Clarke In-Reply-To: <69b939d7.26113.1aca36de@gitrepo.freebsd.org> Date: Tue, 17 Mar 2026 11:34:58 +0000 Cc: "src-committers@freebsd.org" , "dev-commits-src-all@freebsd.org" , "dev-commits-src-main@freebsd.org" , Sarah Walker Content-Transfer-Encoding: quoted-printable Message-Id: <8F587FE2-CF54-4605-9CD6-581FC1D98D34@freebsd.org> References: <69b939d7.26113.1aca36de@gitrepo.freebsd.org> To: Andrew Turner X-Mailer: Apple Mail (2.3864.400.21) X-Rspamd-Pre-Result: action=no action; module=replies; Message is reply to one we originated X-Spamd-Result: default: False [-4.00 / 15.00]; REPLY(-4.00)[]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US] X-Rspamd-Queue-Id: 4fZqdC4g9yz4MPg X-Spamd-Bar: ---- On 17 Mar 2026, at 11:24, Andrew Turner wrote: >=20 > The branch main has been updated by andrew: >=20 > URL: = https://cgit.FreeBSD.org/src/commit/?id=3D1d13d938fe6c7639d2bb4cb5248a1f81= 275b6891 >=20 > commit 1d13d938fe6c7639d2bb4cb5248a1f81275b6891 > Author: Sarah Walker > AuthorDate: 2026-03-17 10:54:30 +0000 > Commit: Andrew Turner > CommitDate: 2026-03-17 10:56:27 +0000 >=20 > virtio: Ensure power-of-two alignment for indirect queue >=20 > Some platforms enforce power-of-two alignment for bus_dma tags. = Rounding up > the natural size may result in over-alignment, but should be safe. >=20 > PR: 293770 > Reviewed by: andrew > Fixes: c499ad6f997c ("virtio: Use bus_dma for ring and = indirect buffer allocations") > Sponsored by: Arm Ltd > Differential Revision: https://reviews.freebsd.org/D55843 > --- > sys/dev/virtio/virtqueue.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) >=20 > diff --git a/sys/dev/virtio/virtqueue.c b/sys/dev/virtio/virtqueue.c > index b7fdb4703ccb..10b5179bd3d5 100644 > --- a/sys/dev/virtio/virtqueue.c > +++ b/sys/dev/virtio/virtqueue.c > @@ -341,7 +341,7 @@ virtqueue_init_indirect(struct virtqueue *vq, int = indirect_size) > align =3D size; Why is this the alignment in the first place? Pre-busdma it just used malloc with no explicit alignment. Given: size =3D indirect_size * sizeof(struct vring_desc); can=E2=80=99t this get quite large? Except VIRTIO_MAX_INDIRECT looks to = be rather stale, tied to the malloc rather than busdma world... Jessica > error =3D bus_dma_tag_create( > bus_get_dma_tag(dev), /* parent */ > - align, /* alignment */ > + roundup_pow_of_two(align), /* alignment */ > 0, /* boundary */ > BUS_SPACE_MAXADDR, /* lowaddr */ > BUS_SPACE_MAXADDR, /* highaddr */ >=20