From owner-svn-src-all@freebsd.org Wed Mar 14 23:23:47 2018 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 59879F5194F for ; Wed, 14 Mar 2018 23:23:47 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: from mail-wm0-x230.google.com (mail-wm0-x230.google.com [IPv6:2a00:1450:400c:c09::230]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id C70FC7D2FC for ; Wed, 14 Mar 2018 23:23:46 +0000 (UTC) (envelope-from shawn.webb@hardenedbsd.org) Received: by mail-wm0-x230.google.com with SMTP id u10so6969755wmu.4 for ; Wed, 14 Mar 2018 16:23:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=hardenedbsd-org.20150623.gappssmtp.com; s=20150623; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=lVXBLdLLVdRAH8WvtTTwn3KL2AMuSLfFRit7UstUkL8=; b=iVh0TJXpMd0m82D0W5awkUECone5LeHF97W4EAv5iiervIeQBt5TTbeEyBgObDmblf jbffkd8hjh13LX22hWxIY1AoOQo2d+7nbtBz14LHAZtaPvcmsN+oI+paQTG9PLjBgPFf yk/WEoAdjkXC2OhQtZJGdg5+f91t75GvRUudn2vZIo4ci4+urTOKEJKnaTbN7PhKOe/U Yb7eJbDc1/cXD1QbHuzAb+C3GPX3+HGvPK4588a3TR+x4/iCPf5LI7wPtyXMLtOUDHZj w7iN6SldjPyLuoVPzO1i7d1iYiaQrkum5fEBLwCw6yJ82B84vJdA/Ck43y6S/shTWIHp rdGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=lVXBLdLLVdRAH8WvtTTwn3KL2AMuSLfFRit7UstUkL8=; b=aZkfeyixvrDm57SFnwJHcMRdKpEMUvmFG/u5nZqpxOWOv7Fi8jGKU/p9/hrI2KzP4c XsOpGuFQ9nI4zxUGTU61PwGFKrdQKSyIM1bE4oTdWob8lruuiJV/CKNs24YikuOEclfK FqB7a+R0auhc4eZ8kFPdhYxdVkEg+TEii8h7+RDo8l0jXAstBwSkItTOL9RxVVU7bhfn vV6toVWcAOyeA0yCTNKRbUxuHzFnejzzRbJftoANLDbM4UAj3WiQS/gnV7O06C3qbKlA wIa60r/yP1N/RnXEKZLySPE+1xiqz0zqbdI9zKvFzgBKI20iSe3wyD4d6UILZxFJewIg jcHg== X-Gm-Message-State: AElRT7FxFvkARfHAe3A3r5pCdnGTyARwUuMHbDiPMco/amvZ8l100H7/ mVaX7bWc0cmYwgy92vC7cJtSqSR11Kc= X-Google-Smtp-Source: AG47ELsuwdSiH5usvsdkaDD24gzPIPlUlpCqH1mbCe4o94bIisTdJUPQWOXWQiZ98QYnp6jcSUheRw== X-Received: by 10.80.177.86 with SMTP id l22mr6737356edd.88.1521069825566; Wed, 14 Mar 2018 16:23:45 -0700 (PDT) Received: from mutt-hbsd (bzq-62-219-3-47.dcenter.bezeqint.net. [62.219.3.47]) by smtp.gmail.com with ESMTPSA id b10sm939871edk.32.2018.03.14.16.23.42 (version=TLS1_2 cipher=ECDHE-RSA-CHACHA20-POLY1305 bits=256/256); Wed, 14 Mar 2018 16:23:44 -0700 (PDT) Date: Wed, 14 Mar 2018 19:23:30 -0400 From: Shawn Webb To: Alan Somers Cc: src-committers , svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r329984 - in head: cddl/contrib/opensolaris/lib/libzpool/common sys/cddl/compat/opensolaris/sys Message-ID: <20180314232330.sjeqpbb3hwc37mhb@mutt-hbsd> References: <201802251429.w1PEThjY035303@repo.freebsd.org> <20180314225009.gu3awgryggsxqmff@mutt-hbsd> <20180314225623.zp6ufw5h7bua4etf@mutt-hbsd> <20180314231150.whi6ndflt77iyybw@mutt-hbsd> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="rpfwgcyxd2hi5f2b" Content-Disposition: inline In-Reply-To: X-Operating-System: FreeBSD mutt-hbsd 12.0-CURRENT FreeBSD 12.0-CURRENT X-PGP-Key: http://pgp.mit.edu/pks/lookup?op=vindex&search=0x6A84658F52456EEE User-Agent: NeoMutt/20171215 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.25 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 23:23:47 -0000 --rpfwgcyxd2hi5f2b Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Wed, Mar 14, 2018 at 05:20:00PM -0600, Alan Somers wrote: > On Wed, Mar 14, 2018 at 5:11 PM, Shawn Webb > wrote: >=20 > > On Wed, Mar 14, 2018 at 05:06:09PM -0600, Alan Somers wrote: > > > On Wed, Mar 14, 2018 at 4:56 PM, Shawn Webb > > > wrote: > > > > > > > On Wed, Mar 14, 2018 at 04:51:27PM -0600, Alan Somers wrote: > > > > > On Wed, Mar 14, 2018 at 4:50 PM, Shawn Webb < > > shawn.webb@hardenedbsd.org> > > > > > wrote: > > > > > > > > > > > On Sun, Feb 25, 2018 at 02:29:43PM +0000, Alan Somers wrote: > > > > > > > Author: asomers > > > > > > > Date: Sun Feb 25 14:29:43 2018 > > > > > > > New Revision: 329984 > > > > > > > URL: https://svnweb.freebsd.org/changeset/base/329984 > > > > > > > > > > > > > > Log: > > > > > > > Don't declare __assfail as static > > > > > > > > > > > > > > It gets called by dmu_buf_init_user, which is inline but not > > > > static. > > > > > > So it > > > > > > > needs global linkage itself. > > > > > > > > > > > > > > Reported by: GCC-6 > > > > > > > MFC after: 17 days > > > > > > > X-MFC-With: 329722 > > > > > > > > > > > > > > > > > > > Hey Alan, > > > > > > > > > > > > This commit breaks compiling world with ASAN. > > > > > > > > > > > > Some applications, like zfs, will fail with this error: > > > > > > > > > > > > /lib/libuutil.so.2: Undefined symbol "__assfail" > > > > > > > > > > > > Thanks, > > > > > > > > > > > > > > > > How does one build world with ASAN ? > > > > > > > > HardenedBSD has a feature branch in its playground repo for ASAN-if= ied > > > > world. > > > > > > > > We introduced two new MK_* toggles: MK_ASAN and MK_ASAN_RECOVER. > > > > MK_ASAN is self-explanitory. MK_ASAN_RECOVER tells the sanitizer > > > > framework to let the application continue running instead of abort > > > > execution. > > > > > > > > Here's where the magic gets set: > > > > > > > > https://github.com/HardenedBSD/hardenedBSD-playground/blob/hardened/ > > > > current/asan/share/mk/bsd.prog.mk#L125-L134 > > > > > > > > Thanks, > > > > > > > > > > I don't use HardenedBSD. Can you provide an invocation that will > > > demonstrate the breakage on FreeBSD head? I tried a few things, and = they > > > all either worked, or failed with errors other than the one you showe= d. > > > > No worries. I've just reverted the commit in that feature branch. If I > > have time, I'll see about porting the ASAN work to vanilla FreeBSD. > > But my time is extremely limited these days. > > > > Thanks, > > >=20 > Ok. BTW, that commit is due for MFC as of today. Unless I hear from you > otherwise, I'll go ahead and MFC it. That's totally fine. The ASAN-ified work is done in a feature branch that will only track HEAD. Given that I'm abusing ASAN in this particular case, the ASAN-ified world should never land in any production build. I don't plan to test 11-STABLE with ASAN. Thanks for letting me know, though. --=20 Shawn Webb Cofounder and Security Engineer HardenedBSD Tor-ified Signal: +1 443-546-8752 GPG Key ID: 0x6A84658F52456EEE GPG Key Fingerprint: 2ABA B6BD EF6A F486 BE89 3D9E 6A84 658F 5245 6EEE --rpfwgcyxd2hi5f2b Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCAAdFiEEKrq2ve9q9Ia+iT2eaoRlj1JFbu4FAlqpru4ACgkQaoRlj1JF bu4AQA/+Oeo5XFuGPbeH0h/UkXPF7mTZoqiLPNNxDneiiJchRQwRpp5nHPz9IzSD /KHcghgvDDXeMLh+k/KURJaS4nPyYSuojS90oi5JMoYFcDfATyedUgSSxXXAUbN4 ldRPoMfxqdl4p1ne6TP6aN8A9Z08epkbzYHxMlnTDUz2CAyRSnNlHXb3acr9rhUN jnd2wbXoiV6tBjPTvnETCGIs4mGSCF2Cj6n+HGfxjerxgWcHtnDf4NJZ60UK5D4m lgK65V1moW40/a7ibElQS+Gily8zd/F7fcoHr+Dq0iOh9ein+Nr55WHyNfFixhlP y5O1PFxdCspofqmSqr7QuWvloFLo7wfldspjqlyaK5y/Gi8jQjrnnjDpE1IroqRf cEW/PtaftradvbAY1+Xzlec7qSJZnpHyDbnfhlbV92/VmLpbMT4nzdB8F+it0wn2 h318CS+EtipI2ZQgc4QXz0Qls3Eldf8hTTOeZQcf9u2D6oaKHhufhqY3+yLmGjp3 c1o1VDPrAKqQTr8HtQcivls8q8AoobJ55ISPEa8H9ysKfcBigV41ECGXlzyJwXYd 1tMeQhKXuFM8zqBvrqLZMNgIPIBHldJr5O3bkOwl5aU2D7PFsI7nvaDdW7V5WCw4 6/KarKr90eB50gGkduA/9tXHE7YK2ZVw5UBp+A9pI/IDZ9s+F+8= =p20Z -----END PGP SIGNATURE----- --rpfwgcyxd2hi5f2b--