From owner-freebsd-arch@freebsd.org Sat Feb 8 19:39:22 2020 Return-Path: Delivered-To: freebsd-arch@mailman.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mailman.nyi.freebsd.org (Postfix) with ESMTP id 3ED16249BCA for ; Sat, 8 Feb 2020 19:39:22 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: from mail-qt1-f194.google.com (mail-qt1-f194.google.com [209.85.160.194]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) server-signature RSA-PSS (4096 bits) client-signature RSA-PSS (2048 bits) client-digest SHA256) (Client CN "smtp.gmail.com", Issuer "GTS CA 1O1" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 48FMtd0pTsz4CCF for ; Sat, 8 Feb 2020 19:39:20 +0000 (UTC) (envelope-from byond.lenox@gmail.com) Received: by mail-qt1-f194.google.com with SMTP id l21so1400986qtr.8 for ; Sat, 08 Feb 2020 11:39:20 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=G22HUy3a1xIIjJRzNzO84VOAoeQOkAcQzuFnDnpElbg=; b=ZDLB6+1bzsI/HBDZ/1MQHwKuqUb1cbN/vEZuBW/2PK7O2R9vs3VAEtOuenhlGYcvjv 6TBef3P9PgH6aMOf9GkvHMRaKGqcyxzh+gW5qv/BF4SxzAdwQZjGQUibRTBdQHHq4f99 6xg6F8ZlDUa5FWsBiwv+XZ/claHH+Mw4fK5sajHjR7NfEaxbeUA4HLcM/KXdgR6rcqRI RtaMcS4wY622vkCYzMLWYBZcaOFNUfVwh2XjaQ0dhvvoP+Uq+5eTcjBHGs8Yo7v7B0zz eqq1wHLr+icOQ4MxhuYD4TytEoV3UAe96hkG3Yu1a+UwksicezPLez5crwhNYwo/UpGc TTtg== X-Gm-Message-State: APjAAAW+siOtL37fLCJ48pCO8vcOXm9IsXjuvk5BTZf3VyaUja1floby 8Wv4PHKtbaAcDX256b8eP0ehHMa1 X-Google-Smtp-Source: APXvYqzMhCCWGwrgXg6AtgIFBOFvtxudBBct0rvT8TINcNVoHxNpTIEHgTP8zfnmlaawun1IwEigbg== X-Received: by 2002:ac8:3254:: with SMTP id y20mr2618698qta.20.1581190759814; Sat, 08 Feb 2020 11:39:19 -0800 (PST) Received: from mail-qt1-f181.google.com (mail-qt1-f181.google.com. [209.85.160.181]) by smtp.gmail.com with ESMTPSA id g18sm3269338qki.13.2020.02.08.11.39.19 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Sat, 08 Feb 2020 11:39:19 -0800 (PST) Received: by mail-qt1-f181.google.com with SMTP id d5so2161149qto.0 for ; Sat, 08 Feb 2020 11:39:19 -0800 (PST) X-Received: by 2002:aed:3f70:: with SMTP id q45mr3879030qtf.310.1581190759281; Sat, 08 Feb 2020 11:39:19 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Kyle Evans Date: Sat, 8 Feb 2020 13:39:07 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: updating cron and atrun To: Josh Aas Cc: "freebsd-arch@freebsd.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable X-Rspamd-Queue-Id: 48FMtd0pTsz4CCF X-Spamd-Bar: --- Authentication-Results: mx1.freebsd.org; dkim=none; dmarc=none; spf=pass (mx1.freebsd.org: domain of byondlenox@gmail.com designates 209.85.160.194 as permitted sender) smtp.mailfrom=byondlenox@gmail.com X-Spamd-Result: default: False [-3.88 / 15.00]; ARC_NA(0.00)[]; TO_DN_EQ_ADDR_SOME(0.00)[]; RCVD_TLS_ALL(0.00)[]; FROM_HAS_DN(0.00)[]; TO_DN_SOME(0.00)[]; R_SPF_ALLOW(-0.20)[+ip4:209.85.128.0/17]; NEURAL_HAM_LONG(-1.00)[-1.000,0]; MIME_GOOD(-0.10)[text/plain]; PREVIOUSLY_DELIVERED(0.00)[freebsd-arch@freebsd.org]; RCVD_VIA_SMTP_AUTH(0.00)[]; RWL_MAILSPIKE_GOOD(0.00)[194.160.85.209.rep.mailspike.net : 127.0.0.18]; DMARC_NA(0.00)[kyle-evans.net]; RCVD_COUNT_THREE(0.00)[4]; MIME_TRACE(0.00)[0:+]; TO_MATCH_ENVRCPT_SOME(0.00)[]; RCPT_COUNT_TWO(0.00)[2]; RCVD_IN_DNSWL_NONE(0.00)[194.160.85.209.list.dnswl.org : 127.0.5.0]; NEURAL_HAM_MEDIUM(-1.00)[-1.000,0]; IP_SCORE(-1.88)[ip: (-4.58), ipnet: 209.85.128.0/17(-3.02), asn: 15169(-1.74), country: US(-0.05)]; FORGED_SENDER(0.30)[self@kyle-evans.net,byondlenox@gmail.com]; R_DKIM_NA(0.00)[]; FREEMAIL_ENVFROM(0.00)[gmail.com]; ASN(0.00)[asn:15169, ipnet:209.85.128.0/17, country:US]; TAGGED_FROM(0.00)[]; FROM_NEQ_ENVFROM(0.00)[self@kyle-evans.net,byondlenox@gmail.com] X-Mailman-Approved-At: Sat, 08 Feb 2020 19:45:07 +0000 X-BeenThere: freebsd-arch@freebsd.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: Discussion related to FreeBSD architecture List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 08 Feb 2020 19:39:22 -0000 On Fri, Feb 7, 2020 at 8:19 AM Josh Aas wrote: > > I was looking for a way to contribute to FreeBSD and I decided to look > into the cron/atrun project listed on this page: > > https://wiki.freebsd.org/IdeasPage#Improve_cron.288.29_and_atrun.288.29 > > I looked into the current code, commits from the past decade, and the > lineage of other versions of cron to see if there is a reasonable plan > for updating FreeBSD=E2=80=99s cron based on another version. It doesn't = seem > like there are any particularly productive new path to take here. ISC > cron is old and unmaintained, and I don=E2=80=99t think NetBSD or OpenBSD= cron > is interesting enough to be worth entirely rebasing on. On top of > that, FreeBSD cron seems to have some FreeBSD-specific functionality > that we=E2=80=99d still need to maintain or =E2=80=9Cupstream=E2=80=9D el= sewhere. > > I=E2=80=99d recommend continuing with the current status quo - keep FreeB= SD=E2=80=99s > version of cron and occasionally pull in security/stability patches as > applicable from OpenBSD or NetBSD. The other options are a lot of work > for little (if any) gain. Happy to hear other opinions though. > > Integrating atrun into cron might be nice but isn=E2=80=99t very interest= ing > IMO. Seems very possible that the cost of that churn outweighs the > benefit. I=E2=80=99d love to hear more about why this is a particularly g= ood > idea if people believe it is. Maybe I=E2=80=99m missing something. > > If people agree I=E2=80=99d recommend removing the cron and atrun suggest= ion > on the Ideas Page. Maintaining that page seems like a pain though, > might I recommend keeping track of these ideas as bugzilla bugs, > tagged with something like =E2=80=9Cideaslist=E2=80=9D? Then you can just= link to that > search. > Hi, I'd be inclined to agree- with cron, we've pulled in some features from OpenBSD and I suspect it'd be easier to continue to do so as our path forward. For anyone's general curiosity, below is an email I wrote when asked about bringing in OpenBSD's (or any new) implementation whole-sale; it's not a complete assessment of our local changes/status, but my thoughts on bare minimum extra work needed to bring in any other implementation. --- Hello! I'm actually mostly indifferent to cron(8) -- I've just been taking up patches otherwise not getting any attention. =3D-) These are the main things we'd probably want to audit/ensure are available in any new implementation: - MAILFROM support - /etc/cron.d and /usr/local/etc/cron.d support - making sure any new implementation properly registers changes to files within as requiring a database reload Worth noting is that we also support @every_minute and @every_second, and @ syntax that would need to be reimplemented -- I don't know about the first two, but I know that we have active users of @ as I've fielded bug reports from one group of them that uses it for $work-type stuff. Some of our recent additions are ports from OpenBSD, like -n and -q per-job flags. Thanks, Kyle Evans