Date: Thu, 8 Jan 2015 21:46:29 +0000 (UTC) From: John Baldwin <jhb@FreeBSD.org> To: src-committers@freebsd.org, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: svn commit: r276855 - head/sys/kern Message-ID: <201501082146.t08LkTu1019278@svn.freebsd.org>
next in thread | raw e-mail | index | archive | help
Author: jhb Date: Thu Jan 8 21:46:28 2015 New Revision: 276855 URL: https://svnweb.freebsd.org/changeset/base/276855 Log: Change the default method for device_quiesce() to return 0 instead of EOPNOTSUPP. The current behavior can mask real quiesce errors since devclass_quiesce_driver() stops iterating over drivers as soon as it gets an error (incluiding EOPNOTSUPP), but the caller it returns the error to explicitly ignores EOPNOTSUPP. Reviewed by: imp Modified: head/sys/kern/device_if.m Modified: head/sys/kern/device_if.m ============================================================================== --- head/sys/kern/device_if.m Thu Jan 8 21:17:35 2015 (r276854) +++ head/sys/kern/device_if.m Thu Jan 8 21:46:28 2015 (r276855) @@ -60,7 +60,7 @@ CODE { static int null_quiesce(device_t dev) { - return EOPNOTSUPP; + return 0; } };
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201501082146.t08LkTu1019278>