From owner-cvs-sys  Tue Jul  8 00:21:12 1997
Return-Path: <owner-cvs-sys>
Received: (from root@localhost)
          by hub.freebsd.org (8.8.5/8.8.5) id AAA02523
          for cvs-sys-outgoing; Tue, 8 Jul 1997 00:21:12 -0700 (PDT)
Received: from alpha.xerox.com (alpha.Xerox.COM [13.1.64.93])
          by hub.freebsd.org (8.8.5/8.8.5) with SMTP id AAA02500;
          Tue, 8 Jul 1997 00:20:55 -0700 (PDT)
Received: from crevenia.parc.xerox.com ([13.2.116.11]) by alpha.xerox.com with SMTP id <105214(7)>; Tue, 8 Jul 1997 00:17:44 PDT
Received: from localhost by crevenia.parc.xerox.com with SMTP id <177512>; Mon, 7 Jul 1997 18:43:49 -0700
To: Julian Elischer <julian@freebsd.org>
cc: cvs-committers@freebsd.org, cvs-all@freebsd.org, cvs-sys@freebsd.org
Subject: Re: cvs commit: src/sys/net if.c 
In-reply-to: Your message of "Mon, 07 Jul 97 10:36:06 PDT."
             <199707071736.KAA29158@freefall.freebsd.org> 
Date: Mon, 7 Jul 1997 18:43:43 PDT
From: Bill Fenner <fenner@parc.xerox.com>
Message-Id: <97Jul7.184349pdt.177512@crevenia.parc.xerox.com>
Sender: owner-cvs-sys@freebsd.org
X-Loop: FreeBSD.org
Precedence: bulk

This should have been a 3-line fix.  I don't understand why you chose
to restructure the first section of code; it has now lost its
parallelism with the next place that looks for a multicast address on
the list.

(e.g. the 2nd bit is

                for (ifma = ifp->if_multiaddrs.lh_first; ifma;
                     ifma = ifma->ifma_link.le_next) {
                        if (equal(ifma->ifma_addr, llsa))
                                break;
                }
                if (ifma) {
	...

so why not leave the first bit looking like that too, or restructure
the 2nd bit in the same way you restructured the 1st bit?)

  Bill