From owner-svn-src-user@FreeBSD.ORG Tue Mar 10 22:55:22 2009 Return-Path: Delivered-To: svn-src-user@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id 47C5410656BF; Tue, 10 Mar 2009 22:55:22 +0000 (UTC) (envelope-from lstewart@freebsd.org) Received: from outbound.icp-qv1-irony-out2.iinet.net.au (outbound.icp-qv1-irony-out2.iinet.net.au [203.59.1.107]) by mx1.freebsd.org (Postfix) with ESMTP id 4AE008FC0A; Tue, 10 Mar 2009 22:55:21 +0000 (UTC) (envelope-from lstewart@freebsd.org) X-IronPort-Anti-Spam-Filtered: true X-IronPort-Anti-Spam-Result: ApoEAF+Ftkl8qF1T/2dsb2JhbADSQoQNBg X-IronPort-AV: E=Sophos;i="4.38,337,1233500400"; d="scan'208";a="448128728" Received: from unknown (HELO lawrence1.loshell.room52.net) ([124.168.93.83]) by outbound.icp-qv1-irony-out2.iinet.net.au with ESMTP; 11 Mar 2009 07:25:42 +0900 Message-ID: <49B6E8E6.6030001@freebsd.org> Date: Wed, 11 Mar 2009 09:25:42 +1100 From: Lawrence Stewart User-Agent: Thunderbird 2.0.0.19 (X11/20090118) MIME-Version: 1.0 To: Doug Barton References: <200903100751.n2A7p02m050724@svn.freebsd.org> <49B6CF13.9060501@FreeBSD.org> <20090310212511.GA53115@onelab2.iet.unipi.it> <49B6DEED.4040902@FreeBSD.org> In-Reply-To: <49B6DEED.4040902@FreeBSD.org> Content-Type: text/plain; charset=ISO-8859-1; format=flowed Content-Transfer-Encoding: 7bit Cc: src-committers@FreeBSD.org, Luigi Rizzo , svn-src-user@FreeBSD.org Subject: Re: svn commit: r189612 - in user/lstewart/alq_varlen_8.x: sys/kern tools/test/alq X-BeenThere: svn-src-user@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the experimental " user" src tree" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 10 Mar 2009 22:55:23 -0000 Doug Barton wrote: > Luigi Rizzo wrote: >> On Tue, Mar 10, 2009 at 01:35:31PM -0700, Doug Barton wrote: >>> Lawrence Stewart wrote: >>>> Author: lstewart >>>> Date: Tue Mar 10 07:50:59 2009 >>>> New Revision: 189612 >>>> URL: http://svn.freebsd.org/changeset/base/189612 >>>> >>>> Log: >>>> More bug and style fixes. >>> Generally it's preferred not to mix these two types of changes. The >>> preferred course of action is to make the style changes, confirm that >>> the binary is unchanged (e.g., with sha256), then do substantive >>> changes. Makes the revision history a little easier to parse down the >>> road. >> well, this is a private branch after all :) > > 1. Good habits come from good practice, and what better place to > practice than in a "private" branch? > > 2. Given that the stuff is in the FreeBSD repository, the presumption > is that it is of some use to the wider FreeBSD community. So IMO > community best practices are a reasonable expectation. Otherwise, why > not just keep it local? Duly noted. Cheers, Lawrence