From owner-svn-src-head@freebsd.org Sat Feb 11 12:55:53 2017 Return-Path: Delivered-To: svn-src-head@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id C00D5CDA73A; Sat, 11 Feb 2017 12:55:53 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: from mail-wr0-x243.google.com (mail-wr0-x243.google.com [IPv6:2a00:1450:400c:c0c::243]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 63C7D1509; Sat, 11 Feb 2017 12:55:53 +0000 (UTC) (envelope-from etnapierala@gmail.com) Received: by mail-wr0-x243.google.com with SMTP id 89so17836649wrr.1; Sat, 11 Feb 2017 04:55:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=sender:date:from:to:cc:subject:message-id:mail-followup-to :references:mime-version:content-disposition:in-reply-to:user-agent; bh=mSwsK/SiE5o3n7++BPDV70GUCKlWK2XUhScQr1vW6DU=; b=i+K27P2js46wNzzzaaBk9LFuSc0OCaLG32Fe4jcyBI3u0yFpIOtBkfFW0tszvRg1gn PJjOikOVTuBhDmK3alJVlCnl+cSQvRncxxupIvQ5x0GHOUUhlrEu2x6ujzBm/Oly/Row PYKffX3uaukb+BrG5lI+3NWTaj73EIRjVgiqJp2dJ7RlOJ4idrtj3rfoF3ZMU6qJP7eS 5s6APBFZaha4j1n+YWyUHaFe9NXE1B2VibUxHONUEBizc/r39hh3lPuUblBP0UyFBycy lU9qNQo/c8ueQPoCHvCZchcnn5i414CUczQphinCqBk+tOYrgzT9LRLAEQxGVB5By/fg lSlg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:from:to:cc:subject:message-id :mail-followup-to:references:mime-version:content-disposition :in-reply-to:user-agent; bh=mSwsK/SiE5o3n7++BPDV70GUCKlWK2XUhScQr1vW6DU=; b=NJpxJ+wkRfwUS3stzP75gxADKBjlLR2/LHp5h8WAy63KDH3M1Q9tUZQwN3KDZZXXVa IxwSv9h2AmjaJYB+yJWYhCVMk9gMPIKxvCrGd3LTIBDBTZCeh05nuThgQ3avbiMiorQD wnCHMYDdG7MHmWNBlv30DhPrCb1dOd0tRl4kZW9q/eoY8WKCbZI5BN+2vbz5dvSBkMei vmEpTS6AuwaZ0M99fAIHS4t6IlmjRuKYia+obfhAJTQTb0cY/f7dyPV1o6I+khv7wrII XiTG71t1RniPGgcEtmGRAPH+tnp48Uqpw5xPggHNRMHX1wEiEZoMkxzzmomhylYMjbHq e/gA== X-Gm-Message-State: AMke39kevxcyQ4qHeYn0bWUpZ54UGjxt3LLsxQUCEUXxtGnOkA+7PKgPv8LaSLExeOQlbg== X-Received: by 10.223.131.193 with SMTP id 59mr11470470wre.186.1486817751286; Sat, 11 Feb 2017 04:55:51 -0800 (PST) Received: from brick (gbh5.clarehall.cam.ac.uk. [131.111.224.37]) by smtp.gmail.com with ESMTPSA id w30sm6342892wrb.5.2017.02.11.04.55.49 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Sat, 11 Feb 2017 04:55:50 -0800 (PST) Sender: =?UTF-8?Q?Edward_Tomasz_Napiera=C5=82a?= Date: Sat, 11 Feb 2017 12:55:48 +0000 From: Edward Tomasz Napierala To: John Baldwin Cc: Gleb Smirnoff , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org Subject: Re: svn commit: r312988 - in head/sys: compat/cloudabi compat/linux kern sys Message-ID: <20170211125548.GB3574@brick> Mail-Followup-To: John Baldwin , Gleb Smirnoff , svn-src-head@freebsd.org, svn-src-all@freebsd.org, src-committers@freebsd.org References: <201701301257.v0UCvNrK065993@repo.freebsd.org> <3349880.lYJPXOWCO7@ralph.baldwin.cx> <20170201182337.GG3334@FreeBSD.org> <148601396.h8ndg2hV6R@ralph.baldwin.cx> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <148601396.h8ndg2hV6R@ralph.baldwin.cx> User-Agent: Mutt/1.7.2 (2016-11-26) X-BeenThere: svn-src-head@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: SVN commit messages for the src tree for head/-current List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 11 Feb 2017 12:55:53 -0000 On 0201T1236, John Baldwin wrote: > On Wednesday, February 01, 2017 10:23:37 AM Gleb Smirnoff wrote: > > On Tue, Jan 31, 2017 at 02:13:36PM -0800, John Baldwin wrote: > > J> On Monday, January 30, 2017 12:57:23 PM Edward Tomasz Napierala wrote: > > J> > Author: trasz > > J> > Date: Mon Jan 30 12:57:22 2017 > > J> > New Revision: 312988 > > J> > URL: https://svnweb.freebsd.org/changeset/base/312988 > > J> > > > J> > Log: > > J> > Add kern_listen(), kern_shutdown(), and kern_socket(), and use them > > J> > instead of their sys_*() counterparts in various compats. The svr4 > > J> > is left untouched, because there's no point. > > J> > > J> Note that you can compile test svr4 since it is still in the tree. > > J> If we want to remove svr4, then we should remove it. However, we > > J> should maintain code that is in the tree if it is still there. > > > > All we can do right now is maintain it as compilable. My example with > > COMPAT_OLDSOCK shows that SVR4 simply doesn't work as kld, and nobody > > complains. > > > > Okay, what if I say on freebsd-arch/freebsd-current that I am going > > to remove it and wait for any objections for a month, and then do it? > > I would rather remove it than start skipping it in tree sweeps. We should > strive to maintain code that is in our tree. If you can't get things tested, > then we are better off removing the code instead of having it rot in the > tree (cf the discussion on old ISA drivers). On one hand you're right. On the other - in this particular case including svr4 (which I have no way of testing) in this sweep could break it, while not touching it couldn't, as the old method continues to work. Removing it is not a bad idea, though. Gleb, would you?