From owner-freebsd-ports-bugs@FreeBSD.ORG  Thu Apr  6 15:10:27 2006
Return-Path: <owner-freebsd-ports-bugs@FreeBSD.ORG>
X-Original-To: freebsd-ports-bugs@hub.freebsd.org
Delivered-To: freebsd-ports-bugs@hub.freebsd.org
Received: from mx1.FreeBSD.org (mx1.freebsd.org [216.136.204.125])
	by hub.freebsd.org (Postfix) with ESMTP id 3CE6016A401
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu,  6 Apr 2006 15:10:27 +0000 (UTC)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (freefall.freebsd.org [216.136.204.21])
	by mx1.FreeBSD.org (Postfix) with ESMTP id 0B53F43D78
	for <freebsd-ports-bugs@hub.freebsd.org>;
	Thu,  6 Apr 2006 15:10:21 +0000 (GMT)
	(envelope-from gnats@FreeBSD.org)
Received: from freefall.freebsd.org (gnats@localhost [127.0.0.1])
	by freefall.freebsd.org (8.13.4/8.13.4) with ESMTP id k36FALxl022927
	for <freebsd-ports-bugs@freefall.freebsd.org>;
	Thu, 6 Apr 2006 15:10:21 GMT
	(envelope-from gnats@freefall.freebsd.org)
Received: (from gnats@localhost)
	by freefall.freebsd.org (8.13.4/8.13.4/Submit) id k36FAL1H022926;
	Thu, 6 Apr 2006 15:10:21 GMT (envelope-from gnats)
Date: Thu, 6 Apr 2006 15:10:21 GMT
Message-Id: <200604061510.k36FAL1H022926@freefall.freebsd.org>
To: freebsd-ports-bugs@FreeBSD.org
From: Kostik Belousov <konstantin.belousov@zoral.com.ua>
Cc: 
Subject: Re: ports/95400: [patch] devel/pwlib 1.10.0 does not compile when
	CPUTYPE?=i686 set
X-BeenThere: freebsd-ports-bugs@freebsd.org
X-Mailman-Version: 2.1.5
Precedence: list
Reply-To: Kostik Belousov <konstantin.belousov@zoral.com.ua>
List-Id: Ports bug reports <freebsd-ports-bugs.freebsd.org>
List-Unsubscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=unsubscribe>
List-Archive: <http://lists.freebsd.org/pipermail/freebsd-ports-bugs>
List-Post: <mailto:freebsd-ports-bugs@freebsd.org>
List-Help: <mailto:freebsd-ports-bugs-request@freebsd.org?subject=help>
List-Subscribe: <http://lists.freebsd.org/mailman/listinfo/freebsd-ports-bugs>, 
	<mailto:freebsd-ports-bugs-request@freebsd.org?subject=subscribe>
X-List-Received-Date: Thu, 06 Apr 2006 15:10:27 -0000

The following reply was made to PR ports/95400; it has been noted by GNATS.

From: Kostik Belousov <konstantin.belousov@zoral.com.ua>
To: Steve Ames <steve@energistic.com>
Cc: bug-followup@freebsd.org, edwin@freebsd.org
Subject: Re: ports/95400: [patch] devel/pwlib 1.10.0 does not compile when CPUTYPE?=i686 set
Date: Thu, 6 Apr 2006 18:09:23 +0300

 On Thu, Apr 06, 2006 at 10:38:37AM -0400, Steve Ames wrote:
 > On Thu, Apr 06, 2006 at 11:24:47AM +0000, Edwin Groothuis wrote:
 > > 
 > > The full text of the PR can be found at:
 > >     http://www.freebsd.org/cgi/query-pr.cgi?pr=ports/95400
 > 
 > Kostik Belousov,
 > 
 > Thank you for spotting this. As you noted that assembler snipped is
 > already disabled for x86_64 (for the same reasons and errors you pointed
 > out). I'm afraid my assembler-fu is not up to the task of evaluating of
 > your correction is correct. If it is correct then I'm OK with submitting
 > the change to the assembler especially if it also fixes the x86_64 case.
 I don't have access to the x86_64 machine and don't have
 time to build a cross-compiler, so, I cannot
 check whether change would work for that arch.
 > 
 > However if the assembler cannot be confirmed I'd prefer we just patch
 > jidctflt.cxx so that it always skips that assembler for all architectures.
 
 See, I can't test the code. It looks like openh323 developers did not
 compile it either. The problem is that sar instruction (shift 
 arithmetical right) requires shift count to be supplied in register
 %cl. Constraint supplied allows for shift count to be put in any register.
 If the code compiles on the developers machine, it was by pure
 coincident.
 
 Because of this, I propose to disable the code uncoditionally.