From owner-svn-src-all@freebsd.org Wed Feb 8 09:53:00 2017 Return-Path: <owner-svn-src-all@freebsd.org> Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id CC7F0CD5102; Wed, 8 Feb 2017 09:53:00 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: from mail-pg0-x244.google.com (mail-pg0-x244.google.com [IPv6:2607:f8b0:400e:c05::244]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 98DB41762; Wed, 8 Feb 2017 09:53:00 +0000 (UTC) (envelope-from yaneurabeya@gmail.com) Received: by mail-pg0-x244.google.com with SMTP id v184so14755234pgv.1; Wed, 08 Feb 2017 01:53:00 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=subject:mime-version:from:in-reply-to:date:cc:message-id:references :to; bh=kHqxtcO847xW+nk1XzTowkQZw1FT0CiCbUZAp32u7s0=; b=WoEVJsSZM2TW5TMFYUr2oAp8cwnzxWrMlBjkJOnwjOny1ibng1ZSwTZ6lqVZ2wAuI3 qki+Foy6aJgmhr2b+THJZro/zgyjD/dj6VwXelONbKIjqINJNYek1rE4tB2V9mF9bxzJ wrSFQCZV7fm2LcmVj3XgEp144d/nNAlhk/HbnZmsED+cqQYzZCeeNf3+TqP0WR/qUHH5 RVjJJ/2M0iK9MWar6dU6K4u6+i7txm69qgFsQvf3hOoM0aVG9mpf1+PdxpbeDh/VKDy5 yOVAUNWnwcpBre1kMaf4uQ2xX9VMs+6NRTsoClQQntXHKVzH9327IMPCMOYhl0osKe8G 1jGA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:mime-version:from:in-reply-to:date:cc :message-id:references:to; bh=kHqxtcO847xW+nk1XzTowkQZw1FT0CiCbUZAp32u7s0=; b=IwbRBRbKkrcxLoq/4K7nEhe5Jy8cXwpK926j6OBk1lUB9+yvOizY++mDaDNKXXQlT1 DfGB462PX6956weRfAS7RhbvZDVz9RhapmjRG5Q04vPdi4KjDTyldzRVPhQXDTlwxNg8 A9ZU7g2f2bIjo9vt8oG3oop6wbk/ASB+NNwDUMucfGtyC/VwWrCkyrldXHcv/RdXmKnU Hif5CMGl8nSFbMp/z9v/3ygVBLWUbmy/t2NSWMXS44BBdDReobVV8Y34lBQ39LuQ5ixW JTM8eW7+sfy9iRfdO8XWYRcS/3FYrrWyRajK/IQ65Zf9J4nWK84OT9QuU8BaoVZzpn7s rWyg== X-Gm-Message-State: AIkVDXKPX788FU+DE4AhkJLRpRPFNCLSzx6fGSVpCBI4wfIf1s0/JM7RCEFdrIDk4Lxuaw== X-Received: by 10.84.225.20 with SMTP id t20mr32977341plj.154.1486547580076; Wed, 08 Feb 2017 01:53:00 -0800 (PST) Received: from pinklady.local (c-73-19-52-228.hsd1.wa.comcast.net. [73.19.52.228]) by smtp.gmail.com with ESMTPSA id u24sm18585151pfi.25.2017.02.08.01.52.59 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Wed, 08 Feb 2017 01:52:59 -0800 (PST) Subject: Re: svn commit: r313437 - head/lib/libutil Mime-Version: 1.0 (Mac OS X Mail 9.3 \(3124\)) Content-Type: multipart/signed; boundary="Apple-Mail=_9876E442-C670-4379-A654-6A495960BE21"; protocol="application/pgp-signature"; micalg=pgp-sha512 X-Pgp-Agent: GPGMail From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> In-Reply-To: <CAE-mSO+mmQKQscFXHG2cBFz2Xgf8brt3csiczLyhXWh8Oi3uUQ@mail.gmail.com> Date: Wed, 8 Feb 2017 01:52:58 -0800 Cc: Ngie Cooper <ngie@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Message-Id: <779F34BC-816D-48E4-90B6-8DD3FCE401A4@gmail.com> References: <201702080922.v189MaUf075951@repo.freebsd.org> <CAE-mSO+mmQKQscFXHG2cBFz2Xgf8brt3csiczLyhXWh8Oi3uUQ@mail.gmail.com> To: Sergey Kandaurov <pluknet@gmail.com> X-Mailer: Apple Mail (2.3124) X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" <svn-src-all.freebsd.org> List-Unsubscribe: <https://lists.freebsd.org/mailman/options/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=unsubscribe> List-Archive: <http://lists.freebsd.org/pipermail/svn-src-all/> List-Post: <mailto:svn-src-all@freebsd.org> List-Help: <mailto:svn-src-all-request@freebsd.org?subject=help> List-Subscribe: <https://lists.freebsd.org/mailman/listinfo/svn-src-all>, <mailto:svn-src-all-request@freebsd.org?subject=subscribe> X-List-Received-Date: Wed, 08 Feb 2017 09:53:00 -0000 --Apple-Mail=_9876E442-C670-4379-A654-6A495960BE21 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Feb 8, 2017, at 01:38, Sergey Kandaurov <pluknet@gmail.com> wrote: >=20 > On 8 February 2017 at 12:22, Ngie Cooper <ngie@freebsd.org> wrote: > Author: ngie > Date: Wed Feb 8 09:22:35 2017 > New Revision: 313437 > URL: https://svnweb.freebsd.org/changeset/base/313437 >=20 > Log: > Create link from hexdump(3) to sbuf_hexdump(9) as the manpage = describes > sbuf_hexdump(9)'s behavior >=20 > MFC after: 3 weeks > Sponsored by: Dell EMC Isilon >=20 > Modified: > head/lib/libutil/Makefile >=20 > Modified: head/lib/libutil/Makefile > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/lib/libutil/Makefile Wed Feb 8 09:19:49 2017 = (r313436) > +++ head/lib/libutil/Makefile Wed Feb 8 09:22:35 2017 = (r313437) > @@ -35,6 +35,7 @@ MAN+=3D expand_number.3 flopen.3 fparseln. > property.3 pty.3 quotafile.3 realhostname.3 realhostname_sa.3 = \ > _secure_path.3 trimdomain.3 uucplock.3 pw_util.3 > MAN+=3D login.conf.5 > +MLINKS+=3Dhexdump.3 sbuf_hexdump.9 >=20 > This looks odd imho also that sbuf_hexdump(3) is part of libsbuf. > Note also hexdump(3) taht's essential copy of hexdump(9). > If go this duplicating route why not copy sbuf_hexdump description as = well. >=20 > I like more how that's done with sbuf(9) that's the only man page, = ymmv. Ack. The implementation is spread between iexdump(3) and sbuf(9), but = probably should just be in sbuf(9). I=E2=80=99ll look at cleaning this = up further after I talk with scottl@ a bit more. Thanks! -Ngie --Apple-Mail=_9876E442-C670-4379-A654-6A495960BE21 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYmup6AAoJEPWDqSZpMIYV/u0QAMTpUlg+dub5Kxse90a5cakw cUBxwitGcKP7kGjvHbJLdjdBlxcqNynXnb+olNL8XUmfJu4WCeFvRg4Rwj8LqsIF AzKapSakVY0BVvFBCiEx45AUNlLLydXtHxDxZVKDJJVqAfkmmbekH3TD/RX2WI8w RLYdDuqs42FW8SDLK8JrGgaOH0iqM45/AXN9RLGMnakGZnZJ3mhwTnLTK+97dwCb A+Xk1t7M9ZG+vsgelmKC4dvkMv8o4Z3PoBJT5tykxhz+uAqy1LEbf55QtPHt8sLA dzb3A+UoXnl81GQaNc2A2bOA66uXPEFIEWGT09c4ex44D0DmLoC0QqRbwc0VIHuw qDnCwEUEiCVbJJor+kZOh57N9fOaFZq3n8gYR2oUkR2bDa97Dmc35r+PKd55uSfo ZVkFFpQgJ2khh6MkYWweFRzP/mZSOaFLgwf79BsPiK+v2WJUVynlJnZcFl1NGyfG /sbcFVnaDrz2/jQvuUUtKwAquJdbXTYC0y1dk13nlEM6DIS4AGpEcZyWdY+XjXWK 8mAun5oaZHd2/N6OKd8OSI5m8V66F00rWSy+eXyBcKL/K7FYW10DwASJ9V/tNYuR mXDxRaTWeDhneKg9SkP5nKtCsc6C8Ei9Jh3uVvq+xjlp6+RNrOiQ77u28LdrAr46 KW3GLGMrKPDADXsrFWbM =pcE5 -----END PGP SIGNATURE----- --Apple-Mail=_9876E442-C670-4379-A654-6A495960BE21--