Date: Wed, 8 Feb 2017 01:52:58 -0800 From: "Ngie Cooper (yaneurabeya)" <yaneurabeya@gmail.com> To: Sergey Kandaurov <pluknet@gmail.com> Cc: Ngie Cooper <ngie@freebsd.org>, src-committers <src-committers@freebsd.org>, svn-src-all@freebsd.org, svn-src-head@freebsd.org Subject: Re: svn commit: r313437 - head/lib/libutil Message-ID: <779F34BC-816D-48E4-90B6-8DD3FCE401A4@gmail.com> In-Reply-To: <CAE-mSO%2BmmQKQscFXHG2cBFz2Xgf8brt3csiczLyhXWh8Oi3uUQ@mail.gmail.com> References: <201702080922.v189MaUf075951@repo.freebsd.org> <CAE-mSO%2BmmQKQscFXHG2cBFz2Xgf8brt3csiczLyhXWh8Oi3uUQ@mail.gmail.com>
next in thread | previous in thread | raw e-mail | index | archive | help
--Apple-Mail=_9876E442-C670-4379-A654-6A495960BE21 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset=utf-8 > On Feb 8, 2017, at 01:38, Sergey Kandaurov <pluknet@gmail.com> wrote: >=20 > On 8 February 2017 at 12:22, Ngie Cooper <ngie@freebsd.org> wrote: > Author: ngie > Date: Wed Feb 8 09:22:35 2017 > New Revision: 313437 > URL: https://svnweb.freebsd.org/changeset/base/313437 >=20 > Log: > Create link from hexdump(3) to sbuf_hexdump(9) as the manpage = describes > sbuf_hexdump(9)'s behavior >=20 > MFC after: 3 weeks > Sponsored by: Dell EMC Isilon >=20 > Modified: > head/lib/libutil/Makefile >=20 > Modified: head/lib/libutil/Makefile > = =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D=3D= =3D=3D=3D > --- head/lib/libutil/Makefile Wed Feb 8 09:19:49 2017 = (r313436) > +++ head/lib/libutil/Makefile Wed Feb 8 09:22:35 2017 = (r313437) > @@ -35,6 +35,7 @@ MAN+=3D expand_number.3 flopen.3 fparseln. > property.3 pty.3 quotafile.3 realhostname.3 realhostname_sa.3 = \ > _secure_path.3 trimdomain.3 uucplock.3 pw_util.3 > MAN+=3D login.conf.5 > +MLINKS+=3Dhexdump.3 sbuf_hexdump.9 >=20 > This looks odd imho also that sbuf_hexdump(3) is part of libsbuf. > Note also hexdump(3) taht's essential copy of hexdump(9). > If go this duplicating route why not copy sbuf_hexdump description as = well. >=20 > I like more how that's done with sbuf(9) that's the only man page, = ymmv. Ack. The implementation is spread between iexdump(3) and sbuf(9), but = probably should just be in sbuf(9). I=E2=80=99ll look at cleaning this = up further after I talk with scottl@ a bit more. Thanks! -Ngie --Apple-Mail=_9876E442-C670-4379-A654-6A495960BE21 Content-Transfer-Encoding: 7bit Content-Disposition: attachment; filename=signature.asc Content-Type: application/pgp-signature; name=signature.asc Content-Description: Message signed with OpenPGP using GPGMail -----BEGIN PGP SIGNATURE----- Comment: GPGTools - https://gpgtools.org iQIcBAEBCgAGBQJYmup6AAoJEPWDqSZpMIYV/u0QAMTpUlg+dub5Kxse90a5cakw cUBxwitGcKP7kGjvHbJLdjdBlxcqNynXnb+olNL8XUmfJu4WCeFvRg4Rwj8LqsIF AzKapSakVY0BVvFBCiEx45AUNlLLydXtHxDxZVKDJJVqAfkmmbekH3TD/RX2WI8w RLYdDuqs42FW8SDLK8JrGgaOH0iqM45/AXN9RLGMnakGZnZJ3mhwTnLTK+97dwCb A+Xk1t7M9ZG+vsgelmKC4dvkMv8o4Z3PoBJT5tykxhz+uAqy1LEbf55QtPHt8sLA dzb3A+UoXnl81GQaNc2A2bOA66uXPEFIEWGT09c4ex44D0DmLoC0QqRbwc0VIHuw qDnCwEUEiCVbJJor+kZOh57N9fOaFZq3n8gYR2oUkR2bDa97Dmc35r+PKd55uSfo ZVkFFpQgJ2khh6MkYWweFRzP/mZSOaFLgwf79BsPiK+v2WJUVynlJnZcFl1NGyfG /sbcFVnaDrz2/jQvuUUtKwAquJdbXTYC0y1dk13nlEM6DIS4AGpEcZyWdY+XjXWK 8mAun5oaZHd2/N6OKd8OSI5m8V66F00rWSy+eXyBcKL/K7FYW10DwASJ9V/tNYuR mXDxRaTWeDhneKg9SkP5nKtCsc6C8Ei9Jh3uVvq+xjlp6+RNrOiQ77u28LdrAr46 KW3GLGMrKPDADXsrFWbM =pcE5 -----END PGP SIGNATURE----- --Apple-Mail=_9876E442-C670-4379-A654-6A495960BE21--
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?779F34BC-816D-48E4-90B6-8DD3FCE401A4>