From owner-svn-src-all@FreeBSD.ORG Wed Jun 10 11:30:09 2009 Return-Path: Delivered-To: svn-src-all@freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:4f8:fff6::34]) by hub.freebsd.org (Postfix) with ESMTP id DB82810656BD; Wed, 10 Jun 2009 11:30:09 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from mail.cksoft.de (mail.cksoft.de [195.88.108.3]) by mx1.freebsd.org (Postfix) with ESMTP id 1FBDB8FC1D; Wed, 10 Jun 2009 11:30:07 +0000 (UTC) (envelope-from bz@FreeBSD.org) Received: from localhost (amavis.fra.cksoft.de [192.168.74.71]) by mail.cksoft.de (Postfix) with ESMTP id 58D4441C6A7; Wed, 10 Jun 2009 13:30:06 +0200 (CEST) X-Virus-Scanned: amavisd-new at cksoft.de Received: from mail.cksoft.de ([195.88.108.3]) by localhost (amavis.fra.cksoft.de [192.168.74.71]) (amavisd-new, port 10024) with ESMTP id 3DIVE5XC2gdU; Wed, 10 Jun 2009 13:30:05 +0200 (CEST) Received: by mail.cksoft.de (Postfix, from userid 66) id A2A1941C6A3; Wed, 10 Jun 2009 13:30:05 +0200 (CEST) Received: from maildrop.int.zabbadoz.net (maildrop.int.zabbadoz.net [10.111.66.10]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mail.int.zabbadoz.net (Postfix) with ESMTP id E78574448E6; Wed, 10 Jun 2009 11:25:50 +0000 (UTC) Date: Wed, 10 Jun 2009 11:25:50 +0000 (UTC) From: "Bjoern A. Zeeb" X-X-Sender: bz@maildrop.int.zabbadoz.net To: Ariff Abdullah In-Reply-To: <20090610184521.56b24c2f.ariff@FreeBSD.org> Message-ID: <20090610112430.X22887@maildrop.int.zabbadoz.net> References: <200906090903.n5993D3E062579@svn.freebsd.org> <20090609090541.D22887@maildrop.int.zabbadoz.net> <20090610175011.E20224@delplex.bde.org> <20090610101009.N22887@maildrop.int.zabbadoz.net> <20090610102419.Q22887@maildrop.int.zabbadoz.net> <20090610184521.56b24c2f.ariff@FreeBSD.org> X-OpenPGP-Key: 0x14003F198FEFA3E77207EE8D2B58B8F83CCF1842 MIME-Version: 1.0 Content-Type: TEXT/PLAIN; charset=US-ASCII; format=flowed Cc: svn-src-head@FreeBSD.org, svn-src-all@FreeBSD.org, src-committers@FreeBSD.org, brde@optusnet.com.au Subject: Re: kmod.mk - modules build framework [was: svn commit: r193818 - head/sys/modules/sound/sound] X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.5 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 10 Jun 2009 11:30:12 -0000 On Wed, 10 Jun 2009, Ariff Abdullah wrote: > On Wed, 10 Jun 2009 10:24:46 +0000 (UTC) > "Bjoern A. Zeeb" wrote: >> On Wed, 10 Jun 2009, Bjoern A. Zeeb wrote: >> >>> On Wed, 10 Jun 2009, Bruce Evans wrote: >>> >>>> On Tue, 9 Jun 2009, Bjoern A. Zeeb wrote: >>>> >>>>> On Tue, 9 Jun 2009, Bjoern A. Zeeb wrote: >>>>>> Log: >>>>>> Depend on @ machine (_ILINKS) as we do with other modules so >>> that @ >>> is there for parallel (-jN) builds. Ideally >>> beforedepends in kmod.mk >>> should do the right thing but it >>> seems it does not. >> >>>>> Anyone with lots of build framework know how may want to look at >>> this. > >>>> Failures only for parallel builds normally mean missing >>> dependencies. > >>>>>> -feeder_eq_gen.h: >>>>>> +feeder_eq_gen.h: @ machine >>>>>> ${AWK} -f @/tools/feeder_eq_mkfilter.awk -- >>> ${FEEDER_EQ_PRESETS} > >>> ${.TARGET} >>>> >>>> Here there is still a missing dependency on the >>>> @/tools/feeder_eq_mkfilter.awk (fixed in the next commit). This >>> dependency > is not very important, but since the utility has "@" >>> in its pathname, > running it certainly depends on "@". >>> >>> And adding it again messes with @ not being there for parallel >>> builds:( >>> >>> Or in other words: >>> >>> ===> sound (depend) >>> ===> sound/sound (depend) >>> make: don't know how to make @/tools/sound/feeder_eq_mkfilter.awk. >>> Stop *** Error code 2 >>> 1 error >>> *** Error code 2 >>> 1 error >>> *** Error code 2 >> >> I forgot to mention that the way we currently seem to handle this >> is: >> >> http://people.freebsd.org/~bz/20090610-02-sound-Makefile.diff >> > > More or less like: > > http://people.freebsd.org/~ariff/sound_Makefile.diff just seen it on current@. > Please test it. Mine worked for me and that's consistent with what we do in sys/modules/svr4/Makefile and sys/modules/linux/Makefile . -- Bjoern A. Zeeb The greatest risk is not taking one.