Date: Wed, 16 May 2012 01:05:16 GMT From: Garrett Cooper <yanegomi@gmail.com> To: freebsd-gnats-submit@FreeBSD.org Subject: ports/167943: [PATCH] fix warnings when compiling iozone Message-ID: <201205160105.q4G15GPt060926@red.freebsd.org> Resent-Message-ID: <201205160110.q4G1A2cd030608@freefall.freebsd.org>
next in thread | raw e-mail | index | archive | help
>Number: 167943 >Category: ports >Synopsis: [PATCH] fix warnings when compiling iozone >Confidential: no >Severity: non-critical >Priority: low >Responsible: freebsd-ports-bugs >State: open >Quarter: >Keywords: >Date-Required: >Class: sw-bug >Submitter-Id: current-users >Arrival-Date: Wed May 16 01:10:02 UTC 2012 >Closed-Date: >Last-Modified: >Originator: Garrett Cooper >Release: 9-STABLE >Organization: n/a >Environment: FreeBSD forza.west.isilon.com 9.0-STABLE FreeBSD 9.0-STABLE #4 r235133: Mon May 7 10:31:22 PDT 2012 root@forza.isilon.com:/usr/obj/usr/src/sys/FORZA amd64 >Description: Some of the OS detection #ifdefs are incomplete for 2 files in iozone, which causes the compiler to spew out a lot of warnings when compiling it. The attached patch fixes those issues. >How-To-Repeat: >Fix: Patch attached with submission follows: --- /dev/null +++ b/benchmarks/iozone/files/patch-libasync.c @@ -1 +1,21 @@ +--- libasync.c 2012-05-14 23:13:13.000000000 -0700 ++++ libasync.c 2012-05-14 23:14:27.000000000 -0700 +@@ -109,7 +109,7 @@ + #include <sys/fs/vx_ioctl.h> + #endif + +-#if defined(OSFV5) || defined(linux) ++#if defined(OSFV5) || defined(linux) || defined(__FreeBSD__) + #include <string.h> + #endif + +@@ -119,7 +119,7 @@ + #include <stdlib.h> + #endif + +-#if ((defined(solaris) && defined(__LP64__)) || defined(__s390x__)) ++#if ((defined(solaris) && defined(__LP64__)) || defined(__s390x__)) || defined(__FreeBSD__) + /* If we are building for 64-bit Solaris, all functions that return pointers + * must be declared before they are used; otherwise the compiler will assume + * that they return ints and the top 32 bits of the pointer will be lost, --- /dev/null +++ b/benchmarks/iozone/files/patch-libbif.c @@ -1 +1,12 @@ +--- libbif.c 2012-05-14 23:13:03.000000000 -0700 ++++ libbif.c 2012-05-14 23:13:42.000000000 -0700 +@@ -27,7 +27,7 @@ + #include <string.h> + #endif + +-#if defined(linux) || defined(__DragonFly__) || defined(macosx) ++#if defined(linux) || defined(__DragonFly__) || defined(macosx) || defined(__FreeBSD__) + #include <unistd.h> + #include <stdlib.h> + #endif >Release-Note: >Audit-Trail: >Unformatted:
Want to link to this message? Use this URL: <https://mail-archive.FreeBSD.org/cgi/mid.cgi?201205160105.q4G15GPt060926>