From nobody Fri Jun 20 13:52:23 2025 X-Original-To: dev-commits-src-all@mlmmj.nyi.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2610:1c1:1:606c::19:1]) by mlmmj.nyi.freebsd.org (Postfix) with ESMTP id 4bNzS86clkz5y3yC; Fri, 20 Jun 2025 13:52:24 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from mxrelay.nyi.freebsd.org (mxrelay.nyi.freebsd.org [IPv6:2610:1c1:1:606c::19:3]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256 client-signature RSA-PSS (4096 bits) client-digest SHA256) (Client CN "mxrelay.nyi.freebsd.org", Issuer "R11" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 4bNzS74PFXz3Xmt; Fri, 20 Jun 2025 13:52:23 +0000 (UTC) (envelope-from git@FreeBSD.org) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750427543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HBQGYkyzsYGmU3SPruwTC3JTWpq0ImL6Oso85DoB3lg=; b=Izc47YM09Q/HTJOalL8VpKedqW8A5upVI65L2hy2ze/F1BPmNbcdESyPucRGX4JiW2QuAQ PrvmzuKOb2F4u+/rm11Cl/i7pPhGFRsq6sDyGXhs++mo59gwrJysUx8iWZm7QP+sf9Rm9a ulArbxs6kLdnmSwRmsXKQbu0De9r157tr1ABH60S6dOkpGFi6gATq9ippnvb7B9grLg4VX O42jOXoEaNmXM9THulKqT46mlc0xy730iI2v/QmS84pYyUF5EU+kqEBAQcC345HVD9rfFg P1m44sXg9CkXj8IDkBiZSyufeMdoHIcqsXhhc1jXAcLy8QtxjASZ39EM+xUMog== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=freebsd.org; s=dkim; t=1750427543; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=HBQGYkyzsYGmU3SPruwTC3JTWpq0ImL6Oso85DoB3lg=; b=ZEl7BiHq1Yntq1hQKX0a9j2TMBIGjoXMCQRuRg5MB7I9RJISbFwJqR98ZxfL0ETocDuGwx pWHmNJell3CsesnlkExP0lJ+htZk0zPFliaB7h4V61a7wWzYSdGlCs/9VZC7Z+pvSo9Tof QtNVmpcJl6O9Xfl++9ItHdsf3/KXwgp9d/PfZukDJBwhcjH18FbQDVEE+pZUducKKsu4Jv L2SnRwCxpVnnWyPNtpriomj4CA0EP0CeUq9i8faFthwrb8k8kUPnp+yKrLWYQ6hdgA3goz OMS1kAL0HDGDQe2dMLNlRHxMFejam2L9xqxNjmVHQk4zM99gzC+hEG+dt+A/Sg== ARC-Authentication-Results: i=1; mx1.freebsd.org; none ARC-Seal: i=1; s=dkim; d=freebsd.org; t=1750427543; a=rsa-sha256; cv=none; b=jOkbG7kQRZFNJovoOoEUsu3X9Kihio/xSSL1kbhQGSrxLNnWO4d5YvQADMev6FsNU2ZBh3 KYYozNrOQTTnUZy+Arhw4X3FKgi4h5rkdGdDkk/bZQ7LXw4w3gx4r3LF1uYEwjt64tCqKI /oiXT+xS1u4CeqpKnvsCm0gm/c1xy4rLKyL872pQTE9XOThjfwUrfn1CzcsHnBkQQn3UD6 8xuKerYnOLcJk7znMARj6VLuJhvIGxuRynR/kiMuyXNXvEOBHA9noJtqNsRGmYtImG2Ju7 3B5MkrZfenclIkjpHmqs2KmWiYWWHLUfkcr24CLxI73HavSoeGb0vzf7evU5aA== Received: from gitrepo.freebsd.org (gitrepo.freebsd.org [IPv6:2610:1c1:1:6068::e6a:5]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (Client did not present a certificate) by mxrelay.nyi.freebsd.org (Postfix) with ESMTPS id 4bNzS72v40znfF; Fri, 20 Jun 2025 13:52:23 +0000 (UTC) (envelope-from git@FreeBSD.org) Received: from gitrepo.freebsd.org ([127.0.1.44]) by gitrepo.freebsd.org (8.18.1/8.18.1) with ESMTP id 55KDqNKH058051; Fri, 20 Jun 2025 13:52:23 GMT (envelope-from git@gitrepo.freebsd.org) Received: (from git@localhost) by gitrepo.freebsd.org (8.18.1/8.18.1/Submit) id 55KDqNd1058048; Fri, 20 Jun 2025 13:52:23 GMT (envelope-from git) Date: Fri, 20 Jun 2025 13:52:23 GMT Message-Id: <202506201352.55KDqNd1058048@gitrepo.freebsd.org> To: src-committers@FreeBSD.org, dev-commits-src-all@FreeBSD.org, dev-commits-src-branches@FreeBSD.org From: Mark Johnston Subject: git: f3ac4f027b26 - stable/14 - dtrace/profile: Stop storing the probe name in struct profile_probe List-Id: Commit messages for all branches of the src repository List-Archive: https://lists.freebsd.org/archives/dev-commits-src-all List-Help: List-Post: List-Subscribe: List-Unsubscribe: X-BeenThere: dev-commits-src-all@freebsd.org Sender: owner-dev-commits-src-all@FreeBSD.org MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit X-Git-Committer: markj X-Git-Repository: src X-Git-Refname: refs/heads/stable/14 X-Git-Reftype: branch X-Git-Commit: f3ac4f027b264fa25a11c53f8a37cf9c90addd1a Auto-Submitted: auto-generated The branch stable/14 has been updated by markj: URL: https://cgit.FreeBSD.org/src/commit/?id=f3ac4f027b264fa25a11c53f8a37cf9c90addd1a commit f3ac4f027b264fa25a11c53f8a37cf9c90addd1a Author: Mark Johnston AuthorDate: 2025-06-04 21:13:08 +0000 Commit: Mark Johnston CommitDate: 2025-06-20 12:46:09 +0000 dtrace/profile: Stop storing the probe name in struct profile_probe It's unused, and the naked strcpy() was susceptible to buffer overflow if one creates, say, a probe called "profile-2000000000ns". Reported by: CHERI MFC after: 1 week Sponsored by: Innovate UK (cherry picked from commit 98ef590f77392159938d2e6f9fd45bf31d10b9c1) --- sys/cddl/dev/profile/profile.c | 2 -- 1 file changed, 2 deletions(-) diff --git a/sys/cddl/dev/profile/profile.c b/sys/cddl/dev/profile/profile.c index a939c13aad45..3b95254be537 100644 --- a/sys/cddl/dev/profile/profile.c +++ b/sys/cddl/dev/profile/profile.c @@ -119,7 +119,6 @@ struct profile_probe_percpu; #endif typedef struct profile_probe { - char prof_name[PROF_NAMELEN]; dtrace_id_t prof_id; int prof_kind; #ifdef illumos @@ -303,7 +302,6 @@ profile_create(hrtime_t interval, char *name, int kind) } prof = kmem_zalloc(sizeof (profile_probe_t), KM_SLEEP); - (void) strcpy(prof->prof_name, name); #ifdef illumos prof->prof_interval = interval; prof->prof_cyclic = CYCLIC_NONE;