From owner-svn-src-all@freebsd.org Tue Oct 6 21:21:12 2015 Return-Path: Delivered-To: svn-src-all@mailman.ysv.freebsd.org Received: from mx1.freebsd.org (mx1.freebsd.org [IPv6:2001:1900:2254:206a::19:1]) by mailman.ysv.freebsd.org (Postfix) with ESMTP id 5BC669B6A0A for ; Tue, 6 Oct 2015 21:21:12 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: from mail-qk0-f173.google.com (mail-qk0-f173.google.com [209.85.220.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (Client CN "smtp.gmail.com", Issuer "Google Internet Authority G2" (verified OK)) by mx1.freebsd.org (Postfix) with ESMTPS id 1DB22E19 for ; Tue, 6 Oct 2015 21:21:11 +0000 (UTC) (envelope-from wlosh@bsdimp.com) Received: by qkap81 with SMTP id p81so92183332qka.2 for ; Tue, 06 Oct 2015 14:21:05 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20130820; h=x-gm-message-state:mime-version:sender:in-reply-to:references:date :message-id:subject:from:to:cc:content-type; bh=FMXOQLb8PlE7LEWAp+O9/eH2uqYcXA0HabDdAunmqnc=; b=XrOdvyazsvOyTBMAWj1GTtH4eLIKieDDTvWeK6Z2V1My4bAYb/ObUea6LblZxge3db TFcqpf9hJJ22Aga+MABhubf1oiWumTo8nIytT9+p3rrc0E9OGwv2YUOjhBt/4Obfgbmj YXwEG/adXuX3Dv9xrKCYyQdoSS6Fdn28axVQTKdO8EqmXLjM8hGKxafc7jWwHjU77jz7 yTdqLhi3KrRrpLW4DAN17zrag6ACX4VWXwcoGtH+18BKez4x//K91KbWSlEdfLzujLhD 4UVaGvC30YUtCMSPDPGx8d4S/VkFHOcLmZamzRToJlhUJ4z/9RckFNrO3oPA6s0FeYzg NIHA== X-Gm-Message-State: ALoCoQnEiZVi8MqVXXklFZ0MrzNNNWUHnRPe3IwsaE33epLOGD53bBW6BDyjj8HwQBjEPwq7k9Z2 MIME-Version: 1.0 X-Received: by 10.55.221.65 with SMTP id n62mr8153760qki.42.1444166465167; Tue, 06 Oct 2015 14:21:05 -0700 (PDT) Sender: wlosh@bsdimp.com Received: by 10.140.80.167 with HTTP; Tue, 6 Oct 2015 14:21:05 -0700 (PDT) X-Originating-IP: [69.53.245.7] In-Reply-To: <20169.1444165538@chaos> References: <201510060418.t964Innu071170@repo.freebsd.org> <56140CAD.8080200@FreeBSD.org> <8D5D1CE5-BC57-464D-9C47-63EFF4C1CF2F@bsdimp.com> <20169.1444165538@chaos> Date: Tue, 6 Oct 2015 15:21:05 -0600 X-Google-Sender-Auth: OTYsUHsykley4TWNpr7lEBKLPJQ Message-ID: Subject: Re: svn commit: r288911 - head/share/mk From: Warner Losh To: "Simon J. Gerraty" Cc: Bryan Drewery , Warner Losh , src-committers , "svn-src-all@freebsd.org" , "svn-src-head@freebsd.org" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: quoted-printable X-Content-Filtered-By: Mailman/MimeDel 2.1.20 X-BeenThere: svn-src-all@freebsd.org X-Mailman-Version: 2.1.20 Precedence: list List-Id: "SVN commit messages for the entire src tree \(except for " user" and " projects" \)" List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 06 Oct 2015 21:21:12 -0000 On Tue, Oct 6, 2015 at 3:05 PM, Simon J. Gerraty wrote: > Warner Losh wrote: > > > The sys.mk change to include src.conf breaks building ports in a > sub-dir > > > of src. Meaning, /usr/src/ports/. The MAKESYSPATH with '.../share/mk= ' > > > finds /usr/src/share/mk and runs off with all of the src.*.mk stuff > long > > > before the port Makefile includes bsd.port.mk, from > > > /usr/src/share/mk/bsd.port.mk, which has a _WITHOUT_SRCCONF=3D guard = set > > > on it to avoid bsd.own.mk from including src.conf. But because sys.m= k > > > is already included long before this, src.conf is already included an= d > > > anything handled in sys.mk has no real way to respect _WITHOUT_SRCCON= F > > > unless it is in the environment > > > > Yuck! > > > > But the real problem here is MAKESYSPATH of =E2=80=A6/share/mk. That wa= s a > > hack until we had something like SRCTOP that we could use for finding > > the right stuff and for individual builds. So if we can solve that > > part of th > > but you only get SRCTOP as a consequence of finding the right > sys.mk et al. Which presumes you have MAKESYSPATH set correctly. > Ie. you find the right src.sys.env.mk and it can set SRCTOP based on > knowing its own location. > > A bit of chicken & egg... > That's why I haven't fixed it. I haven't puzzled out a how to cut the Gordian Knot yet. Warner